forge-std: v1.9.1 -> v1.10.0 (#2098)

* forge-std: v1.9.1 -> v1.10.0
* fix automation contracts

---------

fix: multiple typos of different importance #2095

Co-authored-by: crStiv <cryptostiv7@gmail.com>

Author: hellwolf

lib/forge-std

@@ -89,7 +89,7 @@ contract ManagerTests is FoundrySuperfluidTester {
         new Manager(address(sf.cfa), 2, 1);
     }
 
-    function testDeploymentCheckData() public {
+    function testDeploymentCheckData() public view {
         assertEq(address(manager.cfaV1()), address(sf.cfa), "manager.cfaV1 not equal");
         assertEq(manager.owner(), admin, "manager.owner not equal");
         assertEq(manager.minLower(), MIN_LOWER, "manager.minLower not equal");

packages/automation-contracts/autowrap/test/Manager.t.sol

@@ -93,14 +93,14 @@ contract WrapStrategyTests is FoundrySuperfluidTester {
 
     // SuperToken
 
-    function testSupportedSuperToken() public {
+    function testSupportedSuperToken() public view {
         assertTrue(
             wrapStrategy.isSupportedSuperToken(superToken),
             "SuperToken should be supported"
         );
     }
 
-    function testCannotNonSupportedSuperToken() public {
+    function testCannotNonSupportedSuperToken() public view {
         assertTrue(
             !wrapStrategy.isSupportedSuperToken(nativeSuperToken),
             "Native SuperToken shouldn't be supported"

packages/automation-contracts/autowrap/test/WrapStrategy.t.sol

@@ -441,7 +441,7 @@ contract VestingSchedulerV2 is IVestingSchedulerV2, SuperAppBase {
         if (!disableClaimCheck && schedule.claimValidityDate != 0) 
             revert ScheduleNotClaimed();
 
-        // Ensure that the claming date is after the cliff/flow date and before the claim validity date
+        // Ensure that the claiming date is after the cliff/flow date and before the claim validity date
         if (schedule.cliffAndFlowDate > block.timestamp || 
             _lteDateToExecuteCliffAndFlow(schedule) < block.timestamp)
                 revert TimeWindowInvalid();

packages/automation-contracts/scheduler/contracts/VestingSchedulerV2.sol

@@ -32,7 +32,7 @@ using SuperTokenV1Library for ISuperToken;
  * The contract uses ERC-20 allowance and Superfluid ACL flow operator permissions
  * to automate the vesting on behalf of the sender.
  * The contract is designed to be used with an off-chain automation to execute the vesting start and end.
- * The start and end executions are permisionless.
+ * The start and end executions are permissionless.
  * Execution delays are handled with token transfer compensations, but watch out for complete expiries!
  * @custom:metadata The official addresses and subgraphs can be found from @superfluid-finance/metadata package.
  */
@@ -760,7 +760,7 @@ contract VestingSchedulerV3 is IVestingSchedulerV3, IRelayRecipient {
             revert ScheduleNotClaimed();
         }
 
-        // Ensure that the claming date is after the cliff/flow date and before the claim validity date
+        // Ensure that the claiming date is after the cliff/flow date and before the claim validity date
         if (schedule.cliffAndFlowDate > block.timestamp || _lteDateToExecuteCliffAndFlow(schedule) < block.timestamp) {
             revert TimeWindowInvalid();
         }

packages/automation-contracts/scheduler/contracts/VestingSchedulerV3.sol

@@ -50,7 +50,7 @@ contract FlowSchedulerTest is FoundrySuperfluidTester {
         bytes userData
     );
 
-    /// @dev This is required by solidity for using the SupertTokenV1Library in the tester
+    /// @dev This is required by solidity for using the SuperTokenV1Library in the tester
     using SuperTokenV1Library for SuperToken;
     constructor() FoundrySuperfluidTester(3) {}
     FlowScheduler internal flowScheduler;
@@ -232,7 +232,7 @@ contract FlowSchedulerTest is FoundrySuperfluidTester {
             superToken, alice, defaultStartDate, uint32(1000), int96(1000), defaultStartAmount, defaultStartDate + uint32(3600), "", ""
         );
 
-        vm.expectRevert(0xa3eab6ac); // error CFA_ACL_OPERATOR_NO_CREATE_PERMISSIONS() -> 0xa3eab6ac
+        vm.expectRevert(bytes4(0xa3eab6ac)); // error CFA_ACL_OPERATOR_NO_CREATE_PERMISSIONS() -> 0xa3eab6ac
         vm.warp(defaultStartDate + 1000);
         vm.prank(admin);
         flowScheduler.executeCreateFlow(superToken, bob,alice,"");

packages/automation-contracts/scheduler/test/FlowScheduler.t.sol

@@ -350,7 +350,7 @@ contract FlowSchedulerResolverTest is FoundrySuperfluidTester {
         expectUnexecutable();
     }
 
-    function testDeleteNonExistantStreamAfterEndDate() public {
+    function testDeleteNonExistentStreamAfterEndDate() public {
         vm.startPrank(alice);
 
         uint32 defaultEndDate = defaultStartDate + uint32(3600);

packages/automation-contracts/scheduler/test/FlowSchedulerResolver.t.sol

@@ -200,7 +200,7 @@ contract VestingSchedulerV2Tests is FoundrySuperfluidTester {
         address superToken,
         address sender,
         address receiver
-    ) public {
+    ) public view {
         VestingSchedulerV2.VestingSchedule memory schedule = vestingScheduler.getVestingSchedule(superToken, sender, receiver);
         VestingSchedulerV2.VestingSchedule memory deletedSchedule;
 
@@ -2418,7 +2418,7 @@ contract VestingSchedulerV2Tests is FoundrySuperfluidTester {
 
         uint32 newEndDate = type(uint32).max - 1234;
 
-        // Setting up a batch call. Superfluid Protocol will replace the emtpy context with data about the sender. That's where the sender is retrieved from.
+        // Setting up a batch call. Superfluid Protocol will replace the empty context with data about the sender. That's where the sender is retrieved from.
         ISuperfluid.Operation[] memory ops = new ISuperfluid.Operation[](1);
         ops[0] = ISuperfluid.Operation({
             operationType: BatchOperation.OPERATION_TYPE_SUPERFLUID_CALL_APP_ACTION,

packages/automation-contracts/scheduler/test/VestingSchedulerV2.t.sol

@@ -117,7 +117,7 @@ describe("IDAv1 | Non-Callback Tests", function () {
                 );
             });
 
-            it("#1.1.3 publisher should fail to query non-existant index", async () => {
+            it("#1.1.3 publisher should fail to query non-existent index", async () => {
                 const idata = await t.contracts.ida.getIndex(
                     superToken.address,
                     alice,