removed unnecessary methods

Author: d10r

packages/ethereum-contracts/contracts/interfaces/superfluid/IYieldBackend.sol

@@ -29,27 +29,15 @@ interface IYieldBackend {
     /// Deposits the given amount of the underlying asset into the yield backend.
     function deposit(uint256 amount) external;
 
-    /// Invoked by `SuperToken` as delegatecall.
-    /// Deposits the maximum amount of the underlying asset into the yield backend.
-    /// Maximum is defined by the underlying asset balance of the SuperToken and the yield backend capacity.
-    function depositMax() external;
-
     /// Invoked by `SuperToken` as delegatecall.
     /// Withdraws the given amount of the underlying asset from the yield backend.
     function withdraw(uint256 amount) external;
 
     /// Invoked by `SuperToken` as delegatecall.
-    /// Withdraws the maximum amount of the underlying asset from the yield backend.
-    /// Maximum is defined by how much can be withdrawn from the yield backend at that point in time.
+    /// Withdraws the maximum withdrawable amount of the underlying asset from the yield backend.
     function withdrawMax() external;
 
     /// Invoked by `SuperToken` as delegatecall.
     /// tranfers the deposited asset exceeding totalSupply of the SuperToken to the preset receiver account
     function withdrawSurplus(uint256 totalSupply) external;
-
-    /// Invoked by `SuperToken` as delegatecall.
-    /// Returns the amount of the underlying asset currently managed by the yield backend.
-    /// This shall reflect the amount which could currently be withdrawn from the yield backend,
-    /// including the generated yield.
-    function getManagedAmount() external view returns (uint256);
 }

packages/ethereum-contracts/contracts/superfluid/AaveYieldBackend.sol

@@ -73,13 +73,6 @@ contract AaveYieldBackend is IYieldBackend {
         AAVE_POOL.supply(address(ASSET_TOKEN), amount, address(this), 0);
     }
 
-    function depositMax() external {
-        uint256 amount = USING_WETH ? address(this).balance : ASSET_TOKEN.balanceOf(address(this));
-        if (amount > 0) {
-            deposit(amount);
-        }
-    }
-
     function withdraw(uint256 amount) external {
         // withdraw amount asset by redeeming the corresponding aTokens amount
         if (USING_WETH) {
@@ -105,10 +98,6 @@ contract AaveYieldBackend is IYieldBackend {
         AAVE_POOL.withdraw(address(ASSET_TOKEN), surplusAmount, SURPLUS_RECEIVER);
     }
 
-    function getManagedAmount() external view returns (uint256) {
-        return A_TOKEN.balanceOf(address(this));
-    }
-
     // ============ functions operating on this contract itself (NOT in delegatecall context) ============
 
     // allow unwrapping from WETH to this contract

packages/ethereum-contracts/contracts/superfluid/SparkYieldBackend.sol

@@ -31,13 +31,6 @@ contract SparkYieldBackend is IYieldBackend {
         VAULT.deposit(amount, address(this));
     }
 
-    function depositMax() external {
-        uint256 amount = ASSET_TOKEN.balanceOf(address(this));
-        if (amount > 0) {
-            VAULT.deposit(amount, address(this));
-        }
-    }
-
     function withdraw(uint256 amount) external {
         VAULT.withdraw(amount, address(this), address(this));
     }
@@ -60,8 +53,4 @@ contract SparkYieldBackend is IYieldBackend {
         uint256 surplusAmount = vaultAssets + ASSET_TOKEN.balanceOf(address(this)) - normalizedTotalSupply;
         VAULT.withdraw(surplusAmount, SURPLUS_RECEIVER, address(this));
     }
-
-    function getManagedAmount() external view returns (uint256) {
-        return VAULT.convertToAssets(VAULT.balanceOf(address(this)));
-    }
 }

packages/ethereum-contracts/contracts/superfluid/SuperToken.sol

@@ -207,7 +207,12 @@ contract SuperToken is
         require(address(_yieldBackend) == address(0), "yield backend already set");
         _yieldBackend = newYieldBackend;
         _yieldBackend.dCall(abi.encodeCall(IYieldBackend.enable, ()));
-        _yieldBackend.dCall(abi.encodeCall(IYieldBackend.depositMax, ()));
+        // Assumption: if no underlying token is set, it's the native token wrapper (SETH).
+        // This doesn't hold for pure SuperTokens, but those can't have a yield backend.
+        uint256 depositAmount = address(_underlyingToken) == address(0)
+            ? address(this).balance
+            : _underlyingToken.balanceOf(address(this));
+        _yieldBackend.dCall(abi.encodeCall(IYieldBackend.deposit, (depositAmount)));
         // TODO: emit event
     }