fix tests

Author: d10r

packages/ethereum-contracts/contracts/apps/SuperTokenV1Library.sol

@@ -47,6 +47,7 @@ import {
  * `expectRevert` expects a revert in the next call.
  * If a revert is triggered by library code itself (vs by a call), `expectRevert` will thus not _see_ that.
  * Possible mitigations:
+ * - if available, use an overloaded variant which allows to explicitly specify the sender
  * - avoid higher-level library methods which can themselves trigger reverts in tests where this is an issue
  * - wrap the method invocation into an external helper method which you then invoke with `this.helperMethod()`,
  *   which makes it an external call
@@ -1462,6 +1463,9 @@ library SuperTokenV1Library {
      * @param pool The Superfluid Pool address.
      * @param requestedAmount The amount of tokens to distribute.
      * @return actualAmount The amount actually distributed, which is equal or smaller than `requestedAmount`
+     * NOTE: in foundry tests, you may unexpectedly get `GDA_DISTRIBUTE_FOR_OTHERS_NOT_ALLOWED` reverts
+     * because of the use of `address(this)` as the `from` argument. You can work around this by using
+     * `distribute(token, from, pool, requestedAmount)` instead.
      */
     function distribute(ISuperToken token, ISuperfluidPool pool, uint256 requestedAmount)
         internal
@@ -1517,6 +1521,9 @@ library SuperTokenV1Library {
      * @param requestedFlowRate The flow rate of tokens to distribute.
      * @return actualFlowRate The flowrate actually set, which is equal or smaller than `requestedFlowRate`,
      * depending on pool state - see IGeneralDistributionAgreement.estimateFlowDistributionActualFlowRate().
+     * NOTE: in foundry tests, you may unexpectedly get `GDA_DISTRIBUTE_FOR_OTHERS_NOT_ALLOWED` reverts
+     * because of the use of `address(this)` as the `from` argument. You can work around this by using
+     * `distributeFlow(token, from, pool, requestedFlowRate)` instead.
      */
     function distributeFlow(ISuperToken token, ISuperfluidPool pool, int96 requestedFlowRate)
         internal

packages/ethereum-contracts/contracts/interfaces/agreements/gdav1/IGeneralDistributionAgreementV1.sol

@@ -226,7 +226,7 @@ abstract contract IGeneralDistributionAgreementV1 is ISuperAgreement {
         virtual
         returns (bool success, bytes memory newCtx);
 
-    /// @notice Lets accounts deny or allow 3rd parties to connect them to pools. The default is to allow.
+    /// @notice Allows accounts to control whether third parties can connect them to pools. By default, they can.
     /// @param allow true to allow (only has an effect if it was previously denied), false to deny
     function setConnectPermission(bool allow) external virtual;
 

packages/ethereum-contracts/test/foundry/FoundrySuperfluidTester.t.sol

@@ -128,6 +128,8 @@ contract FoundrySuperfluidTester is Test {
     address internal constant ivan = address(0x429);
     address[] internal TEST_ACCOUNTS = [admin, alice, bob, carol, dan, eve, frank, grace, heidi, ivan];
 
+    address internal constant MAX_TESTER_ADDRESS = address(0x4ff);
+
     /// @dev Other account addresses added that aren't testers (pools, super apps, smart contracts)
     EnumerableSet.AddressSet internal OTHER_ACCOUNTS;
 

packages/ethereum-contracts/test/foundry/agreements/gdav1/GeneralDistributionAgreement.t.sol

@@ -950,6 +950,7 @@ contract GeneralDistributionAgreementV1IntegrationTest is FoundrySuperfluidTeste
     ) public {
         vm.assume(member != address(0));
         vm.assume(member != address(freePool));
+        vm.assume(member != alice); // alice is the test distributor
         vm.assume(units > 0);
         vm.assume(distributionAmount > 0);
         vm.assume(units < distributionAmount);
@@ -992,6 +993,7 @@ contract GeneralDistributionAgreementV1IntegrationTest is FoundrySuperfluidTeste
     function testAutoConnect(address member, uint128 units, uint64 distributionAmount) public {
         vm.assume(member != address(0));
         vm.assume(member != address(freePool));
+        vm.assume(member != alice); // alice is the test distributor
         vm.assume(units > 0);
         vm.assume(units < distributionAmount);