switch to foundry v1 (stable) (#2052)

* switch to foundry v1 (stable)

* migration fixes

* CHANGELOG and readme updates

* keep hotfuzz evm_version at shanghai

* explicit evm_version for automation-contracts

---------

Co-authored-by: Miao ZhiCheng <miao@superfluid.finance>

Author: d10r

flake.lock

@@ -5,7 +5,7 @@
     flake-utils.url = "github:numtide/flake-utils";
     nixpkgs.url = "github:NixOS/nixpkgs/nixpkgs-unstable";
     foundry = {
-      url = "github:shazow/foundry.nix/monthly";
+      url = "github:shazow/foundry.nix/stable";
       inputs.flake-utils.follows = "flake-utils";
       inputs.nixpkgs.follows = "nixpkgs";
     };

flake.nix

@@ -3,6 +3,9 @@ root = '../../../'
 libs = ['lib']
 src = 'packages/automation-contracts/autowrap'
 solc_version = "0.8.23"
+evm_version = 'paris'
+optimizer = true
+optimizer_runs = 200
 remappings = [
     '@superfluid-finance/solidity-semantic-money/src/=packages/solidity-semantic-money/src/',
     '@superfluid-finance/ethereum-contracts/=packages/ethereum-contracts/',

packages/automation-contracts/autowrap/foundry.toml

@@ -77,11 +77,15 @@ contract ManagerTests is FoundrySuperfluidTester {
 
     /// TESTS
 
-    function testFailDeploymentWithoutCFA() public {
+    function test_RevertWhen_DeploymentWithoutCFA() public {
+        vm.expectRevert(IManager.ZeroAddress.selector);
         new Manager(address(0), 1, 2);
     }
 
-    function testFailDeploymentWrongLimits() public {
+    function test_RevertWhen_DeploymentWrongLimits() public {
+        vm.expectRevert(
+            abi.encodeWithSelector(IManager.WrongLimits.selector, 2, 1)
+        );
         new Manager(address(sf.cfa), 2, 1);
     }
 

packages/automation-contracts/autowrap/test/Manager.t.sol

@@ -60,7 +60,8 @@ contract WrapStrategyTests is FoundrySuperfluidTester {
 
     /// TESTS
 
-    function testFailDeploymentWithoutManager() public {
+    function test_RevertWhen_DeploymentWithoutManager() public {
+        vm.expectRevert(IStrategy.ZeroAddress.selector);
         new WrapStrategy(address(0));
     }
 

packages/automation-contracts/autowrap/test/WrapStrategy.t.sol

@@ -3,6 +3,9 @@ root = '../../../'
 libs = ['lib']
 src = 'packages/automation-contracts/scheduler'
 solc_version = "0.8.23"
+evm_version = 'paris'
+optimizer = true
+optimizer_runs = 200
 remappings = [
     '@superfluid-finance/solidity-semantic-money/src/=packages/solidity-semantic-money/src/',
     '@superfluid-finance/ethereum-contracts/=packages/ethereum-contracts/',

packages/automation-contracts/scheduler/foundry.toml

@@ -16,6 +16,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
 - Fixed deployment of SimpleForwarder (solved an issue which caused batch operation `OPERATION_TYPE_SIMPLE_FORWARD_CALL` to always revert)
 - `SuperTokenV1Library.getFlowRate` and `SuperTokenV1Library.getFlowInfo` now also allow querying the flowrate between pools and pool members
 - Superfluid Pools now emit a Transfer event when changing units with `updateMemberUnits`.
+- Dependency foundry updated to 1.0
 
 ### Breaking
 - `SuperTokenV1Library.distributeFlow`: return `actualFlowRate` instead of a bool

packages/ethereum-contracts/CHANGELOG.md

@@ -138,7 +138,7 @@ function testRevertIfDecreaseFlowRateAllowanceAndACLCreateFlow() {
 
 #### Internal Helper Functions
 
-See [`FoundrySuperfluidTester.sol`](test/foundry/FoundrySuperfluidTester.sol) for examples of commonly used internal helper functions.
+See [`FoundrySuperfluidTester.t.sol`](test/foundry/FoundrySuperfluidTester.t.sol) for examples of commonly used internal helper functions.
 If you are writing a test that requires a helper function, the helper function is prefixed with `_` and uses camelCase to indicate that it is an internal helper function. For example:
 
 ```solidity
@@ -199,7 +199,7 @@ In foundry, you can use the `SuperfluidFrameworkDeployer` to deploy the Superflu
 import "forge-std/Test.sol";
 
 import { ERC1820RegistryCompiled } from "@superfluid-finance/ethereum-contracts/contracts/libs/ERC1820RegistryCompiled.sol";
-import { SuperfluidFrameworkDeployer } from "@superfluid-finance/ethereum-contracts/contracts/utils/SuperfluidFrameworkDeployer.sol";
+import { SuperfluidFrameworkDeployer } from "@superfluid-finance/ethereum-contracts/contracts/utils/SuperfluidFrameworkDeployer.t.sol";
 import { TestToken } from "@superfluid-finance/ethereum-contracts/contracts/utils/TestToken.sol";
 import { SuperToken } from "@superfluid-finance/ethereum-contracts/contracts/superfluid/SuperToken.sol";
 
@@ -218,7 +218,7 @@ contract SomeTest is Test {
     }
 }
 ```
-See [SuperfluidFrameworkDeployer.sol](contracts/utils/SuperfluidFrameworkDeployer.sol) for more details.
+See [SuperfluidFrameworkDeployer.t.sol](contracts/utils/SuperfluidFrameworkDeployer.t.sol) for more details.
 
 You can also deploy to a local blockchain (`hardhat` or `anvil`) via a forge script. For example, an example `Deploy.s.sol` file:
 

packages/ethereum-contracts/README.md

@@ -9,6 +9,8 @@ ignored_error_codes = [
 ]
 # keep in sync with truffle-config.js
 evm_version = 'paris'
+optimizer = true
+optimizer_runs = 200
 remappings = [
     '@superfluid-finance/ethereum-contracts/contracts/=packages/ethereum-contracts/contracts/',
     '@superfluid-finance/solidity-semantic-money/src/=packages/solidity-semantic-money/src/',

packages/ethereum-contracts/foundry.toml

@@ -2,6 +2,9 @@
 root = '../..'
 src = 'packages/hot-fuzz/contracts'
 solc_version = "0.8.23"
+evm_version = 'shanghai'
+optimizer = true
+optimizer_runs = 200
 remappings = [
     '@superfluid-finance/ethereum-contracts/contracts/=packages/ethereum-contracts/contracts/',
     '@superfluid-finance/solidity-semantic-money/src/=packages/solidity-semantic-money/src/',