[ETHEREUM-CONTRACTS] updated solhint to v6 (#2128)

* updated solhint to v6
* Remove duplicate import of ISuperfluidToken

Author: d10r

.gitignore

@@ -30,3 +30,6 @@ package-lock.json
 # echidna litters
 crytic-export
 corpus
+
+/broadcast
+/.direnv

README.md

@@ -57,7 +57,7 @@ For technical document, references and tutorials, etc, refer to the
   <a href="https://www.npmjs.com/package/@superfluid-finance/ethereum-contracts" target="_blank">
     <img alt="Version" src="https://img.shields.io/npm/v/@superfluid-finance/ethereum-contracts.svg">
   </a>
-  <a href="https://codecov.io/gh/superfluid-finance/protocol-monorepo/tree/dev/packages/ethereum-contracts">
+  <a href="https://codecov.io/gh/superfluid-org/protocol-monorepo/tree/dev/packages/ethereum-contracts">
     <img src="https://codecov.io/gh/superfluid-finance/protocol-monorepo/branch/dev/graph/badge.svg?token=LJW5NDGEJ9&flag=ethereum-contracts"/>
   </a>
   <a href="#" target="_blank">

flake.nix

@@ -92,7 +92,7 @@
           gnupg
         ];
 
-        # minimem development shell
+        # minimum development shell
         minimumDevInputs = commonDevInputs ++ ethDevInputs ++ defaultNodeDevInputs;
 
         # additional tooling for whitehat hackers

package.json

@@ -33,7 +33,7 @@
         "nyc": "^17.0.0",
         "prettier": "^3.3.3",
         "prettier-eslint": "^16.3.0",
-        "solhint": "^5.0.3",
+        "solhint": "^6.0.2",
         "syncpack": "^13.0.0",
         "truffle": "^5.11.5",
         "ts-node": "^10.9.2",

packages/automation-contracts/autowrap/.solhint.json

@@ -14,6 +14,16 @@
         "constructor-syntax": "error",
         "func-visibility": ["error", { "ignoreConstructors": true }],
         "quotes": ["error", "double"],
-        "max-line-length": ["error", 120]
+        "max-line-length": ["error", 120],
+        "use-natspec": "off",
+        "import-path-check": "off",
+        "gas-indexed-events": "off",
+        "gas-struct-packing": "off",
+        "gas-small-strings": "off",
+        "gas-increment-by-one": "off",
+        "gas-strict-inequalities": "off",
+        "gas-calldata-parameters": "off",
+        "function-max-lines": "off",
+        "contract-name-capwords": "off"
     }
 }

packages/automation-contracts/scheduler/.solhint.json

@@ -14,6 +14,16 @@
         "constructor-syntax": "error",
         "func-visibility": ["error", { "ignoreConstructors": true }],
         "quotes": ["error", "double"],
-        "max-line-length": ["error", 120]
+        "max-line-length": ["error", 120],
+        "use-natspec": "off",
+        "import-path-check": "off",
+        "gas-indexed-events": "off",
+        "gas-struct-packing": "off",
+        "gas-small-strings": "off",
+        "gas-increment-by-one": "off",
+        "gas-strict-inequalities": "off",
+        "gas-calldata-parameters": "off",
+        "function-max-lines": "off",
+        "contract-name-capwords": "off"
     }
 }

packages/ethereum-contracts/.gitignore

@@ -13,3 +13,5 @@
 /packages
 /testing-benchmark.json
 /broadcast
+
+/addrs

packages/ethereum-contracts/.solhint.json

@@ -16,6 +16,16 @@
         "constructor-syntax": "error",
         "func-visibility": ["error", { "ignoreConstructors": true }],
         "quotes": ["error", "double"],
-        "max-line-length": ["error", 120]
+        "max-line-length": ["error", 120],
+        "use-natspec": "off",
+        "import-path-check": "off",
+        "gas-indexed-events": "off",
+        "gas-struct-packing": "off",
+        "gas-small-strings": "off",
+        "gas-increment-by-one": "off",
+        "gas-strict-inequalities": "off",
+        "gas-calldata-parameters": "off",
+        "function-max-lines": "off",
+        "contract-name-capwords": "off"
     }
 }

packages/ethereum-contracts/CHANGELOG.md

@@ -3,6 +3,12 @@ All notable changes to the ethereum-contracts will be documented in this file.
 
 This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [UNRELEASED]
+
+### Changed
+
+- Update solhint to v6.
+
 ## [v1.14.1]
 
 ### Added

packages/ethereum-contracts/contracts/agreements/AgreementLibrary.sol

@@ -7,7 +7,6 @@ import {
     ISuperApp,
     SuperAppDefinitions
 } from "../interfaces/superfluid/ISuperfluid.sol";
-import { ISuperfluidToken } from "../interfaces/superfluid/ISuperfluidToken.sol";
 
 import { SafeCast } from "@openzeppelin-v5/contracts/utils/math/SafeCast.sol";