Skip to content

Commit e14c562

Browse files
committed
change return type of getSimpleACL
1 parent ede6643 commit e14c562

File tree

2 files changed

+11
-10
lines changed

2 files changed

+11
-10
lines changed

packages/ethereum-contracts/contracts/interfaces/superfluid/ISuperfluid.sol

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ import {
1818
/// Note: CustomSuperTokenBase is not included for people building CustomSuperToken.
1919
import { IERC20, IERC20Metadata } from "@openzeppelin/contracts/token/ERC20/extensions/IERC20Metadata.sol";
2020
import { IERC777 } from "@openzeppelin/contracts/token/ERC777/IERC777.sol";
21+
import { IAccessControl } from "@openzeppelin/contracts/access/IAccessControl.sol";
2122
import { ISuperfluidToken } from "./ISuperfluidToken.sol";
2223
import { ISuperToken } from "./ISuperToken.sol";
2324
import { ISuperTokenFactory } from "./ISuperTokenFactory.sol";
@@ -29,10 +30,10 @@ import { IPoolMemberNFT } from "../agreements/gdav1/IPoolMemberNFT.sol";
2930
import { ISuperAgreement } from "./ISuperAgreement.sol";
3031
import { IConstantFlowAgreementV1 } from "../agreements/IConstantFlowAgreementV1.sol";
3132
import { IInstantDistributionAgreementV1 } from "../agreements/IInstantDistributionAgreementV1.sol";
32-
import {
33-
IGeneralDistributionAgreementV1,
34-
PoolConfig,
35-
PoolERC20Metadata
33+
import {
34+
IGeneralDistributionAgreementV1,
35+
PoolConfig,
36+
PoolERC20Metadata
3637
} from "../agreements/gdav1/IGeneralDistributionAgreementV1.sol";
3738
import { ISuperfluidPool } from "../agreements/gdav1/ISuperfluidPool.sol";
3839
/// Superfluid App interfaces:
@@ -660,17 +661,16 @@ interface ISuperfluid {
660661

661662
// solhint-disable max-line-length
662663
/**
663-
* @dev returns the address of the SimpleACL contract (currently used for SuperApp registration permissioning).
664+
* @dev returns the SimpleACL contract (currently used for SuperApp registration permissioning).
664665
* That contract implements the interface [IAccessControl](https://docs.openzeppelin.com/contracts/4.x/api/access#IAccessControl),
665666
* which provides the following functions:
666667
* - [hasRole(role, account)](https://docs.openzeppelin.com/contracts/4.x/api/access#IAccessControl-hasRole-bytes32-address-)
667668
* - [getRoleAdmin(role)](https://docs.openzeppelin.com/contracts/4.x/api/access#IAccessControl-getRoleAdmin-bytes32-)
668669
* - [grantRole(role, account)](https://docs.openzeppelin.com/contracts/4.x/api/access#IAccessControl-grantRole-bytes32-address-)
669670
* - [revokeRole(role, account)](https://docs.openzeppelin.com/contracts/4.x/api/access#IAccessControl-revokeRole-bytes32-address-)
670671
* - [renounceRole(role, account)](https://docs.openzeppelin.com/contracts/4.x/api/access#IAccessControl-renounceRole-bytes32-address-)
671-
* @return address of the SimpleACL contract
672672
*/
673-
function getSimpleACL() external view returns(address);
673+
function getSimpleACL() external view returns(IAccessControl);
674674

675675
/**************************************************************************
676676
* Function modifiers for access control and parameter validations

packages/ethereum-contracts/contracts/superfluid/Superfluid.sol

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,8 @@ import {
1616
SuperfluidGovernanceConfigs,
1717
ISuperfluidToken,
1818
ISuperToken,
19-
ISuperTokenFactory
19+
ISuperTokenFactory,
20+
IAccessControl
2021
} from "../interfaces/superfluid/ISuperfluid.sol";
2122
import { GeneralDistributionAgreementV1 } from "../agreements/gdav1/GeneralDistributionAgreementV1.sol";
2223
import { SuperfluidUpgradeableBeacon } from "../upgradability/SuperfluidUpgradeableBeacon.sol";
@@ -974,8 +975,8 @@ contract Superfluid is
974975
return address(_ERC2771_FORWARDER);
975976
}
976977

977-
function getSimpleACL() external view override returns(address) {
978-
return address(_SIMPLE_ACL);
978+
function getSimpleACL() external view override returns(IAccessControl) {
979+
return _SIMPLE_ACL;
979980
}
980981

981982
/**************************************************************************

0 commit comments

Comments
 (0)