Conversation
* more end user improvements * linting * minor improvements * linting * minor fixes * ui issue * cleanup * linting
|
|
There was a problem hiding this comment.
1 issue found across 11 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/web/src/app/portal/page.tsx">
<violation number="1" location="packages/web/src/app/portal/page.tsx:758">
P2: The credential dialog's "Connect" button has no loading/disabled state during submission, unlike the OAuth connect and disconnect buttons which both track in-progress state (`authenticatingSystem`, `disconnecting`). This allows double-submission of credentials. Add a `savingCredentials` state to disable the button and show a spinner while the request is in flight.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| > | ||
| Cancel | ||
| </Button> | ||
| <Button type="submit">Connect</Button> |
There was a problem hiding this comment.
P2: The credential dialog's "Connect" button has no loading/disabled state during submission, unlike the OAuth connect and disconnect buttons which both track in-progress state (authenticatingSystem, disconnecting). This allows double-submission of credentials. Add a savingCredentials state to disable the button and show a spinner while the request is in flight.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/web/src/app/portal/page.tsx, line 758:
<comment>The credential dialog's "Connect" button has no loading/disabled state during submission, unlike the OAuth connect and disconnect buttons which both track in-progress state (`authenticatingSystem`, `disconnecting`). This allows double-submission of credentials. Add a `savingCredentials` state to disable the button and show a spinner while the request is in flight.</comment>
<file context>
@@ -0,0 +1,765 @@
+ >
+ Cancel
+ </Button>
+ <Button type="submit">Connect</Button>
+ </DialogFooter>
+ </form>
</file context>
Auto-synced from hosted repository
Original PR: https://github.com/superglue-ai/superglue-hosted/pull/330
Author: @stefanfaistenauer
Merged by: @stefanfaistenauer
Summary by cubic
Revamps end-user management. POST /v1/end-users now creates users and returns a restricted API key. Authorization shifts from per-tool to per-system allowedSystems with portal filtering and simplified checks. MCP auth accepts an optional systemId and returns an agentUrl when keys aren’t linked to end users.
New Features
Migration
Written for commit fac952dbffbec74cbaca7f8b2b6d0684ba20ec78. Summary will update on new commits.