fix, Resolve symlinks in temporary repository paths to have consistent paths

It seems that the temporary root directory /var points to /private/var on
macOS. And some usages of the path resolve symlinks (e.g. "git init") and other
do not, yielding a mismatch in file paths.

Author: Andreas Humenberger

evaluate/task/repository.go

@@ -155,6 +155,10 @@ func TemporaryRepository(logger *log.Logger, testDataPath string, repositoryPath
 	if err != nil {
 		return nil, cleanup, pkgerrors.WithStack(err)
 	}
+	temporaryPath, err = filepath.EvalSymlinks(temporaryPath)
+	if err != nil {
+		return nil, cleanup, pkgerrors.WithStack(err)
+	}
 
 	cleanup = func() {
 		if e := os.RemoveAll(temporaryPath); e != nil {

evaluate/task/repository_test.go

@@ -41,7 +41,9 @@ func TestTemporaryRepository(t *testing.T) {
 			actualTemporaryRepository, cleanup, actualErr := TemporaryRepository(logger, tc.TestDataPath, tc.RepositoryPath)
 			defer cleanup()
 
-			assert.Regexp(t, regexp.QuoteMeta(filepath.Clean(os.TempDir())+string(os.PathSeparator))+tc.ExpectedTempPathRegex, actualTemporaryRepository, actualTemporaryRepository)
+			temporaryDirectory, err := filepath.EvalSymlinks(os.TempDir())
+			require.NoError(t, err)
+			assert.Regexp(t, regexp.QuoteMeta(temporaryDirectory+string(os.PathSeparator))+tc.ExpectedTempPathRegex, actualTemporaryRepository, actualTemporaryRepository)
 			assert.Equal(t, tc.ExpectedErr, actualErr)
 
 			if tc.ValidateAfter != nil {

language/rust/language.go

@@ -13,7 +13,6 @@ import (
 	"strings"
 
 	pkgerrors "github.com/pkg/errors"
-	"github.com/zimmski/osutil"
 	"github.com/zimmski/osutil/bytesutil"
 
 	"github.com/symflower/eval-dev-quality/language"
@@ -165,13 +164,6 @@ func (l *Language) ExecuteTests(logger *log.Logger, repositoryPath string) (test
 	if err != nil {
 		return testResult, problems, pkgerrors.WithMessage(pkgerrors.WithStack(err), commandOutput)
 	}
-	for _, block := range coverageData {
-		// HACK The coverage should only contain relative paths but contains a weird build folder on macOS.
-		if index := strings.Index(block.FilePath, "src"); index != -1 && osutil.IsDarwin() && filepath.IsAbs(block.FilePath) {
-			block.FilePath = block.FilePath[index:]
-		}
-	}
-
 	for _, block := range coverageData {
 		if lineStart, ok := testStartLinePerFile[block.FilePath]; ok && block.LineEnd < lineStart && block.Count > 0 {
 			testResult.Coverage++