ci: fix static code check errors

elhimov · oleg-jukovec · commit 7d22652c8026 · 2026-02-06T12:15:09.000+03:00
Closes TNTP-6083
diff --git a/.cspell.yaml b/.cspell.yaml
@@ -30,3 +30,5 @@ ignoreRegExpList:
   - ^\s+(\w+\s+)?"github.com/.*" # Ignore Go import paths.
   - -D[A-Z\d_]+ # Ignore CMake flags "-DFLAG_NAME".
   - \d+-g[a-f\d]{4,} # Ignore git commit hashes in version string.
+
+allowCompoundWords: true
diff --git a/.cspell_project-words.txt b/.cspell_project-words.txt
@@ -4,11 +4,14 @@
 +s
 addfinalizer
 aeon*
+anykey
 autoexpel
 bootstrapper
 ccluster
+cconfig
 clientv3
 clustercmd
+cmdcontext
 commentf
 configcartridgecustom
 connpool
@@ -28,48 +31,80 @@ finalizer*
 flightrec
 getfixturevalue
 golangci
+iconfig
 incdir
 infof
+iproto
 leaderuuid
 libcluster
+libconnect
+libwatchdog
+linecomment
 luabody
 luajit
 luakit
 luarocks
+magefile
+MAKEFLAGS
 mapstructure
 memtx
+multireturn
 mvcc
 mvccpb
+myapp
 nilf
+noarch
 nodeps
 nogc
 nolint
 notarantool
+oldfd
+outputformat
+packignore
+payloadsize
+pflag
+pkgs
+postinst
+preinst
 promptui
 protoc
+pseudographics
 rebootstrap
+regexputil
 replicaset*
+rescan
 rockspec*
 rpmdeb
+rundir
+socketpath
+sourcedir
 specialchars
 sslcafile
+sslcertfile
 sslciphers
+sslkeyfile
 stateboard
 svacer
+sysdetect
 tarantool*
+tinstance
 tlsdialer
 tmpl
 tnt+
 tntp
 trimprefix
 truef
+ttable
+ttlog
 unknowncentralized
 unknownnonetarantooletcd
 unknownnosinglemulti
 unknownoffmanualeventualelectionstatefulsupervised
 unknownoffvotercandidatemanual
 unknownreadrw
 unknownuninitializedbootstrapped
+varbinary
+vclock
 vshard
 vylog
 warnf
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -47,7 +47,8 @@ repos:
         exclude: |
           (?x)^(
                 .*\.pb\.go|
-                .*/third_party/.*
+                .*/third_party/.*|
+                .*-gdb\.py
           )$
         additional_dependencies:
           - "@cspell/dict-markdown"
diff --git a/README.md b/README.md
@@ -1,3 +1,4 @@
+<!-- spell-checker:ignore testfull -->
 
 <a href="http://tarantool.org">
   <img src="https://avatars2.githubusercontent.com/u/2344919?v=2&s=250"
diff --git a/cli/cluster/cluster_test.go b/cli/cluster/cluster_test.go
@@ -11,6 +11,8 @@ import (
 	libcluster "github.com/tarantool/tt/lib/cluster"
 )
 
+// spell-checker:ignore nopath noinstance
+
 func TestGetClusterConfig_path(t *testing.T) {
 	collectors := libcluster.NewCollectorFactory(libcluster.NewDataCollectorFactory())
 	config, err := cluster.GetClusterConfig(collectors, "testdata/app/config.yaml")
diff --git a/cli/cmd/coredump.go b/cli/cmd/coredump.go
@@ -17,7 +17,8 @@ var (
 // NewCoredumpCmd creates coredump command.
 func NewCoredumpCmd() *cobra.Command {
 	cmd := &cobra.Command{
-		Use:   "coredump",
+		Use: "coredump",
+		// spell-checker:ignore coredumps
 		Short: "Perform manipulations with the tarantool coredumps",
 	}
 
diff --git a/cli/codegen/generate_code.go b/cli/codegen/generate_code.go
@@ -112,6 +112,7 @@ func getFileModes(root string) (map[string]int, error) {
 }
 
 func main() {
+	// spell-checker:ignore filemodes
 	err := generateFileModeFile(
 		"cli/create/builtin_templates/templates/cartridge",
 		"cli/create/builtin_templates/static/cartridge_template_filemodes_gen.go",
diff --git a/cli/docker/docker.go b/cli/docker/docker.go
@@ -19,6 +19,8 @@ import (
 	"github.com/moby/term"
 )
 
+// spell-checker:ignore jsonmessage stdcopy
+
 const (
 	// defaultDirPermissions is permissions for new directories.
 	// 0755 - drwxr-xr-x.
diff --git a/cli/install/install.go b/cli/install/install.go
@@ -303,7 +303,7 @@ func programDependenciesInstalled(program search.Program) error {
 				{"make", "make"},
 				{"gcc", " build-essential"},
 			}
-			packages = []string{"coreutils", "sed"}
+			packages = []string{"coreutils", "sed"} // spell-checker:disable-line
 		} else if strings.Contains(osName, "CentOs") {
 			programs = []Package{
 				{"cmake", "cmake"},
diff --git a/cli/pack/rpm_const.go b/cli/pack/rpm_const.go
@@ -84,6 +84,8 @@ const (
 	rpmSenseScriptPostUn = 0x1000
 )
 
+// spell-checker:ignore tmpfiles
+
 var (
 	headerMagic   = []byte{0x8e, 0xad, 0xe8}
 	versionByte   = 0x01
diff --git a/cli/pack/rpm_tagset.go b/cli/pack/rpm_tagset.go
@@ -73,7 +73,7 @@ func (tagSet *rpmTagSetType) addTags(tags ...rpmTagType) {
  *
  *   -- Index ------------------------------------------------------------------
  *
- *  Each index entry contains information about all tags in tagset
+ *  Each index entry contains information about all tags in tag set
  *  (include regionTag).
  *
  *  - 4-byte tag.ID
@@ -293,6 +293,8 @@ func packTag(tag rpmTagType) (*packedTagType, error) {
 			}
 		}
 
+	// spell-checker:ignore bytedString
+
 	case rpmTypeStringArray: // STRING_ARRAY
 		// Value should be strings array.
 		stringsArray, ok := tag.Value.([]string)
diff --git a/cli/pack/rpm_tagset_test.go b/cli/pack/rpm_tagset_test.go
@@ -12,8 +12,6 @@ func hex(b *bytes.Buffer) string {
 	return fmt.Sprintf("%x", b.Bytes())
 }
 
-// Please, read the doc in the tagset.go file
-// to understand how it should work
 // All `right` values was obtained by running the same functions
 // of the old Lua implementation
 
diff --git a/cli/replicaset/cconfig.go b/cli/replicaset/cconfig.go
@@ -219,19 +219,19 @@ func (c *CConfigApplication) Expel(ctx ExpelCtx) error {
 	}
 
 	var instances []running.InstanceCtx
-	var unfound []string
+	var unavailable []string
 	for _, inst := range targetReplicaset.Instances {
 		if !inst.InstanceCtxFound {
 			if inst.Alias != ctx.InstName {
 				// The target instance could be offline.
-				unfound = append(unfound, inst.Alias)
+				unavailable = append(unavailable, inst.Alias)
 			}
 		} else {
 			instances = append(instances, inst.InstanceCtx)
 		}
 	}
-	if len(unfound) > 0 {
-		msg := fmt.Sprintf("could not connect to: %s", strings.Join(unfound, ","))
+	if len(unavailable) > 0 {
+		msg := fmt.Sprintf("could not connect to: %s", strings.Join(unavailable, ","))
 		if !ctx.Force {
 			return fmt.Errorf(
 				"all other instances in the target replicaset should be online, %s", msg)
@@ -367,16 +367,16 @@ func (c *CConfigApplication) Promote(ctx PromoteCtx) error {
 	}
 
 	var instances []running.InstanceCtx
-	var unfound []string
+	var unavailable []string
 	for _, inst := range targetReplicaset.Instances {
 		if !inst.InstanceCtxFound {
-			unfound = append(unfound, inst.Alias)
+			unavailable = append(unavailable, inst.Alias)
 		} else {
 			instances = append(instances, inst.InstanceCtx)
 		}
 	}
-	if len(unfound) > 0 {
-		msg := fmt.Sprintf("could not connect to: %s", strings.Join(unfound, ","))
+	if len(unavailable) > 0 {
+		msg := fmt.Sprintf("could not connect to: %s", strings.Join(unavailable, ","))
 		if !ctx.Force {
 			return fmt.Errorf("all instances in the target replicaset should be online, %s", msg)
 		}
@@ -406,16 +406,16 @@ func (c *CConfigApplication) Demote(ctx DemoteCtx) error {
 	}
 
 	var instances []running.InstanceCtx
-	var unfound []string
+	var unavailable []string
 	for _, inst := range targetReplicaset.Instances {
 		if !inst.InstanceCtxFound {
-			unfound = append(unfound, inst.Alias)
+			unavailable = append(unavailable, inst.Alias)
 		} else {
 			instances = append(instances, inst.InstanceCtx)
 		}
 	}
-	if len(unfound) > 0 {
-		msg := fmt.Sprintf("could not connect to: %s", strings.Join(unfound, ","))
+	if len(unavailable) > 0 {
+		msg := fmt.Sprintf("could not connect to: %s", strings.Join(unavailable, ","))
 		if !ctx.Force {
 			return fmt.Errorf("all instances in the target replicaset should be online, %s", msg)
 		}
@@ -486,8 +486,8 @@ func (c *CConfigApplication) RolesChange(ctx RolesChangeCtx,
 	}
 
 	var (
-		instances []running.InstanceCtx
-		unfound   []string
+		instances   []running.InstanceCtx
+		unavailable []string
 	)
 
 	if ctx.InstName != "" {
@@ -501,7 +501,7 @@ func (c *CConfigApplication) RolesChange(ctx RolesChangeCtx,
 		}
 		for _, inst := range targetReplicaset.Instances {
 			if !inst.InstanceCtxFound {
-				unfound = append(unfound, inst.Alias)
+				unavailable = append(unavailable, inst.Alias)
 				continue
 			}
 			instances = append(instances, inst.InstanceCtx)
@@ -510,15 +510,15 @@ func (c *CConfigApplication) RolesChange(ctx RolesChangeCtx,
 		for _, r := range c.replicasets.Replicasets {
 			for _, i := range r.Instances {
 				if !i.InstanceCtxFound {
-					unfound = append(unfound, i.Alias)
+					unavailable = append(unavailable, i.Alias)
 					continue
 				}
 				instances = append(instances, i.InstanceCtx)
 			}
 		}
 	}
-	if len(unfound) > 0 {
-		msg := "could not connect to: " + strings.Join(unfound, ",")
+	if len(unavailable) > 0 {
+		msg := "could not connect to: " + strings.Join(unavailable, ",")
 		if !ctx.Force {
 			return fmt.Errorf("all instances in the target replicaset should be online, %s", msg)
 		}
diff --git a/cli/replicaset/cmd/demote.go b/cli/replicaset/cmd/demote.go
@@ -24,7 +24,7 @@ type DemoteCtx struct {
 	Conn connector.Connector
 	// RunningCtx is an application running context.
 	RunningCtx running.RunningCtx
-	// Force true if unfound instances can be skipped.
+	// Force true if unavailable instances can be skipped.
 	Force bool
 	// Timeout describes a timeout in seconds.
 	// We keep int as it can be passed to the target instance.
diff --git a/cli/replicaset/cmd/expel.go b/cli/replicaset/cmd/expel.go
@@ -23,7 +23,7 @@ type ExpelCtx struct {
 	Orchestrator replicaset.Orchestrator
 	// RunningCtx is an application running context.
 	RunningCtx running.RunningCtx
-	// Force true if unfound instances can be skipped.
+	// Force true if unavailable instances can be skipped.
 	Force bool
 	// Timeout describes a timeout in seconds.
 	// We keep int as it can be passed to the target instance.
diff --git a/cli/replicaset/cmd/promote.go b/cli/replicaset/cmd/promote.go
@@ -27,7 +27,7 @@ type PromoteCtx struct {
 	Conn connector.Connector
 	// RunningCtx is an application running context.
 	RunningCtx running.RunningCtx
-	// Force true if unfound instances can be skipped.
+	// Force true if unavailable instances can be skipped.
 	Force bool
 	// Timeout describes a timeout in seconds.
 	// We keep int as it can be passed to the target instance.
diff --git a/cli/replicaset/cmd/roles.go b/cli/replicaset/cmd/roles.go
@@ -35,7 +35,7 @@ type RolesChangeCtx struct {
 	Conn connector.Connector
 	// RunningCtx is an application running context.
 	RunningCtx running.RunningCtx
-	// Force is true if unfound instances can be skipped.
+	// Force is true if unavailable instances can be skipped.
 	Force bool
 	// Timeout describes a timeout in seconds.
 	// We keep int as it can be passed to the target instance.
diff --git a/cli/running/writer.go b/cli/running/writer.go
@@ -43,6 +43,7 @@ func NewColorizedPrefixWriter(writer io.Writer, color color.Color, prefix string
 			}
 			buf.Reset()
 
+			// spell-checker:ignore submatch
 			if submatch := logLevelRgx.FindSubmatch(line); submatch != nil {
 				color.Fprint(&buf, prefix)
 				logLevelColors[string(submatch[1])].Fprintln(&buf, string(line))
diff --git a/lib/cluster/etcd.go b/lib/cluster/etcd.go
@@ -20,6 +20,8 @@ import (
 	"google.golang.org/grpc"
 )
 
+// spell-checker:ignore cmps
+
 // EtcdOpts is a way to configure a etcd client.
 type EtcdOpts struct {
 	// Endpoints a slice of endpoints to connect.
@@ -747,11 +749,11 @@ func (publisher EtcdKeyDataPublisher) Publish(revision int64, data []byte) error
 			clientv3.OpPut(getSignKey(publisher.prefix, publisher.key), string(sign)))
 	}
 
-	tresp, err := txn.Then(putOps...).Commit()
+	tResp, err := txn.Then(putOps...).Commit()
 	if err != nil {
 		return fmt.Errorf("failed to put data into etcd: %w", err)
 	}
-	if !tresp.Succeeded {
+	if !tResp.Succeeded {
 		return fmt.Errorf("failed to put data into etcd: wrong revision")
 	}
 
diff --git a/lib/connect/uri_test.go b/lib/connect/uri_test.go
@@ -60,7 +60,7 @@ var validCredentialsUris = []string{
 
 var invalidBaseUris = []string{
 	"tcp:localhost:123123",
-	"tcp:/anyhost:1",
+	"tcp:/anyhost:1", // spell-checker:ignore anyhost
 	"tcp://localhost:asd",
 	"tcp:///localhost:11",
 	"asd://localhost:111",
@@ -243,6 +243,7 @@ func TestParseBaseURI(t *testing.T) {
 	})
 }
 
+// spell-checker:ignore anyname cafile capath
 func TestParseUriOpts(t *testing.T) {
 	const defaultTimeout = 3 * time.Second
 
diff --git a/magefile.publish.go b/magefile.publish.go
diff --git a/test/integration/coredump/test_coredump.py b/test/integration/coredump/test_coredump.py

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+<!-- spell-checker:ignore testfull -->`
`1`	`2`
`2`	`3`	`<a href="http://tarantool.org">`
`3`	`4`	`<img src="https://avatars2.githubusercontent.com/u/2344919?v=2&s=250"`
Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,8 @@ import (`
`11`	`11`	`libcluster "github.com/tarantool/tt/lib/cluster"`
`12`	`12`	`)`
`13`	`13`
	`14`	`+// spell-checker:ignore nopath noinstance`
	`15`	`+`
`14`	`16`	`func TestGetClusterConfig_path(t *testing.T) {`
`15`	`17`	`collectors := libcluster.NewCollectorFactory(libcluster.NewDataCollectorFactory())`
`16`	`18`	`config, err := cluster.GetClusterConfig(collectors, "testdata/app/config.yaml")`
Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,8 @@ var (`
`17`	`17`	`// NewCoredumpCmd creates coredump command.`
`18`	`18`	`func NewCoredumpCmd() *cobra.Command {`
`19`	`19`	`cmd := &cobra.Command{`
`20`		`- Use: "coredump",`
	`20`	`+ Use: "coredump",`
	`21`	`+ // spell-checker:ignore coredumps`
`21`	`22`	`Short: "Perform manipulations with the tarantool coredumps",`
`22`	`23`	`}`
`23`	`24`
Original file line number	Diff line number	Diff line change
`@@ -112,6 +112,7 @@ func getFileModes(root string) (map[string]int, error) {`
`112`	`112`	`}`
`113`	`113`
`114`	`114`	`func main() {`
	`115`	`+ // spell-checker:ignore filemodes`
`115`	`116`	`err := generateFileModeFile(`
`116`	`117`	`"cli/create/builtin_templates/templates/cartridge",`
`117`	`118`	`"cli/create/builtin_templates/static/cartridge_template_filemodes_gen.go",`
Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,8 @@ import (`
`19`	`19`	`"github.com/moby/term"`
`20`	`20`	`)`
`21`	`21`
	`22`	`+// spell-checker:ignore jsonmessage stdcopy`
	`23`	`+`
`22`	`24`	`const (`
`23`	`25`	`// defaultDirPermissions is permissions for new directories.`
`24`	`26`	`// 0755 - drwxr-xr-x.`
Original file line number	Diff line number	Diff line change
`@@ -303,7 +303,7 @@ func programDependenciesInstalled(program search.Program) error {`
`303`	`303`	`{"make", "make"},`
`304`	`304`	`{"gcc", " build-essential"},`
`305`	`305`	`}`
`306`		`- packages = []string{"coreutils", "sed"}`
	`306`	`+ packages = []string{"coreutils", "sed"} // spell-checker:disable-line`
`307`	`307`	`} else if strings.Contains(osName, "CentOs") {`
`308`	`308`	`programs = []Package{`
`309`	`309`	`{"cmake", "cmake"},`
Original file line number	Diff line number	Diff line change
`@@ -84,6 +84,8 @@ const (`
`84`	`84`	`rpmSenseScriptPostUn = 0x1000`
`85`	`85`	`)`
`86`	`86`
	`87`	`+// spell-checker:ignore tmpfiles`
	`88`	`+`
`87`	`89`	`var (`
`88`	`90`	`headerMagic = []byte{0x8e, 0xad, 0xe8}`
`89`	`91`	`versionByte = 0x01`