-
Notifications
You must be signed in to change notification settings - Fork 6
Open
Labels
enhancementNew feature or requestNew feature or request
Description
The internal helper validate_arr_cub() ensures that a numeric array has dimensions that are acceptable to the cubical Ripser source code. However, these constraints in the source code (dim2, dim3, and dim4) seem arbitrary. It may be appropriate to warn the user before proceeding with the computation on a large array, but i believe these hard constraints should be lifted. This can be done easily in the dim2 case and with caution in the dim3 and dim4 cases.
@rrrlw does this seem reasonable to you? I'd also like to contact the authors to ask their reasons.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request