Skip to content

allow cubical to accept larger arrays #43

@corybrunson

Description

@corybrunson

The internal helper validate_arr_cub() ensures that a numeric array has dimensions that are acceptable to the cubical Ripser source code. However, these constraints in the source code ($2000 \times 1000$ for dim2, $512^3$ for dim3, and $64^4$ for dim4) seem arbitrary. It may be appropriate to warn the user before proceeding with the computation on a large array, but i believe these hard constraints should be lifted. This can be done easily in the dim2 case and with caution in the dim3 and dim4 cases.

@rrrlw does this seem reasonable to you? I'd also like to contact the authors to ask their reasons.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions