aws-login -vvv does not print a Traceback on error

[ddriddle]

There is a bug in @error_handler that wraps the _main function in src/awscli_login/credentials.py:

@error_handler()
def _main(profile: Profile, session: Session):
    get_credentials(profile, session)

The code currently just ignore the verbose flag. error_handler will require a refactor to support this use case.

Tasks

• update error_handler to accept and comply with the --verbose flag.

[edthedev]

@ddriddle I took a pass at adding a task breakdown for this. We can discuss during backlog grooming to see if I got the gist of it.

[ddriddle]

I applied the following changes to awscli-login to force an exception to see where the error_handler was working and failing:

diff --git a/src/awscli_login/__main__.py b/src/awscli_login/__main__.py
index 63f37e4..0341575 100755
--- a/src/awscli_login/__main__.py
+++ b/src/awscli_login/__main__.py
@@ -98,6 +98,7 @@ def logout_args(args: Namespace):
 @error_handler(extra_args_handler=logout_args)
 def logout(profile: Profile, session: Session, xargs: Namespace,
            interactive: bool = True):
+    raise Exception("Test 'aws logout' returns a stack trace.")
     if xargs.all:
         profile.remove_all_credentials()
     else:
@@ -108,4 +109,5 @@ def logout(profile: Profile, session: Session, xargs: Namespace,
 
 @error_handler(skip_args=False, validate=True)
 def main(profile: Profile, session: Session, interactive: bool = True):
+    raise Exception("Test 'aws login'  returns a stack trace.")
     login(profile, session, interactive)
diff --git a/src/awscli_login/credentials.py b/src/awscli_login/credentials.py
index f30dd85..94e0120 100644
--- a/src/awscli_login/credentials.py
+++ b/src/awscli_login/credentials.py
@@ -65,6 +65,7 @@ def init_parser():
 
 @error_handler()
 def _main(profile: Profile, session: Session, interactive: bool = True):
+    raise Exception("Test 'aws-login' returns a stack trace.")
     profile.raise_if_logged_out()
     if profile.are_credentials_expired():
         token = login(profile, session, interactive=False)

$ aws login works as expected:

$ aws login --verbose --verbose --verbose
awscli_login.config Loaded config file: /Users/ddriddle/.aws-login/config
awscli_login.config Loaded login profile: default
awscli_login.config Test 'aws login'  returns a stack trace.
awscli_login.config 
Traceback (most recent call last):
  File "/Users/ddriddle/src/github.com/techservicesillinois/awscli-login/src/awscli_login/config.py", line 605, in wrapper
    f(*fargs)
  File "/Users/ddriddle/src/github.com/techservicesillinois/awscli-login/src/awscli_login/__main__.py", line 112, in main
    raise Exception("Test 'aws login'  returns a stack trace.")
Exception: Test 'aws login'  returns a stack trace.

$ aws logout fails to return a stack trace:

$ aws logout --verbose --verbose --verbose
Test 'aws logout' returns a stack trace.

$ aws-login also fails to return a stack trace as was reported:

$ aws-login --verbose --verbose --verbose
Test 'aws-login' returns a stack trace.