Remove broad Exception Catch in test_connectivity

[zdc217]

clearpass-api/src/clearpass/client.py

Lines 86 to 91 in 0239dd8

	def test_connectivity(self):
	try:
	self._get_access_token()
	return True
	except Exception:
	return False

Lines 90 and 91 are not allowing the exception to bubble up to the SOAR log so we don't know what is happening when the test_connectivity function fails in the SOAR Clearpass app. Removing those lines should give us a clearer error message.

Tasks

• remove the catch for Exception
• probably - call raise_on_status
• add a catch for 403 Forbidden
• add a catch for 500 Server Error
• add a catch for 404 Not Found
• stretch - think about how we want to handle time-outs - Ed doesn't mind leaving these to bubble up, though.
• update CHANGELOG and add a tag with a bumped up micro revision to this library

[edthedev]

Main thing is not to catch Exception here.

[edthedev]

Let's try to catch usuals,

• 403 - fix your password
• time-out - fix your networking
• 404 - fix your URL config
• 500 - upstream is broken, talk to them

[edthedev]

Note that, we also need to refactor the unit tests around test_connectivity.

[edthedev]

Blocks clearpass app release.

[tzturner]

Note that _get_access_token() is failing on SOAR. We should test the clearpass-api locally on csoctools02-dev to ensure the function works as expected.

If it works locally it is a credential issue. If not it is a code problem.

[edthedev]

Per https://github.com/techservicesillinois/soar-clearpass/pull/22 the failure we were seeing appears to be due to SOAR not using the automation broker when test_connectivity is called in certain contexts.

[edthedev]

Removed blocker as we can add this later, if we prefer.

[edthedev]

I do still want us to make this change. I think we could simplify it though - since our error should be raised by raise_on_status, we know it will be a HTTPError. So this can be as simple as switching the catch to just HTTPError TokenError (see edit) rather than Exception.

https://requests.readthedocs.io/en/latest/_modules/requests/models/#Response.raise_for_status

Edit: It looks like we manually check that status codes for a 200 range, and raise 'TokenError'.
https://github.com/techservicesillinois/clearpass-api/blob/main/src/clearpass/client.py