Skip to content

prevent callback skipping with triggerOnce and merged refs #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
djk01281 wants to merge 1 commit into
base: main
Choose a base branch
from
+41 −1
Open

prevent callback skipping with triggerOnce and merged refs #747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions src/__tests__/useInView.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,3 +398,42 @@ test("should restore the browser IntersectionObserver", () => {
expect(window.IntersectionObserver).toBeDefined();
expect(vi.isMockFunction(window.IntersectionObserver)).toBe(false);
});

test("should trigger all hooks when using triggerOnce with merged refs", () => {
const MultipleHooksWithTriggerOnce = () => {
const [ref1, inView1] = useInView({ triggerOnce: true });
const [ref2, inView2] = useInView({ triggerOnce: true });
const [ref3, inView3] = useInView({ triggerOnce: true });

const setRefs = useCallback(
(node: Element | null) => {
ref1(node);
ref2(node);
ref3(node);
},
[ref1, ref2, ref3],
);

return (
<div ref={setRefs}>
<div data-testid="item-1" data-inview={inView1.toString()}>
{inView1.toString()}
</div>
<div data-testid="item-2" data-inview={inView2.toString()}>
{inView2.toString()}
</div>
<div data-testid="item-3" data-inview={inView3.toString()}>
{inView3.toString()}
</div>
</div>
);
};

const { getByTestId } = render(<MultipleHooksWithTriggerOnce />);

mockAllIsIntersecting(true);

expect(getByTestId("item-1").getAttribute("data-inview")).toBe("true");
expect(getByTestId("item-2").getAttribute("data-inview")).toBe("true");
expect(getByTestId("item-3").getAttribute("data-inview")).toBe("true");
});
3 changes: 2 additions & 1 deletion src/observe.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,8 @@ function createObserver(options: IntersectionObserverInit) {
entry.isVisible = inView;
}

elements.get(entry.target)?.forEach((callback) => {
// Copy the callbacks array before iterating to prevent issues when callbacks are removed during iteration (e.g., when using triggerOnce)
[...(elements.get(entry.target) ?? [])].forEach((callback) => {
callback(inView, entry);
});
});
Expand Down