Skip to content

Commit 99c731b

Browse files
committed
Simplify policy review output format
- Remove verbose summary tables and counts - Only list violations, not compliant items - Keep feedback concise and actionable - When compliant, just say 'No violations found.' Addresses feedback from #145
1 parent f1a8317 commit 99c731b

File tree

1 file changed

+25
-27
lines changed

1 file changed

+25
-27
lines changed

.agents/policy-officer.md

Lines changed: 25 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -30,36 +30,35 @@ Policy states (when defined in the index):
3030

3131
### 4. Output Format
3232

33-
When assessing compliance, I produce:
33+
Keep feedback **concise and actionable**. Lead with violations that need attention - don't pad with compliant items or verbose explanations.
3434

35-
```markdown
36-
## Policy Compliance Assessment
35+
#### When Violations Exist
3736

38-
### Summary
39-
| Metric | Count |
40-
|--------|-------|
41-
| Total items reviewed | X |
42-
| Compliant | X |
43-
| Violations | X |
37+
```markdown
38+
## Policy Review
4439

45-
<details>
46-
<summary>Violations details</summary>
40+
**1 violation found:**
4741

48-
### Critical Violations
42+
- **`path/to/file.ts`** - [Policy Name](.policies/policy.md): Brief issue description
43+
```typescript
44+
// Copy-paste-ready fix
45+
```
46+
```
4947

50-
| Item | Policy | Issue | Fix |
51-
|------|--------|-------|-----|
52-
| (artifact/location) | (policy name) | (specific issue) | (copy-paste-ready fix) |
48+
#### When Everything is Compliant
5349

54-
### Advisory Notes
55-
- (Optional notes. If Experimental policies were evaluated, include that feedback here; it is advisory only.)
50+
```markdown
51+
## Policy Review
5652

57-
</details>
53+
No violations found.
5854
```
5955

60-
- **Item**: artifact, file, or location (e.g. file path, component name).
61-
- **Critical Violations**: one row per violation of a Strict or Recommended policy.
62-
- **Advisory Notes**: optional notes; all feedback from Experimental policies goes here (not in Critical Violations).
56+
**Guidelines:**
57+
- Only list violations, not compliant items
58+
- One bullet per violation with file path, policy link, and fix
59+
- Keep explanations brief - the policy document has details
60+
- No summary tables or counts - just the actionable items
61+
- No "Advisory Notes" section unless there's something genuinely useful to add
6362

6463
## Constraints
6564

@@ -80,12 +79,11 @@ When assessing compliance, I produce:
8079

8180
### When Assessing Compliance
8281

83-
1. Determine the applicable policy index for the changed artifacts
84-
2. Read the policy list from that index (single source of truth)
85-
3. For each policy, open the linked policy document and apply its checks to the artifacts
86-
4. Classify each finding by policy state: Strict/Recommended -> Critical Violations; Experimental -> Advisory Notes only
87-
5. Document all violations with specific references (file, line, or location)
88-
6. Provide copy-paste-ready fix patterns where possible
82+
1. Read the policy list from `.policies/index.md` (single source of truth)
83+
2. For each policy, open the linked document and apply its checks to changed files
84+
3. Only report violations - skip compliant items
85+
4. For each violation: file path, policy link, brief issue, copy-paste fix
86+
5. Keep it short - if no violations, just say "No violations found."
8987

9088
### When Writing Policies
9189

0 commit comments

Comments
 (0)