Move validating scheme of URL is HTTPS to separate Validator class

Author: thofman

src/Command/AddArticle.php

@@ -17,6 +17,7 @@
 use thofman\KnowledgeBase\Domain\Question\Tag;
 use thofman\KnowledgeBase\Domain\Question\Validation\AlwaysValidValidator;
 use thofman\KnowledgeBase\Domain\Question\Validation\NonEmptyStringValidator;
+use thofman\KnowledgeBase\Domain\Question\Validation\UrlSchemeHttpsValidator;
 use thofman\KnowledgeBase\Domain\Question\Validation\UrlValidator;
 
 #[AsCommand(name: 'app:add-article', description: 'Add an article')]
@@ -55,8 +56,10 @@ static function (string $value): string {
                     throw new RuntimeException($validationResult->validationErrorMessage);
                 }
 
-                if (parse_url($validationResult->value, PHP_URL_SCHEME) !== 'https') {
-                    throw new RuntimeException('URL must be secure (https)');
+                $urlSchemeHttpsValidator = new UrlSchemeHttpsValidator($urlValidator);
+                $validationResult = $urlSchemeHttpsValidator->validate($value);
+                if (!$validationResult->isValid) {
+                    throw new RuntimeException($validationResult->validationErrorMessage);
                 }
 
                 return new StringSanitizer()->sanitize($validationResult->value);

src/Domain/Question/Validation/UrlSchemeHttpsValidator.php

@@ -0,0 +1,26 @@
+<?php
+declare(strict_types=1);
+
+namespace thofman\KnowledgeBase\Domain\Question\Validation;
+
+final readonly class UrlSchemeHttpsValidator implements Validator
+{
+    public function __construct(
+        private UrlValidator $urlValidator,
+    ) {
+    }
+
+    public function validate(string $value): ValidationResult
+    {
+        $validationResult = $this->urlValidator->validate($value);
+        if (!$validationResult->isValid) {
+            return $validationResult;
+        }
+
+        if (parse_url($validationResult->value, PHP_URL_SCHEME) !== 'https') {
+            return ValidationResult::invalid('URL must be secure (https)');
+        }
+
+        return ValidationResult::valid($validationResult->value);
+    }
+}