Merge branch 'main' into nathan/increase-polling-frequency

Author: nathanjcochran

README.md

@@ -230,6 +230,8 @@ Environment variables override configuration file values. All variables use the
 - `TIGER_ANALYTICS` - Enable/disable analytics
 - `TIGER_PASSWORD_STORAGE` - Password storage method: `keyring`, `pgpass`, or `none`
 - `TIGER_DEBUG` - Enable/disable debug logging
+- `TIGER_VERSION_CHECK_URL` - URL to check for latest version
+- `TIGER_VERSION_CHECK_INTERVAL` - Seconds between version checks, 0 to disable
 
 ### Global Flags
 

go.mod

@@ -28,6 +28,7 @@ require (
 	al.essio.dev/pkg/shellescape v1.6.0 // indirect
 	github.com/1password/onepassword-sdk-go v0.3.1 // indirect
 	github.com/Azure/go-ansiterm v0.0.0-20250102033503-faa5f7b0171c // indirect
+	github.com/Masterminds/semver/v3 v3.4.0 // indirect
 	github.com/Microsoft/go-winio v0.6.2 // indirect
 	github.com/adrg/xdg v0.5.3 // indirect
 	github.com/apapsch/go-jsonmerge/v2 v2.0.0 // indirect
@@ -38,6 +39,7 @@ require (
 	github.com/charmbracelet/x/ansi v0.10.1 // indirect
 	github.com/charmbracelet/x/cellbuf v0.0.13-0.20250311204145-2c3ea96c31dd // indirect
 	github.com/charmbracelet/x/term v0.2.1 // indirect
+	github.com/cli/safeexec v1.0.1 // indirect
 	github.com/containerd/errdefs v1.0.0 // indirect
 	github.com/containerd/errdefs/pkg v0.3.0 // indirect
 	github.com/containerd/stargz-snapshotter/estargz v0.16.3 // indirect

go.sum

@@ -35,6 +35,8 @@ github.com/charmbracelet/x/term v0.2.1/go.mod h1:oQ4enTYFV7QN4m0i9mzHrViD7TQKvNE
 github.com/chzyer/logex v1.1.10/go.mod h1:+Ywpsq7O8HXn0nuIou7OrIPyXbp3wmkHB+jjWRnGsAI=
 github.com/chzyer/readline v0.0.0-20180603132655-2972be24d48e/go.mod h1:nSuG5e5PlCu98SY8svDHJxuZscDgtXS6KTTbou5AhLI=
 github.com/chzyer/test v0.0.0-20180213035817-a1ea475d72b1/go.mod h1:Q3SI9o4m/ZMnBNeIyt5eFwwo7qiLfzFZmjNmxjkiQlU=
+github.com/cli/safeexec v1.0.1 h1:e/C79PbXF4yYTN/wauC4tviMxEV13BwljGj0N9j+N00=
+github.com/cli/safeexec v1.0.1/go.mod h1:Z/D4tTN8Vs5gXYHDCbaM1S/anmEDnJb1iW0+EJ5zx3Q=
 github.com/containerd/errdefs v1.0.0 h1:tg5yIfIlQIrxYtu9ajqY42W3lpS19XqdxRQeEwYG8PI=
 github.com/containerd/errdefs v1.0.0/go.mod h1:+YBYIdtsnF4Iw6nWZhJcqGSg/dwvV7tyJ/kCkyJ2k+M=
 github.com/containerd/errdefs/pkg v0.3.0 h1:9IKJ06FvyNlexW690DXuQNx2KA2cUJXx151Xdx3ZPPE=

internal/tiger/cmd/config.go

@@ -1,17 +1,18 @@
 package cmd
 
 import (
-	"encoding/json"
 	"fmt"
+	"io"
+	"time"
 
 	"github.com/olekukonko/tablewriter"
 	"github.com/spf13/cobra"
 	"github.com/spf13/viper"
 	"go.uber.org/zap"
-	"gopkg.in/yaml.v3"
 
 	"github.com/timescale/tiger-cli/internal/tiger/config"
 	"github.com/timescale/tiger-cli/internal/tiger/logging"
+	"github.com/timescale/tiger-cli/internal/tiger/util"
 )
 
 func buildConfigShowCmd() *cobra.Command {
@@ -65,13 +66,14 @@ func buildConfigShowCmd() *cobra.Command {
 				cfgOut.ConfigDir = nil
 			}
 
+			output := cmd.OutOrStdout()
 			switch outputFormat {
 			case "json":
-				return outputJSON(cfgOut, cmd)
+				return util.SerializeToJSON(output, cfgOut)
 			case "yaml":
-				return outputYAML(cfgOut, cmd)
+				return util.SerializeToYAML(output, cfgOut, false)
 			default:
-				return outputTable(cfgOut, cmd)
+				return outputTable(output, cfgOut)
 			}
 		},
 	}
@@ -177,56 +179,53 @@ func buildConfigCmd() *cobra.Command {
 	return cmd
 }
 
-func outputTable(cfg *config.ConfigOutput, cmd *cobra.Command) error {
-	table := tablewriter.NewWriter(cmd.OutOrStdout())
+func outputTable(w io.Writer, cfg *config.ConfigOutput) error {
+	table := tablewriter.NewWriter(w)
 	table.Header("PROPERTY", "VALUE")
 	if cfg.APIURL != nil {
 		table.Append("api_url", *cfg.APIURL)
 	}
+	if cfg.Analytics != nil {
+		table.Append("analytics", fmt.Sprintf("%t", *cfg.Analytics))
+	}
+	if cfg.ConfigDir != nil {
+		table.Append("config_dir", *cfg.ConfigDir)
+	}
 	if cfg.ConsoleURL != nil {
 		table.Append("console_url", *cfg.ConsoleURL)
 	}
-	if cfg.GatewayURL != nil {
-		table.Append("gateway_url", *cfg.GatewayURL)
+	if cfg.Debug != nil {
+		table.Append("debug", fmt.Sprintf("%t", *cfg.Debug))
 	}
 	if cfg.DocsMCP != nil {
 		table.Append("docs_mcp", fmt.Sprintf("%t", *cfg.DocsMCP))
 	}
 	if cfg.DocsMCPURL != nil {
 		table.Append("docs_mcp_url", *cfg.DocsMCPURL)
 	}
-	if cfg.ProjectID != nil {
-		table.Append("project_id", *cfg.ProjectID)
-	}
-	if cfg.ServiceID != nil {
-		table.Append("service_id", *cfg.ServiceID)
+	if cfg.GatewayURL != nil {
+		table.Append("gateway_url", *cfg.GatewayURL)
 	}
 	if cfg.Output != nil {
 		table.Append("output", *cfg.Output)
 	}
-	if cfg.Analytics != nil {
-		table.Append("analytics", fmt.Sprintf("%t", *cfg.Analytics))
-	}
 	if cfg.PasswordStorage != nil {
 		table.Append("password_storage", *cfg.PasswordStorage)
 	}
-	if cfg.Debug != nil {
-		table.Append("debug", fmt.Sprintf("%t", *cfg.Debug))
+	if cfg.ProjectID != nil {
+		table.Append("project_id", *cfg.ProjectID)
 	}
-	if cfg.ConfigDir != nil {
-		table.Append("config_dir", *cfg.ConfigDir)
+	if cfg.ReleasesURL != nil {
+		table.Append("releases_url", *cfg.ReleasesURL)
+	}
+	if cfg.ServiceID != nil {
+		table.Append("service_id", *cfg.ServiceID)
+	}
+	if cfg.VersionCheckInterval != nil {
+		table.Append("version_check_interval", cfg.VersionCheckInterval.String())
+	}
+	if cfg.VersionCheckLastTime != nil {
+		table.Append("version_check_last_time", cfg.VersionCheckLastTime.Format(time.RFC1123))
 	}
 	return table.Render()
 }
-
-func outputJSON(cfg *config.ConfigOutput, cmd *cobra.Command) error {
-	encoder := json.NewEncoder(cmd.OutOrStdout())
-	encoder.SetIndent("", "  ")
-	return encoder.Encode(cfg)
-}
-
-func outputYAML(cfg *config.ConfigOutput, cmd *cobra.Command) error {
-	encoder := yaml.NewEncoder(cmd.OutOrStdout())
-	defer encoder.Close()
-	return encoder.Encode(cfg)
-}

internal/tiger/cmd/config_test.go

@@ -7,6 +7,7 @@ import (
 	"slices"
 	"strings"
 	"testing"
+	"time"
 
 	"gopkg.in/yaml.v3"
 
@@ -106,13 +107,17 @@ password_storage: pgpass
 func TestConfigShow_JSONOutput(t *testing.T) {
 	tmpDir, _ := setupConfigTest(t)
 
+	now := time.Now()
+
 	// Create config file with JSON output format
 	configContent := `api_url: https://json.api.com/v1
 project_id: json-project
 output: json
 analytics: true
 password_storage: none
-`
+version_check_interval: 1h
+version_check_last_time: ` + now.Format(time.RFC3339) + "\n"
+
 	configFile := config.GetConfigFile(tmpDir)
 	if err := os.WriteFile(configFile, []byte(configContent), 0644); err != nil {
 		t.Fatalf("Failed to write config file: %v", err)
@@ -131,18 +136,21 @@ password_storage: none
 
 	// Verify ALL JSON keys and their expected values
 	expectedValues := map[string]interface{}{
-		"api_url":          "https://json.api.com/v1",
-		"console_url":      "https://console.cloud.timescale.com",
-		"gateway_url":      "https://console.cloud.timescale.com/api",
-		"docs_mcp":         true,
-		"docs_mcp_url":     "https://mcp.tigerdata.com/docs",
-		"project_id":       "json-project",
-		"service_id":       "",
-		"output":           "json",
-		"analytics":        true,
-		"password_storage": "none",
-		"debug":            false,
-		"config_dir":       tmpDir,
+		"api_url":                 "https://json.api.com/v1",
+		"console_url":             "https://console.cloud.timescale.com",
+		"gateway_url":             "https://console.cloud.timescale.com/api",
+		"docs_mcp":                true,
+		"docs_mcp_url":            "https://mcp.tigerdata.com/docs",
+		"project_id":              "json-project",
+		"service_id":              "",
+		"output":                  "json",
+		"analytics":               true,
+		"password_storage":        "none",
+		"debug":                   false,
+		"config_dir":              tmpDir,
+		"releases_url":            "https://cli.tigerdata.com",
+		"version_check_interval":  float64(3600000000000), // JSON unmarshals time.Duration as nanoseconds (1 hour = 3600000000000ns)
+		"version_check_last_time": now.Format(time.RFC3339),
 	}
 
 	for key, expectedValue := range expectedValues {
@@ -160,13 +168,16 @@ password_storage: none
 func TestConfigShow_YAMLOutput(t *testing.T) {
 	tmpDir, _ := setupConfigTest(t)
 
+	now := time.Now()
+
 	// Create config file with YAML output format
 	configContent := `api_url: https://yaml.api.com/v1
 project_id: yaml-project
 output: yaml
 analytics: false
 password_storage: keyring
-`
+version_check_last_time: ` + now.Format(time.RFC3339) + "\n"
+
 	configFile := config.GetConfigFile(tmpDir)
 	if err := os.WriteFile(configFile, []byte(configContent), 0644); err != nil {
 		t.Fatalf("Failed to write config file: %v", err)
@@ -178,30 +189,42 @@ password_storage: keyring
 	}
 
 	// Parse YAML output
-	var result map[string]interface{}
+	var result map[string]any
 	if err := yaml.Unmarshal([]byte(output), &result); err != nil {
 		t.Fatalf("Failed to parse YAML output: %v", err)
 	}
 
 	// Verify ALL YAML keys and their expected values
-	expectedValues := map[string]interface{}{
-		"api_url":          "https://yaml.api.com/v1",
-		"console_url":      "https://console.cloud.timescale.com",
-		"gateway_url":      "https://console.cloud.timescale.com/api",
-		"docs_mcp":         true,
-		"docs_mcp_url":     "https://mcp.tigerdata.com/docs",
-		"project_id":       "yaml-project",
-		"service_id":       "",
-		"output":           "yaml",
-		"analytics":        false,
-		"password_storage": "keyring",
-		"debug":            false,
-		"config_dir":       tmpDir,
+	expectedValues := map[string]any{
+		"api_url":                 "https://yaml.api.com/v1",
+		"console_url":             "https://console.cloud.timescale.com",
+		"gateway_url":             "https://console.cloud.timescale.com/api",
+		"docs_mcp":                true,
+		"docs_mcp_url":            "https://mcp.tigerdata.com/docs",
+		"project_id":              "yaml-project",
+		"service_id":              "",
+		"output":                  "yaml",
+		"analytics":               false,
+		"password_storage":        "keyring",
+		"debug":                   false,
+		"config_dir":              tmpDir,
+		"releases_url":            "https://cli.tigerdata.com",
+		"version_check_interval":  "24h0m0s", // YAML serializes time.Duration as string
+		"version_check_last_time": now,
 	}
 
 	for key, expectedValue := range expectedValues {
-		if result[key] != expectedValue {
-			t.Errorf("Expected %s '%v', got %v", key, expectedValue, result[key])
+		switch expectedValue.(type) {
+		case time.Time:
+			// YAML unmarshals time.Time as time.Time type, so we need to compare differently
+			if expectedValue.(time.Time).Format(time.RFC3339) != result[key].(time.Time).Format(time.RFC3339) {
+				t.Errorf("foo Expected %s '%v', got %v", key, expectedValue, result[key])
+			}
+		default:
+			// Other types can be compared directly
+			if result[key] != expectedValue {
+				t.Errorf("Expected %s '%v', got %v", key, expectedValue, result[key])
+			}
 		}
 	}
 

internal/tiger/cmd/root.go

@@ -10,6 +10,7 @@ import (
 
 	"github.com/timescale/tiger-cli/internal/tiger/config"
 	"github.com/timescale/tiger-cli/internal/tiger/logging"
+	"github.com/timescale/tiger-cli/internal/tiger/version"
 )
 
 func buildRootCmd() *cobra.Command {
@@ -19,6 +20,7 @@ func buildRootCmd() *cobra.Command {
 	var serviceID string
 	var analytics bool
 	var passwordStorage string
+	var skipUpdateCheck bool
 
 	cmd := &cobra.Command{
 		Use:   "tiger",
@@ -33,14 +35,13 @@ tiger auth login
 
 `,
 		PersistentPreRunE: func(cmd *cobra.Command, args []string) error {
-			if err := logging.Init(debug); err != nil {
-				return fmt.Errorf("failed to initialize logging: %w", err)
-			}
-
 			cfg, err := config.Load()
 			if err != nil {
-				logging.Error("failed to load config", zap.Error(err))
-				return err
+				return fmt.Errorf("failed to load config: %w", err)
+			}
+
+			if err := logging.Init(cfg.Debug); err != nil {
+				return fmt.Errorf("failed to initialize logging: %w", err)
 			}
 
 			logging.Debug("CLI initialized",
@@ -51,8 +52,24 @@ tiger auth login
 
 			return nil
 		},
-		PersistentPostRun: func(cmd *cobra.Command, args []string) {
+		PersistentPostRunE: func(cmd *cobra.Command, args []string) error {
+			cfg, err := config.Load()
+			if err != nil {
+				return fmt.Errorf("failed to load config: %w", err)
+			}
+
+			// Skip update check if:
+			// 1. --skip-update-check flag was provided
+			// 2. Running "version --check" (version command handles its own check)
+			isVersionCheck := cmd.Name() == "version" && cmd.Flags().Changed("check")
+			if !skipUpdateCheck && !isVersionCheck {
+				output := cmd.ErrOrStderr()
+				result := version.PerformCheck(cfg, &output, false)
+				version.PrintUpdateWarning(result, cfg, &output)
+			}
+
 			logging.Sync()
+			return nil
 		},
 	}
 
@@ -74,6 +91,7 @@ tiger auth login
 	cmd.PersistentFlags().StringVar(&serviceID, "service-id", "", "service ID")
 	cmd.PersistentFlags().BoolVar(&analytics, "analytics", true, "enable/disable usage analytics")
 	cmd.PersistentFlags().StringVar(&passwordStorage, "password-storage", config.DefaultPasswordStorage, "password storage method (keyring, pgpass, none)")
+	cmd.PersistentFlags().BoolVar(&skipUpdateCheck, "skip-update-check", false, "skip checking for updates on startup")
 
 	// Bind flags to viper
 	viper.BindPFlag("debug", cmd.PersistentFlags().Lookup("debug"))