Add tiger db connect message to service create/fork output (#33)

Author: nathanjcochran

internal/tiger/cmd/service.go

@@ -427,7 +427,7 @@ Note: You can specify both CPU and memory together, or specify only one (the oth
 
 				// Save password immediately after service creation, before any waiting
 				// This ensures users have access even if they interrupt the wait or it fails
-				handlePasswordSaving(service, initialPassword, statusOutput)
+				passwordSaved := handlePasswordSaving(service, initialPassword, statusOutput)
 
 				// Set as default service unless --no-set-default is specified
 				if !createNoSetDefault {
@@ -447,6 +447,8 @@ Note: You can specify both CPU and memory together, or specify only one (the oth
 					service.Status, result = waitForServiceReady(client, projectID, serviceID, createWaitTimeout, statusOutput)
 					if result != nil {
 						fmt.Fprintf(statusOutput, "❌ %v\n", result)
+					} else {
+						printConnectMessage(statusOutput, passwordSaved, createNoSetDefault, serviceID)
 					}
 				}
 
@@ -455,7 +457,6 @@ Note: You can specify both CPU and memory together, or specify only one (the oth
 				}
 
 				return result
-
 			case 400:
 				return fmt.Errorf("invalid request parameters")
 			case 401:
@@ -875,27 +876,29 @@ func waitForServiceReady(client *api.ClientWithResponses, projectID, serviceID s
 	}
 }
 
-// handlePasswordSaving handles saving password using the configured storage method and displaying appropriate messages
-func handlePasswordSaving(service api.Service, initialPassword string, output io.Writer) {
+// handlePasswordSaving handles saving password using the configured storage
+// method and displaying appropriate messages. Returns true if the password was
+// successfully saved, or false if not.
+func handlePasswordSaving(service api.Service, initialPassword string, output io.Writer) bool {
 	// Note: We don't fail the service creation if password saving fails
 	// The error is handled by displaying the appropriate message below
 	result, _ := password.SavePasswordWithResult(service, initialPassword)
 
 	if result.Method == "none" && result.Message == "No password provided" {
 		// Don't output anything for empty password
-		return
+		return false
 	}
 
 	// Output the message with appropriate emoji
 	if result.Success {
 		fmt.Fprintf(output, "🔐 %s\n", result.Message)
+		return true
+	} else if result.Method == "none" {
+		fmt.Fprintf(output, "💡 %s\n", result.Message)
 	} else {
-		if result.Method == "none" {
-			fmt.Fprintf(output, "💡 %s\n", result.Message)
-		} else {
-			fmt.Fprintf(output, "⚠️  %s\n", result.Message)
-		}
+		fmt.Fprintf(output, "⚠️  %s\n", result.Message)
 	}
+	return false
 }
 
 // setDefaultService sets the given service as the default service in the configuration
@@ -914,6 +917,19 @@ func setDefaultService(serviceID string, output io.Writer) error {
 	return nil
 }
 
+func printConnectMessage(output io.Writer, passwordSaved, noSetDefault bool, serviceID string) {
+	if !passwordSaved {
+		// We can't connect if no password was saved, so don't show message
+		return
+	} else if noSetDefault {
+		// If the service wasn't set as the default, include the serviceID in the command
+		fmt.Fprintf(output, "🔌 Run 'tiger db connect %s' to connect to your new service\n", serviceID)
+	} else {
+		// If the service was set as the default, no need to include the serviceID in the command
+		fmt.Fprintf(output, "🔌 Run 'tiger db connect' to connect to your new service\n")
+	}
+}
+
 // buildServiceDeleteCmd creates the delete subcommand
 func buildServiceDeleteCmd() *cobra.Command {
 	var deleteNoWait bool
@@ -1294,7 +1310,7 @@ Examples:
 				}
 
 				// Save password immediately after service fork
-				handlePasswordSaving(forkedService, initialPassword, statusOutput)
+				passwordSaved := handlePasswordSaving(forkedService, initialPassword, statusOutput)
 
 				// Set as default service unless --no-set-default is used
 				if !forkNoSetDefault {
@@ -1316,6 +1332,7 @@ Examples:
 					return err
 				}
 				fmt.Fprintf(statusOutput, "🎉 Service fork completed successfully!\n")
+				printConnectMessage(statusOutput, passwordSaved, forkNoSetDefault, serviceID)
 				return nil
 
 			case 401:

internal/tiger/util/convert_test.go

@@ -5,8 +5,7 @@ import (
 )
 
 // Define local types for testing to avoid import cycles
-type testDeployStatus string
-type testServiceType string
+type testStringType string
 
 func TestDeref(t *testing.T) {
 	// Test service ID formatting (now uses string instead of UUID)
@@ -29,21 +28,69 @@ func TestDeref(t *testing.T) {
 }
 
 func TestDerefStr(t *testing.T) {
-	// Test DerefStr with DeployStatus
-	status := testDeployStatus("running")
+	status := testStringType("running")
 	if DerefStr(&status) != "running" {
 		t.Error("DerefStr should return status string")
 	}
-	if DerefStr((*testDeployStatus)(nil)) != "" {
+	if DerefStr((*testStringType)(nil)) != "" {
 		t.Error("DerefStr should return empty string for nil")
 	}
+}
 
-	// Test DerefStr with ServiceType
-	serviceType := testServiceType("POSTGRES")
-	if DerefStr(&serviceType) != "POSTGRES" {
-		t.Error("DerefStr should return service type string")
+func TestConvertStringSlice(t *testing.T) {
+	tests := []struct {
+		name    string
+		input   []string
+		wantNil bool
+	}{
+		{
+			name:    "Empty",
+			input:   []string{},
+			wantNil: true,
+		},
+		{
+			name:    "Nil",
+			input:   nil,
+			wantNil: true,
+		},
+		{
+			name:    "Single",
+			input:   []string{"time-series"},
+			wantNil: false,
+		},
+		{
+			name:    "Multiple",
+			input:   []string{"time-series", "ai"},
+			wantNil: false,
+		},
 	}
-	if DerefStr((*testServiceType)(nil)) != "" {
-		t.Error("DerefStr should return empty string for nil")
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			got := ConvertStringSlice[testStringType](tt.input)
+
+			if tt.wantNil {
+				if got != nil {
+					t.Errorf("ConvertStringSlice(%v) = %v, want nil", tt.input, got)
+				}
+				return
+			}
+
+			if got == nil {
+				t.Errorf("ConvertStringSlice(%v) = nil, want non-nil", tt.input)
+				return
+			}
+
+			if len(got) != len(tt.input) {
+				t.Errorf("ConvertStringSlice(%v) length = %d, want %d", tt.input, len(got), len(tt.input))
+			}
+
+			// Verify the conversion is correct
+			for i, s := range tt.input {
+				if string(got[i]) != s {
+					t.Errorf("ConvertStringSlice(%v)[%d] = %s, want %s", tt.input, i, got[i], s)
+				}
+			}
+		})
 	}
 }

internal/tiger/util/service_test.go

@@ -104,46 +104,3 @@ func TestValidateAddons(t *testing.T) {
 		})
 	}
 }
-
-func TestConvertAddonsToAPI(t *testing.T) {
-	tests := []struct {
-		name    string
-		addons  []string
-		wantNil bool
-		wantLen int
-	}{
-		{"Empty slice", []string{}, true, 0},
-		{"Nil slice", nil, true, 0},
-		{"Single addon", []string{"time-series"}, false, 1},
-		{"Multiple addons", []string{"time-series", "ai"}, false, 2},
-	}
-
-	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
-			got := ConvertAddonsToAPI(tt.addons)
-
-			if tt.wantNil {
-				if got != nil {
-					t.Errorf("ConvertAddonsToAPI(%v) = %v, want nil", tt.addons, got)
-				}
-				return
-			}
-
-			if got == nil {
-				t.Errorf("ConvertAddonsToAPI(%v) = nil, want non-nil", tt.addons)
-				return
-			}
-
-			if len(got) != tt.wantLen {
-				t.Errorf("ConvertAddonsToAPI(%v) length = %d, want %d", tt.addons, len(got), tt.wantLen)
-			}
-
-			// Verify the conversion is correct
-			for i, addon := range tt.addons {
-				if string(got[i]) != addon {
-					t.Errorf("ConvertAddonsToAPI(%v)[%d] = %s, want %s", tt.addons, i, got[i], addon)
-				}
-			}
-		})
-	}
-}