Replace <top> label by the required file path

Author: byroot

ext/stackprof/stackprof.c

@@ -77,6 +77,7 @@ static VALUE sym_object, sym_wall, sym_cpu, sym_custom, sym_name, sym_file, sym_
 static VALUE sym_samples, sym_total_samples, sym_missed_samples, sym_edges, sym_lines;
 static VALUE sym_version, sym_mode, sym_interval, sym_raw, sym_metadata, sym_frames, sym_ignore_gc, sym_out;
 static VALUE sym_aggregate, sym_raw_timestamp_deltas, sym_state, sym_marking, sym_sweeping;
+static VALUE str_top_label;
 static VALUE sym_gc_samples, objtracer;
 static VALUE gc_hook;
 static VALUE rb_mStackProf;
@@ -224,6 +225,17 @@ frame_lines_i(st_data_t key, st_data_t val, st_data_t arg)
     return ST_CONTINUE;
 }
 
+static VALUE
+coerce_frame_name(VALUE name, VALUE line) {
+    char *start_pointer = strstr(RSTRING_PTR(name), "<top (required)>\0");
+    if (start_pointer) {
+    	VALUE new_name = rb_str_new(RSTRING_PTR(name), start_pointer - RSTRING_PTR(name));
+    	rb_str_cat_cstr(new_name, RSTRING_PTR(line));
+    	return new_name;
+    }
+    return name;
+}
+
 static int
 frame_i(st_data_t key, st_data_t val, st_data_t arg)
 {
@@ -242,13 +254,15 @@ frame_i(st_data_t key, st_data_t val, st_data_t arg)
 	line = INT2FIX(0);
     } else {
 	name = rb_profile_frame_full_label(frame);
-
 	file = rb_profile_frame_absolute_path(frame);
 	if (NIL_P(file))
 	    file = rb_profile_frame_path(frame);
 	line = rb_profile_frame_first_lineno(frame);
     }
 
+
+    name = coerce_frame_name(name, file);
+
     rb_hash_aset(details, sym_name, name);
     rb_hash_aset(details, sym_file, file);
     if (line != INT2FIX(0)) {
@@ -741,6 +755,8 @@ Init_stackprof(void)
     S(sweeping);
 #undef S
 
+    str_top_label = rb_str_new_cstr("<top (required)>");
+
     /* Need to run this to warm the symbol table before we call this during GC */
     rb_gc_latest_gc_info(sym_state);
 

test/test_stackprof.rb

@@ -194,6 +194,18 @@ def test_gc
     assert_operator profile[:missed_samples], :<=, 25
   end
 
+  def test_top_required
+    tmpfile = Tempfile.new(%w(stackprof-script .rb))
+    tmpfile.write("10.times { sleep 0.1 }\n")
+    tmpfile.flush
+    path = File.realpath(tmpfile.path)
+    ret = StackProf.run(interval: 10) do
+      require path
+    end
+    frame_names = ret[:frames].values.select { |f| f[:file] == path }.map { |f| f[:name] }
+    assert_equal ["block in #{path}", path], frame_names
+  end
+
   def test_out
     tmpfile = Tempfile.new('stackprof-out')
     ret = StackProf.run(mode: :custom, out: tmpfile) do