Skip to content

Rome not failing when engine exit code is not zero #236

@acecilia

Description

@acecilia

Rome version: 0.23.3.64
OS: catalina 10.15.7

Hi 👋

Problem

Rome is not failing when the engine exists with a code different than zero.

Expectation

When the engine returns an exit code different than zero, Rome should also fail and exit with a code different than zero. For example, using the default google engine from this repository:

        print(f"{remote_path} 404'ed")
        zip_file_path.unlink()
        exit(1)

If such code path gets executed, Rome should fail instead of continuing execution

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions