Skip to content

Commit b70e9ac

Browse files
committed
fix(import-teamocil): Reclassify with_env_var and cmd_separator
- with_env_var is an import-only fix (tmuxp already has environment key), not a Limitation β€” moved to new "Import-Only Fixes" section - cmd_separator is irrelevant (tmuxp sends commands individually), clarified it needs no import
1 parent 34ebc6f commit b70e9ac

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

β€Žnotes/import-teamocil.mdβ€Ž

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -163,21 +163,21 @@ Since teamocil 1.4.2 uses the v1.x format, the importer is outdated for current
163163

164164
**What tmuxp would need to add**: `clear` key on windows. Builder would send `clear` (or `send-keys C-l`) after pane creation.
165165

166-
### 5. `with_env_var` (v0.x)
166+
## Import-Only Fixes (No Builder Changes)
167+
168+
### 5. `with_env_var` β†’ `environment` (v0.x)
167169

168170
**What it does in teamocil v0.x**: Sets environment variables for panes.
169171

170-
**Why it can't be imported**: Noted in importer docstring TODO. Not implemented.
172+
**Why it's not imported**: Noted in importer docstring TODO. Not implemented.
171173

172-
**What tmuxp would need to add**: tmuxp already has `environment` on sessions, windows, and panes. The import just needs to map `with_env_var` β†’ `environment`.
174+
**Fix**: tmuxp already has `environment` on sessions, windows, and panes. The importer just needs to map `with_env_var` β†’ `environment`. No builder changes required.
173175

174176
### 6. `cmd_separator` (v0.x)
175177

176178
**What it does in teamocil v0.x**: Custom separator for joining multiple commands (default: `; `).
177179

178-
**Why it can't be imported**: Noted in importer docstring TODO. Not implemented.
179-
180-
**What tmuxp would need to add**: tmuxp sends commands individually (one `send_keys` per command), so this is a non-issue. The behavioral difference is actually better in tmuxp.
180+
**Note**: tmuxp sends commands individually (one `send_keys` per command), so this is irrelevant. The behavioral difference is actually better in tmuxp β€” no import needed.
181181

182182
## Code Issues in Current Importer
183183

0 commit comments

Comments
Β (0)