Skip to content

Fix minibuffer highlighting with Evil mode and Vertico support #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Fix minibuffer highlighting with Evil mode and Vertico support #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4d89247
Initial plan
Copilot Jan 21, 2026
ed1e005
Fix unexpected minibuffer highlighting by deactivating mark
Copilot Jan 21, 2026
9afc3ea
Remove byte-compiled file and add *.elc to .gitignore
Copilot Jan 21, 2026
f6d480a
Make deactivate-mark conditional based on code review feedback
Copilot Jan 21, 2026
2bcba24
Fix minibuffer highlighting by deactivating mark in minibuffer itself
Copilot Jan 21, 2026
b3aa430
Remove redundant minibufferp check based on code review
Copilot Jan 21, 2026
52249b5
Disable transient-mark-mode in minibuffer to prevent highlighting
Copilot Jan 21, 2026
dfc481c
Add Evil mode visual state handling in minibuffer
Copilot Jan 27, 2026
7b2cd27
Fix Evil function declarations to use correct module
Copilot Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@ GTAGS
GRTAGS
GPATH
.ai.code.notes.org
*.elc
24 changes: 19 additions & 5 deletions ai-code-input.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
(require 'imenu)

(declare-function helm-comp-read "helm-mode" (prompt collection &rest args))
(declare-function evil-visual-state-p "evil-core" ())
(declare-function evil-emacs-state "evil-core" ())

;;;###autoload
(defun ai-code-plain-read-string (prompt &optional initial-input candidate-list)
Expand All @@ -26,11 +28,23 @@ This function combines candidate-list with history for better completion."
(delete-dups (append candidate-list
(when (boundp 'ai-code-read-string-history)
ai-code-read-string-history)))))
;; Use completing-read with the combined candidates
(completing-read prompt
completion-candidates
nil nil initial-input
'ai-code-read-string-history)))
;; Use minibuffer-setup-hook to disable highlighting in minibuffer
;; to prevent initial-input from being highlighted
(minibuffer-with-setup-hook
(lambda ()
;; Disable transient-mark-mode locally to prevent highlighting
(setq-local transient-mark-mode nil)
;; If Evil mode is active and in visual state, switch to emacs state
(when (and (fboundp 'evil-visual-state-p)
(evil-visual-state-p))
(evil-emacs-state))
;; Move cursor to end of initial input
(goto-char (point-max)))
;; Use completing-read with the combined candidates
(completing-read prompt
completion-candidates
nil nil initial-input
'ai-code-read-string-history))))

;;;###autoload
(defalias 'ai-code-read-string #'ai-code-plain-read-string)
Expand Down