Fix arduinoboy sync issues

Author: tommitytom

config/config.h

@@ -4,11 +4,11 @@
 
 #define SEMVER_MAJOR 0
 #define SEMVER_MINOR 3
-#define SEMVER_PATCH 1
+#define SEMVER_PATCH 2
 
 #define PLUG_NAME "RetroPlug"
 #define PLUG_MFR "tommitytom"
-#define PLUG_VERSION_HEX 0x00000301
+#define PLUG_VERSION_HEX 0x00000302
 #define PLUG_VERSION_STR VERSION_STRING(SEMVER_MAJOR, SEMVER_MINOR, SEMVER_PATCH)
 #define PLUG_UNIQUE_ID '2wvF'
 #define PLUG_MFR_ID 'tmtt'

src/plugin/audio/RetroPlugInstrument.cpp

@@ -85,6 +85,7 @@ int RetroPlugInstrument::UnserializeState(const IByteChunk& chunk, int pos) {
 
 void RetroPlugInstrument::ProcessMidiMsg(const IMidiMsg& msg) {
 	TRACE;
+
 	_controller.getMenuLock()->lock(); // Temporary
 	if (_controller.audioLua()) {
 		_controller.audioLua()->onMidi(msg.mOffset, msg.mStatus, msg.mData1, msg.mData2);

src/retroplug/platform/Platform.h

@@ -2,5 +2,5 @@
 
 //#define FORCE_LUA_COMPILE
 #if !defined(_DEBUG) || defined(FORCE_LUA_COMPILE)// || defined(VST2_API)
-#define COMPILE_LUA_SCRIPTS
+//#define COMPILE_LUA_SCRIPTS
 #endif

src/retroplug/scripts/audio/Controller.lua

@@ -100,6 +100,9 @@ function Controller:update(frameCount)
 	if self._timeInfo.transportIsRunning ~= self._transportRunning then
 		trans.changed = true
 
+		self._transportRunning = self._timeInfo.transportIsRunning
+		self:emit("onTransportChanged", self._transportRunning)
+
 		if self._timeInfo.transportIsRunning == true then
 			trans.state = TransportState.Playing
 			trans.started = true
@@ -108,9 +111,6 @@ function Controller:update(frameCount)
 			trans.stopped = true
 			self._ppqGen:reset()
 		end
-
-		self._transportRunning = self._timeInfo.transportIsRunning
-		self:emit("onTransportChanged", self._transportRunning)
 	end
 
 	if self._transportRunning == true then
@@ -132,22 +132,25 @@ end
 function Controller:onMidi(offset, statusByte, data1, data2)
 	local channel = statusByte & 0x0F
 	local status = statusByte >> 4
-
 	local r = self._model:getSettings().midiRouting
+
 	if status == midi.Status.System or r == MidiChannelRouting.SendToAll then
 		local msg = midi.Message(offset, statusByte, data1, data2)
+
 		for _, v in ipairs(Project.systems) do
 			self:emit("onMidi", v, msg)
 		end
 	elseif r == MidiChannelRouting.OneChannelPerInstance then
 		local target = Project.systems[channel]
+
 		if target ~= nil then
 			local msg = midi.Message(offset, statusByte, data1, data2)
 			self:emit("onMidi", target, msg)
 		end
 	elseif r == MidiChannelRouting.FourChannelsPerInstance then
 		local targetIdx = math.floor(channel / 4)
 		local target = Project.systems[targetIdx + 1]
+
 		if target ~= nil then
 			local msg = midi.Message(offset, (channel | (status << 4)), data1, data2)
 			self:emit("onMidi", target, msg)

src/retroplug/scripts/audio/components/LsdjArduinoboy.lua

@@ -52,14 +52,27 @@ function LsdjArduinoboy.onMenu(menu)
 end
 
 function LsdjArduinoboy.onTransportChanged(running)
-	local state = System.state.arduinoboy
-	if state.autoPlay == true then
-		System:buttons():press(Button.Start)
+	for _, system in ipairs(Project.systems) do
+		local state = system.state.arduinoboy
+
+		if state ~= nil then
+			if state.syncMode == LsdjSyncModes.MidiMap then
+				state.playing = running
+			end
+
+			if state.autoPlay == true then
+				system:buttons():press(Button.Start)
+			end
+
+			if running == false and state.lastRow ~= -1 then
+				system:sendSerialByte(0, 0xFE)
+			end
+		end
 	end
 end
 
 function LsdjArduinoboy.onUpdate(frameCount)
-
+	--print("---")
 end
 
 local function processSync(system, offset)
@@ -71,7 +84,7 @@ local function processSync(system, offset)
 		if state.playing == true then
 			system:sendSerialByte(offset, 0xF8)
 		end
-	elseif state.syncMode == LsdjSyncModes.MidiSync then
+	elseif state.syncMode == LsdjSyncModes.MidiMap then
 		system:sendSerialByte(offset, 0xFF)
 	end
 end
@@ -105,25 +118,29 @@ function LsdjArduinoboy.onMidi(system, msg)
 			elseif msg.note == 28 then state.tempoDivisor = 4
 			elseif msg.note == 29 then state.tempoDivisor = 8
 			elseif msg.note >= 30 then
-				System:sendSerialByte(msg.offset, msg.note - 30)
+				system:sendSerialByte(msg.offset, msg.note - 30)
 			end
 		end
 	elseif state.syncMode == LsdjSyncModes.MidiMap then
 		-- Notes trigger row numbers
+
 		if status == midi.Status.NoteOn then
 			local rowIdx = midiMapRowNumber(msg.channel, msg.note)
+
 			if rowIdx ~= -1 then
-				System:sendSerialByte(msg.offset, rowIdx)
+				system:sendSerialByte(msg.offset, rowIdx)
 				state.lastRow = rowIdx
 			end
-		elseif status == midi.Status.Noteff then
+		elseif status == midi.Status.NoteOff then
 			local rowIdx = midiMapRowNumber(msg.channel, msg.note)
+
 			if rowIdx == state.lastRow then
-				System:sendSerialByte(msg.offset, 0xFE)
+				system:sendSerialByte(msg.offset, 0xFE)
 				state.lastRow = -1
 			end
+		-- Pseudocode... not sure what to handle here! FL studio does nothing useful when stop is clicked
 		elseif msg.type == "stop" then
-			System:sendSerialByte(msg.offset, 0xFE)
+			system:sendSerialByte(msg.offset, 0xFE)
 		end
 	end
 end

src/retroplug/scripts/audio/components/MidiPassthrough.lua

@@ -6,10 +6,14 @@ end
 function MidiPassthrough.onTransportChanged()
 end
 
+function MidiPassthrough.requires()
+	return System ~= nil and System.desc.romName:match("MGB") ~= nil
+end
+
 function MidiPassthrough.onMidi(system, message)
-    system:sendSerialByte(message.offset, message.statusByte, 8)
-    system:sendSerialByte(message.offset, message.data1, 8)
-    system:sendSerialByte(message.offset, message.data2, 8)
+	system:sendSerialByte(message.offset, message.statusByte, 8)
+	system:sendSerialByte(message.offset, message.data1, 8)
+	system:sendSerialByte(message.offset, message.data2, 8)
 end
 
 return MidiPassthrough