[dev] [tofikwest] tofik/vendor-pagination-fix (#2040)

* refactor(ui): enhance pagination logic in VendorsTable for search functionality

* refactor(ui): improve pagination logic in VendorsTable for clarity

* refactor(ui): simplify comparison logic and improve pagination comments in VendorsTable

---------

Co-authored-by: Tofik Hasanov <annexcies@gmail.com>

Author: github-actions[bot]

apps/app/src/app/(app)/[orgId]/vendors/(overview)/components/VendorsTable.tsx

@@ -327,17 +327,24 @@ export function VendorsTable({
         const comparison = (aValue as string).localeCompare(bValue as string);
         return sort.desc ? -comparison : comparison;
       }
-      const comparison =
-        new Date(aValue as Date).getTime() - new Date(bValue as Date).getTime();
+      const comparison = new Date(aValue as Date).getTime() - new Date(bValue as Date).getTime();
       return sort.desc ? -comparison : comparison;
     });
 
     return result;
   }, [mergedVendors, searchQuery, sort]);
 
   // Calculate pageCount from filtered data and paginate
-  const filteredPageCount = Math.max(1, Math.ceil(filteredAndSortedVendors.length / perPage));
-  const startIndex = (page - 1) * perPage;
+  // When searching locally, calculate pageCount from filtered data
+  // When not searching, use server's pageCount (server handles pagination)
+  const filteredPageCount = searchQuery
+    ? Math.max(1, Math.ceil(filteredAndSortedVendors.length / perPage))
+    : Math.max(1, vendorsData?.pageCount ?? initialPageCount);
+
+  // When searching locally, slice the data for client-side pagination
+  // When not searching, server returns the correct page, but slice to enforce perPage
+  // (avoids extra rows from onboarding pending/temp vendors)
+  const startIndex = searchQuery ? (page - 1) * perPage : 0;
   const paginatedVendors = filteredAndSortedVendors.slice(startIndex, startIndex + perPage);
 
   // Keep page in bounds when pageCount changes
@@ -358,9 +365,7 @@ export function VendorsTable({
       return metadataStatus === 'completed' || vendor.status === 'assessed';
     }).length;
 
-    const completedInMetadata = Object.values(itemStatuses).filter(
-      (s) => s === 'completed',
-    ).length;
+    const completedInMetadata = Object.values(itemStatuses).filter((s) => s === 'completed').length;
 
     const total = Math.max(progress.total, itemsInfo.length, vendors.length);
     const completed = Math.max(completedCount, completedInMetadata);
@@ -420,9 +425,7 @@ export function VendorsTable({
         setVendorToDelete(null);
       } else {
         const errorMsg =
-          typeof result?.data?.error === 'string'
-            ? result.data.error
-            : 'Failed to delete vendor';
+          typeof result?.data?.error === 'string' ? result.data.error : 'Failed to delete vendor';
         toast.error(errorMsg);
       }
     } catch {