Skip to content
This repository was archived by the owner on Jun 28, 2022. It is now read-only.
This repository was archived by the owner on Jun 28, 2022. It is now read-only.

Difference in dataparsing after creating review #8

@Cnordbo

Description

@Cnordbo

Expected:

{
    "id": 31,
    "restaurant_id": 1,
    "name": "Some Name",
    "createdAt": 1504095567183,
    "updatedAt": 1504095567183,
    "rating": 4,
    "comments": "<removed for readability>"
  }

Actual:

  {
    "id": 2,
    "restaurant_id": "1",
    "name": "Morgan",
     "rating": "5",
    "comments": "asdasd",
    "createdAt": "2018-04-13T19:24:52.518Z",
    "updatedAt": "2018-04-13T19:24:52.518Z",
    "id": 42
  }

Difference:
Rating is parsed as string.
Date format differs within the same dataset.
Restaurant_id parsed as string.

Impact: Breaking

This causes the client application to require special transforms just to ensure that the data is parsed correctly.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions