Skip to content

Commit 1745592

Browse files
committed
Add support for R#/Rider 2020.2
1 parent c21c6be commit 1745592

20 files changed

+84
-89
lines changed

.teamcity/OpenSourceProjects_ImplicitNullability/buildTypes/OpenSourceProjects_ImplicitNullability_BuildVersion.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
<option name="buildNumberPattern" value="%Version%.%build.counter%" />
88
</options>
99
<parameters>
10-
<param name="Version" value="4.10.0" />
10+
<param name="Version" value="4.11.0" />
1111
</parameters>
1212
<build-runners />
1313
<vcs-settings />

Build/Build.ps1

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,15 +19,15 @@ $MSBuildPath = (Get-ChildItem "${env:ProgramFiles(x86)}\Microsoft Visual Studio\
1919
$MSBuildAdditionalArgs = "/nowarn:MSB3277"
2020
$NUnitAdditionalArgs = "--x86 --labels=All --agents=1"
2121
$NUnitTestAssemblyPaths = @(
22-
"Src\ImplicitNullability.Plugin.Tests\bin\RD20201\$Configuration\ImplicitNullability.Plugin.Tests.RD20201.dll"
23-
"Src\ImplicitNullability.Plugin.Tests\bin\RS20201\$Configuration\ImplicitNullability.Plugin.Tests.RS20201.dll"
22+
"Src\ImplicitNullability.Plugin.Tests\bin\RD20202\$Configuration\ImplicitNullability.Plugin.Tests.RD20202.dll"
23+
"Src\ImplicitNullability.Plugin.Tests\bin\RS20202\$Configuration\ImplicitNullability.Plugin.Tests.RS20202.dll"
2424
"Src\ImplicitNullability.Samples.Consumer\bin\OfInternalCodeWithIN\$Configuration\ImplicitNullability.Samples.Consumer.OfInternalCodeWithIN.dll"
2525
)
2626
$NUnitFrameworkVersion = "net-4.5"
2727
$TestCoverageFilter = "+[ImplicitNullability*]* -[ImplicitNullability*]ReSharperExtensionsShared.* -[ImplicitNullability.Samples.CodeWithIN.*]* -[ImplicitNullability.Samples.CodeWithoutIN.External]*"
2828
$NuspecPath = "Src\ImplicitNullability.Plugin\ImplicitNullability.nuspec"
2929
$NugetPackProperties = @(
30-
"Version=$(CalcNuGetPackageVersion 20201);Configuration=$Configuration;DependencyVer=[201.0];BinDirInclude=bin\RS20201"
30+
"Version=$(CalcNuGetPackageVersion 20202);Configuration=$Configuration;DependencyVer=[201.0];BinDirInclude=bin\RS20202"
3131
)
3232
$RiderPluginProject = "Src\RiderPlugin"
3333
$NugetPushServer = "https://www.myget.org/F/ulrichb/api/v2/package"

History.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
### 4.11.0 ###
2+
- (!) End-of-life note: Please switch to C# 8 Nullable Reference Types
3+
- ReSharper and Rider 2020.2 support
4+
15
### 4.10.0 ###
26
- (!) End-of-life note: Please switch to C# 8 Nullable Reference Types
37
- ReSharper and Rider 2020.1 support

ImplicitNullability.sln

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,17 +26,17 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "ImplicitNullability.Samples
2626
{C98DF2CD-3BB5-4213-9D90-08241ED5B74F} = {C98DF2CD-3BB5-4213-9D90-08241ED5B74F}
2727
EndProjectSection
2828
EndProject
29-
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "ImplicitNullability.Plugin.VsFormatDefinitions.RS20201", "Src\ImplicitNullability.Plugin.VsFormatDefinitions\ImplicitNullability.Plugin.VsFormatDefinitions.RS20201.csproj", "{69D96DC8-E1A0-4412-AD54-BAEC0B43520E}"
29+
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "ImplicitNullability.Plugin.VsFormatDefinitions.RS20202", "Src\ImplicitNullability.Plugin.VsFormatDefinitions\ImplicitNullability.Plugin.VsFormatDefinitions.RS20202.csproj", "{69D96DC8-E1A0-4412-AD54-BAEC0B43520E}"
3030
EndProject
31-
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "ImplicitNullability.Plugin.RS20201", "Src\ImplicitNullability.Plugin\ImplicitNullability.Plugin.RS20201.csproj", "{2F246B16-414A-4FDF-9DE2-3EC8E51D1B9A}"
31+
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "ImplicitNullability.Plugin.RS20202", "Src\ImplicitNullability.Plugin\ImplicitNullability.Plugin.RS20202.csproj", "{2F246B16-414A-4FDF-9DE2-3EC8E51D1B9A}"
3232
EndProject
33-
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "ImplicitNullability.Plugin.Tests.RS20201", "Src\ImplicitNullability.Plugin.Tests\ImplicitNullability.Plugin.Tests.RS20201.csproj", "{1C93B659-62A2-4539-815D-D20BABB47451}"
33+
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "ImplicitNullability.Plugin.Tests.RS20202", "Src\ImplicitNullability.Plugin.Tests\ImplicitNullability.Plugin.Tests.RS20202.csproj", "{1C93B659-62A2-4539-815D-D20BABB47451}"
3434
EndProject
3535
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "ImplicitNullability.Samples.CodeWithIN.Special", "Src\ImplicitNullability.Samples.CodeWithIN.Special\ImplicitNullability.Samples.CodeWithIN.Special.csproj", "{4979B806-EB66-4C3F-8BB0-7AF284AEB0BD}"
3636
EndProject
37-
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "ImplicitNullability.Plugin.RD20201", "Src\ImplicitNullability.Plugin\ImplicitNullability.Plugin.RD20201.csproj", "{4ECAB56A-44C9-4A46-B401-FBD782634AA0}"
37+
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "ImplicitNullability.Plugin.RD20202", "Src\ImplicitNullability.Plugin\ImplicitNullability.Plugin.RD20202.csproj", "{4ECAB56A-44C9-4A46-B401-FBD782634AA0}"
3838
EndProject
39-
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "ImplicitNullability.Plugin.Tests.RD20201", "Src\ImplicitNullability.Plugin.Tests\ImplicitNullability.Plugin.Tests.RD20201.csproj", "{2E9FE56E-2507-42FC-8146-2F4F9BA4397D}"
39+
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "ImplicitNullability.Plugin.Tests.RD20202", "Src\ImplicitNullability.Plugin.Tests\ImplicitNullability.Plugin.Tests.RD20202.csproj", "{2E9FE56E-2507-42FC-8146-2F4F9BA4397D}"
4040
EndProject
4141
Global
4242
GlobalSection(SolutionConfigurationPlatforms) = preSolution

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
:warning: **End-of-life note:** C# 8+ (VS 2019+) supports [_nullable reference types_](https://docs.microsoft.com/en-us/dotnet/csharp/tutorials/nullable-reference-types) which [supersedes](#c-nullable-reference-types) - and perfectly aligns with - _Implicit Nullability_. Therefore ReSharper/Rider 2020.1 is the last version supported by _Implicit Nullability_.
1+
:warning: **End-of-life note:** C# 8+ (VS 2019+) supports [_nullable reference types_](https://docs.microsoft.com/en-us/dotnet/csharp/tutorials/nullable-reference-types) which [supersedes](#c-nullable-reference-types) - and perfectly aligns with - _Implicit Nullability_. Therefore ReSharper/Rider 2020.2 is the last version supported by _Implicit Nullability_.
22

33
## Implicit Nullability ReSharper Extension
44

Src/ImplicitNullability.Plugin.Tests/ImplicitNullability.Plugin.Tests.RD20201.csproj renamed to Src/ImplicitNullability.Plugin.Tests/ImplicitNullability.Plugin.Tests.RD20202.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
</ItemGroup>
2020

2121
<ItemGroup>
22-
<PackageReference Include="JetBrains.Rider.SDK.Tests" Version="2020.1.*" />
22+
<PackageReference Include="JetBrains.Rider.SDK.Tests" Version="2020.2.*" />
2323
<PackageReference Include="FakeItEasy" Version="4.*" />
2424
<PackageReference Include="ncalc" Version="1.3.*" />
2525
</ItemGroup>

Src/ImplicitNullability.Plugin.Tests/ImplicitNullability.Plugin.Tests.RS20201.csproj renamed to Src/ImplicitNullability.Plugin.Tests/ImplicitNullability.Plugin.Tests.RS20202.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
</ItemGroup>
2020

2121
<ItemGroup>
22-
<PackageReference Include="JetBrains.ReSharper.SDK.Tests" Version="2020.1.*" />
22+
<PackageReference Include="JetBrains.ReSharper.SDK.Tests" Version="2020.2.*" />
2323
<PackageReference Include="FakeItEasy" Version="4.*" />
2424
<PackageReference Include="ncalc" Version="1.3.*" />
2525
</ItemGroup>

Src/ImplicitNullability.Plugin.Tests/UnitTests/AnnotationRedundancyInHierarchyWarningFilteringDecoratorTest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ public void ConsumeHighlighting_WithSomeHighlighting_ShouldPassCall()
2828

2929
_sut.ConsumeHighlighting(highlightingInfo);
3030

31-
A_.CallTo(() => _decorated.ConsumeHighlighting(highlightingInfo)).MustHaveHappened();
31+
A_.CallTo(() => _decorated.ConsumeHighlighting(highlightingInfo, null, null)).MustHaveHappened();
3232
}
3333

3434
[Test]

Src/ImplicitNullability.Plugin.VsFormatDefinitions/ImplicitNullability.Plugin.VsFormatDefinitions.RS20201.csproj renamed to Src/ImplicitNullability.Plugin.VsFormatDefinitions/ImplicitNullability.Plugin.VsFormatDefinitions.RS20202.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
</ItemGroup>
1313

1414
<ItemGroup>
15-
<PackageReference Include="JetBrains.ReSharper.SDK" Version="2020.1.*" />
15+
<PackageReference Include="JetBrains.ReSharper.SDK" Version="2020.2.*" />
1616
<PackageReference Include="VSSDK.Text.10" Version="10.*" />
1717
</ItemGroup>
1818

Src/ImplicitNullability.Plugin/AnnotationRedundancyInHierarchyWarningFilteringDecorator.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
using System.Collections.Generic;
2+
using JetBrains.DocumentModel;
23
using JetBrains.ReSharper.Daemon.CSharp.Errors;
34
using JetBrains.ReSharper.Feature.Services.Daemon;
45

@@ -13,7 +14,7 @@ public AnnotationRedundancyInHierarchyWarningFilteringDecorator(IHighlightingCon
1314
_decorated = decorated;
1415
}
1516

16-
public void ConsumeHighlighting(HighlightingInfo highlightingInfo)
17+
public void ConsumeHighlighting(HighlightingInfo highlightingInfo, DocumentRange[] secondaryDocumentRanges = null, string secondaryAttributeId = null)
1718
{
1819
if (!(highlightingInfo.Highlighting is AnnotationRedundancyInHierarchyWarning))
1920
{

0 commit comments

Comments
 (0)