-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Description
Currently, Insights-Remote makes no real distinction between configMap types and will simply send along absolutely anything to the insights-core.
While this is useful from one perspective, it also makes building expectations into the insights-handler difficult, having to handle practically any payload.
It would be good to build the following into the insights-remote
- ConfigMaps with multiple entries in their payloads are disallowed. That is, a single file per configMap only.
- Since it's already the defacto case, we should restrict configMaps to only those which support binaryPayloads
- We should explicitly specify labels for data types that are sent through - that is,
inspectinfo,sboms, etc. This will obviate needless data type identification on the insights-handler side.
Suggestions here are
- to explicitly type the CM at creation time - for now this will live in the build-deploy-tool . This should conform to Proposal: standardise on styling for kubernetes labels used by Lagoon lagoon#3597
- To explicitly reject untyped configMaps - this is wrapped as a feature flag to support deprecation over multiple versions
- Reject any payloads with len > 1
- Move to a single payload item, and not passing a map of byte strings.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels