environment variables pages have different behaviour for editing variables

[shreddedbacon]

If we go to the project variables only page, it looks like the newer method, with a toggle to edit/view the values

Same with organization variables, this looks correct.

The variables page of an environment, the environment variables looks like the newer method.

The project variables on this same page has the older behaviour. This needs to be corrected to match the others.

[CGoodwin90]

Are you referring to the Switch displaying "view" instead of "edit"? If so, that's intended - project variables can only be viewed on the Environment variables page, with a link to the project variables below the table if they need to be edited.

[shreddedbacon]

I think it is still possible to do the same thing, see uselagoon/lagoon-ui#334

Being able to edit the project variables on the environments variable page seems possible. With the permissions in place, a user without permission to edit/view will still get permissions errors, but the user experience is a little bit nicer.

[CGoodwin90]

Oh it's definitely possible, that was never in question. This was a design choice made when we first implemented variables to avoid users accidently updating project wide variables when on the environment variables page. If this is no longer a concern we can update it.

[shreddedbacon]

This was a design choice made when we first implemented variables to avoid users accidently updating project wide variables when on the environment variables page. If this is no longer a concern we can update it.

Yeah, that was the reason for the split before, but I think as long as its clear that the user would be editing project variables, it offers a much better UX than having to go between pages as described in uselagoon/lagoon#3948. Maybe check with Matt how that could be shown without being obnoxious?