chore: address review comments

Author: shreddedbacon

services/actions-handler/handler/controller_idling.go

@@ -71,9 +71,21 @@ func (m *Messenger) handleIdling(ctx context.Context, messageQueue *mq.MessageQu
 		// pull the id from the message
 		environmentID = *message.Meta.EnvironmentID
 	}
-	decodeData, _ := base64.StdEncoding.DecodeString(message.Meta.AdvancedData)
+	decodeData, err := base64.StdEncoding.DecodeString(message.Meta.AdvancedData)
+	if err != nil {
+		if m.EnableDebug {
+			log.Printf("%sERROR: unable to decode data payload - %v", prefix, err)
+		}
+		return err
+	}
 	idled := &schema.Idled{}
-	json.Unmarshal(decodeData, idled)
+	err = json.Unmarshal(decodeData, idled)
+	if err != nil {
+		if m.EnableDebug {
+			log.Printf("%sERROR: unable to unmarshal data payload - %v", prefix, err)
+		}
+		return err
+	}
 	updateEnvironmentPatch := schema.UpdateEnvironmentPatchInput{
 		IdleState: &idled.IdleState,
 	}

services/api/src/resources/environment/resolvers.ts

@@ -1388,7 +1388,7 @@ export const stopOrStartEnvironmentService = async (
       '',
       'api:stopOrStartEnvironmentService',
       { environment: environmentData.id },
-      `Environment idle attempt possibly failed, reason: ${error}`
+      `Service state change attempt possibly failed, reason: ${error}`
     );
     throw new Error(
       error.message

services/keycloak/lagoon-realm-base-import.json

@@ -1434,7 +1434,7 @@
                 "name": "remove:history:project"
               }
             ]
-          }
+          },
           {
             "name": "environment_state",
             "ownerManagedAccess": false,
@@ -2916,7 +2916,7 @@
               "scopes": "[\"delete\",\"remove:harbor:global\",\"remove:harbor:organization\",\"remove:harbor:project\",\"remove:history:global\",\"remove:history:organization\",\"remove:history:project\"]",
               "applyPolicies": "[\"[Lagoon] Users role for realm is Platform Owner\"]"
             }
-          }
+          },
           {
             "name": "Restart production environment services",
             "type": "scope",
@@ -2939,17 +2939,6 @@
               "applyPolicies": "[\"[Lagoon] User has access to project\",\"[Lagoon] Users role for project is Developer\"]"
             }
           },
-          {
-            "name": "Restart production environment services",
-            "type": "scope",
-            "logic": "POSITIVE",
-            "decisionStrategy": "UNANIMOUS",
-            "config": {
-              "resources": "[\"environment_state\"]",
-              "scopes": "[\"restart:production\"]",
-              "applyPolicies": "[\"[Lagoon] User has access to project\",\"[Lagoon] Users role for project is Maintainer\"]"
-            }
-          },
           {
             "name": "Idle or Unidle development environment",
             "type": "scope",