Skip to content

Commit 51e7c0f

Browse files
Merge remote-tracking branch 'origin/main' into dat-966
2 parents d3519cb + ad7d6ba commit 51e7c0f

File tree

4 files changed

+42
-27
lines changed

4 files changed

+42
-27
lines changed

composer.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,7 @@
2525
},
2626
"require": {
2727
"php": ">=8.4",
28-
"utopia-php/telemetry": "0.1.*",
29-
"ext-swoole": "*"
28+
"utopia-php/telemetry": "*"
3029
},
3130
"require-dev": {
3231
"phpunit/phpunit": "11.*",

composer.lock

Lines changed: 22 additions & 18 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Pools/Pool.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ class Pool
5858
private Gauge $telemetryPoolCapacity;
5959
private Histogram $telemetryWaitDuration;
6060
private Histogram $telemetryUseDuration;
61-
/** @var array<string, int|string> */
61+
/** @var array<non-empty-string, int|string> */
6262
private array $telemetryAttributes;
6363

6464
/**

tests/Pools/Scopes/PoolTestScope.php

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -341,17 +341,29 @@ public function testPoolTelemetry(): void
341341
$this->assertEquals(5, $this->poolObject->count());
342342

343343
$allocate(3, function () use ($telemetry): void {
344-
$this->assertEquals([1, 2, 3], $telemetry->gauges['pool.connection.open.count']->values);
345-
$this->assertEquals([1, 2, 3], $telemetry->gauges['pool.connection.active.count']->values);
346-
$this->assertEquals([0, 0, 0], $telemetry->gauges['pool.connection.idle.count']->values);
344+
/** @var object{values: array<int, float|int>} $openGauge */
345+
$openGauge = $telemetry->gauges['pool.connection.open.count'];
346+
/** @var object{values: array<int, float|int>} $activeGauge */
347+
$activeGauge = $telemetry->gauges['pool.connection.active.count'];
348+
/** @var object{values: array<int, float|int>} $idleGauge */
349+
$idleGauge = $telemetry->gauges['pool.connection.idle.count'];
350+
$this->assertEquals([1, 2, 3], $openGauge->values);
351+
$this->assertEquals([1, 2, 3], $activeGauge->values);
352+
$this->assertEquals([0, 0, 0], $idleGauge->values);
347353
});
348354

349355
$this->assertEquals(5, $this->poolObject->count());
350356

351357
$allocate(1, function () use ($telemetry): void {
352-
$this->assertEquals([1, 2, 3, 3, 3, 3, 3], $telemetry->gauges['pool.connection.open.count']->values);
353-
$this->assertEquals([1, 2, 3, 2, 1, 0, 1], $telemetry->gauges['pool.connection.active.count']->values);
354-
$this->assertEquals([0, 0, 0, 1, 2, 3, 2], $telemetry->gauges['pool.connection.idle.count']->values);
358+
/** @var object{values: array<int, float|int>} $openGauge */
359+
$openGauge = $telemetry->gauges['pool.connection.open.count'];
360+
/** @var object{values: array<int, float|int>} $activeGauge */
361+
$activeGauge = $telemetry->gauges['pool.connection.active.count'];
362+
/** @var object{values: array<int, float|int>} $idleGauge */
363+
$idleGauge = $telemetry->gauges['pool.connection.idle.count'];
364+
$this->assertEquals([1, 2, 3, 3, 3, 3, 3], $openGauge->values);
365+
$this->assertEquals([1, 2, 3, 2, 1, 0, 1], $activeGauge->values);
366+
$this->assertEquals([0, 0, 0, 1, 2, 3, 2], $idleGauge->values);
355367
});
356368
});
357369
}

0 commit comments

Comments
 (0)