reasons

Author: nyurik

src/uu/du/src/du.rs

@@ -233,7 +233,10 @@ fn get_blocks(path: &Path, _metadata: &Metadata) -> u64 {
 }
 
 #[cfg(not(windows))]
-#[expect(clippy::unnecessary_wraps)] // To match all platforms
+#[expect(
+    clippy::unnecessary_wraps,
+    reason = "fn sig must match on all platforms"
+)]
 fn get_file_info(_path: &Path, metadata: &Metadata) -> Option<FileInfo> {
     Some(FileInfo {
         file_id: metadata.ino() as u128,

src/uu/false/src/false.rs

@@ -9,7 +9,8 @@ use uucore::error::{UResult, set_exit_code};
 use uucore::translate;
 
 #[uucore::main]
-#[expect(clippy::unnecessary_wraps)] // TODO: modify proc macro to allow no-result uumain
+// TODO: modify proc macro to allow no-result uumain
+#[expect(clippy::unnecessary_wraps, reason = "proc macro requires UResult")]
 pub fn uumain(args: impl uucore::Args) -> UResult<()> {
     // Mirror GNU options, always return `1`. In particular even the 'successful' cases of no-op,
     // and the interrupted display of help and version should return `1`. Also, we return Ok in all

src/uu/head/src/parse.rs

@@ -138,7 +138,7 @@ mod tests {
         }
     }
 
-    #[expect(clippy::unnecessary_wraps)] // test helper
+    #[expect(clippy::unnecessary_wraps, reason = "test helper")]
     fn obsolete_result(src: &[&str]) -> Option<Result<Vec<String>, ParseError>> {
         Some(Ok(src.iter().map(|&s| s.to_string()).collect()))
     }

src/uu/ls/src/ls.rs

@@ -262,7 +262,7 @@ fn parse_time_style(options: &clap::ArgMatches) -> Result<(String, Option<String
     const LOCALE_FORMAT: (&str, Option<&str>) = ("%b %e %H:%M", Some("%b %e  %Y"));
 
     // Convert time_styles references to owned String/option.
-    #[expect(clippy::unnecessary_wraps)] // Result helper
+    #[expect(clippy::unnecessary_wraps, reason = "internal result helper")]
     fn ok((recent, older): (&str, Option<&str>)) -> Result<(String, Option<String>), LsError> {
         Ok((recent.to_string(), older.map(String::from)))
     }

src/uu/mkdir/src/mkdir.rs

@@ -51,7 +51,10 @@ pub struct Config<'a> {
 }
 
 #[cfg(windows)]
-#[expect(clippy::unnecessary_wraps)] // To match all platforms
+#[expect(
+    clippy::unnecessary_wraps,
+    reason = "fn sig must match on all platforms"
+)]
 fn get_mode(_matches: &ArgMatches) -> Result<u32, String> {
     Ok(DEFAULT_PERM)
 }

src/uu/mv/src/mv.rs

@@ -886,7 +886,10 @@ fn rename_fifo_fallback(from: &Path, to: &Path) -> io::Result<()> {
 }
 
 #[cfg(not(unix))]
-#[expect(clippy::unnecessary_wraps)] // To match all platforms
+#[expect(
+    clippy::unnecessary_wraps,
+    reason = "fn sig must match on all platforms"
+)]
 fn rename_fifo_fallback(_from: &Path, _to: &Path) -> io::Result<()> {
     Ok(())
 }

src/uu/stdbuf/src/stdbuf.rs

@@ -90,13 +90,19 @@ enum ProgramOptionsError {
     target_os = "openbsd",
     target_os = "dragonfly"
 ))]
-#[expect(clippy::unnecessary_wraps)] // To match all platforms
+#[expect(
+    clippy::unnecessary_wraps,
+    reason = "fn sig must match on all platforms"
+)]
 fn preload_strings() -> UResult<(&'static str, &'static str)> {
     Ok(("LD_PRELOAD", "so"))
 }
 
 #[cfg(target_vendor = "apple")]
-#[expect(clippy::unnecessary_wraps)] // To match all platforms
+#[expect(
+    clippy::unnecessary_wraps,
+    reason = "fn sig must match on all platforms"
+)]
 fn preload_strings() -> UResult<(&'static str, &'static str)> {
     Ok(("DYLD_LIBRARY_PATH", "dylib"))
 }

src/uu/stty/src/stty.rs

@@ -613,7 +613,10 @@ impl WrappedPrinter {
     }
 }
 
-#[allow(clippy::unnecessary_wraps)] // needed for some platforms
+#[allow(
+    clippy::unnecessary_wraps,
+    reason = "needed for some platform-specific code"
+)]
 fn print_terminal_size(
     termios: &Termios,
     opts: &Options,

src/uu/sync/src/sync.rs

@@ -41,7 +41,10 @@ mod platform {
 
     use uucore::error::UResult;
 
-    #[expect(clippy::unnecessary_wraps)] // To match all platforms
+    #[expect(
+        clippy::unnecessary_wraps,
+        reason = "fn sig must match on all platforms"
+    )]
     pub fn do_sync() -> UResult<()> {
         sync();
         Ok(())

src/uu/true/src/true.rs

@@ -9,7 +9,8 @@ use uucore::error::{UResult, set_exit_code};
 use uucore::translate;
 
 #[uucore::main]
-#[expect(clippy::unnecessary_wraps)] // TODO: modify proc macro to allow no-result uumain
+// TODO: modify proc macro to allow no-result uumain
+#[expect(clippy::unnecessary_wraps, reason = "proc macro requires UResult")]
 pub fn uumain(args: impl uucore::Args) -> UResult<()> {
     let args: Vec<OsString> = args.collect();
     if args.len() != 2 {