Skip to content

Commit a47858a

Browse files
vdir: make vdir an alias of ls to resolve missing ftl (#10363) (#10434)
Make vdir an alias of ls just as dir is an alias of ls, so vdir can access the ftl files of ls. Also merged vdir's ftl strings into ls's.
1 parent 2a7f318 commit a47858a

File tree

7 files changed

+35
-9
lines changed

7 files changed

+35
-9
lines changed

src/common/validation.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,8 @@ fn get_canonical_util_name(util_name: &str) -> &str {
5959
match util_name {
6060
// uu_test aliases - '[' is an alias for test
6161
"[" => "test",
62-
63-
"dir" => "ls", // dir is an alias for ls
62+
"dir" => "ls", // dir is an alias for ls
63+
"vdir" => "ls", // vdir is an alias for ls
6464

6565
// Default case - return the util name as is
6666
_ => util_name,

src/uu/ls/locales/en-US.ftl

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,13 @@ ls-about = List directory contents.
22
Ignore files and directories starting with a '.' by default
33
dir-about = List directory contents.
44
Ignore files and directories starting with a '.' by default
5+
vdir-about = List directory contents.
6+
Ignore files and directories starting with a '.' by default
7+
8+
Mandatory arguments to long options are mandatory for short options too.
59
ls-usage = ls [OPTION]... [FILE]...
610
dir-usage = dir [OPTION]... [FILE]...
11+
vdir-usage = vdir [OPTION]... [FILE]...
712
ls-after-help = The TIME_STYLE argument can be full-iso, long-iso, iso, locale or +FORMAT. FORMAT is interpreted like in date. Also the TIME_STYLE environment variable sets the default style to use.
813
914
# Error messages

src/uu/ls/locales/fr-FR.ftl

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,13 @@ ls-about = Lister le contenu des répertoires.
22
Ignorer les fichiers et répertoires commençant par un '.' par défaut
33
dir-about = Lister le contenu des répertoires.
44
Ignorer les fichiers et répertoires commençant par un '.' par défaut
5+
vdir-about = Lister le contenu des répertoires.
6+
Ignorer les fichiers et répertoires commençant par un '.' par défaut
7+
8+
Les arguments obligatoires pour les options longues le sont aussi pour les options courtes.
59
ls-usage = ls [OPTION]... [FICHIER]...
610
dir-usage = dir [OPTION]... [FICHIER]...
11+
vdir-usage = vdir [OPTION]... [FICHIER]...
712
ls-after-help = L'argument TIME_STYLE peut être full-iso, long-iso, iso, locale ou +FORMAT. FORMAT est interprété comme dans date. De plus, la variable d'environnement TIME_STYLE définit le style par défaut à utiliser.
813
914
# Messages d'erreur

src/uu/vdir/locales/en-US.ftl

Lines changed: 0 additions & 5 deletions
This file was deleted.

src/uu/vdir/src/vdir.rs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ use std::path::Path;
99
use uu_ls::{Config, Format, options};
1010
use uucore::error::UResult;
1111
use uucore::quoting_style::QuotingStyle;
12+
use uucore::{format_usage, translate};
1213

1314
#[uucore::main]
1415
pub fn uumain(args: impl uucore::Args) -> UResult<()> {
@@ -61,4 +62,6 @@ pub fn uumain(args: impl uucore::Args) -> UResult<()> {
6162
// an uu_app function, so we need this dummy one.
6263
pub fn uu_app() -> Command {
6364
uu_ls::uu_app()
65+
.override_usage(format_usage(&translate!("vdir-usage")))
66+
.about(translate!("vdir-about"))
6467
}

src/uucore/src/lib/lib.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -171,8 +171,8 @@ pub fn get_canonical_util_name(util_name: &str) -> &str {
171171
match util_name {
172172
// uu_test aliases - '[' is an alias for test
173173
"[" => "test",
174-
175-
"dir" => "ls", // dir is an alias for ls
174+
"dir" => "ls", // dir is an alias for ls
175+
"vdir" => "ls", // vdir is an alias for ls
176176

177177
// Default case - return the util name as is
178178
_ => util_name,

tests/by-util/test_vdir.rs

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,3 +56,21 @@ fn test_column_output() {
5656
fn test_invalid_option_exit_code() {
5757
new_ucmd!().arg("-/").fails().code_is(2);
5858
}
59+
60+
#[test]
61+
fn test_help_shows_vdir_not_ls() {
62+
let result = new_ucmd!().arg("--help").succeeds();
63+
let output = result.stdout_str();
64+
65+
// Verify help text contains "vdir" in the usage line
66+
assert!(
67+
output.contains("vdir [OPTION]"),
68+
"Help should show 'vdir [OPTION]'"
69+
);
70+
71+
// Verify help text does not incorrectly show "ls"
72+
assert!(
73+
!output.contains("ls [OPTION]"),
74+
"Help should not show 'ls [OPTION]'"
75+
);
76+
}

0 commit comments

Comments
 (0)