Unregister isolate after Isolate::Dispose (#208)

gahaas · victorgomes · commit 31f65cf03da2 · 2025-09-26T11:32:43.000+02:00
During Isolate::Dispose, CppHeap sweeping gets started, which tries to
load a ForegroundTaskRunner. Loading the ForegroundTaskRunner is,
however, not possible anymore after NodePlatform::UnregisterIsolate.
diff --git a/src/heap_utils.cc b/src/heap_utils.cc
@@ -89,7 +89,7 @@ class JSGraph : public EmbedderGraph {
   }
 
   Node* V8Node(const Local<v8::Value>& value) override {
-    return V8Node(value.As<v8::Data>());
+    return V8Node(Local<v8::Data>(value));
   }
 
   Node* AddNode(std::unique_ptr<Node> node) override {

Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,7 @@ class JSGraph : public EmbedderGraph {`
`89`	`89`	`}`
`90`	`90`
`91`	`91`	`Node* V8Node(const Local<v8::Value>& value) override {`
`92`		`- return V8Node(value.As<v8::Data>());`
	`92`	`+ return V8Node(Local<v8::Data>(value));`
`93`	`93`	`}`
`94`	`94`
`95`	`95`	`Node* AddNode(std::unique_ptr<Node> node) override {`