-
Notifications
You must be signed in to change notification settings - Fork 0
Description
Hello! I tried vite-plus on Pinia Colada. Below are a few observations (no particular order).
Formatting (vite fmt)
@pinia/colada was already using oxlint and oxfmt. One thing I found confusing is that vite fmt outputs nothing when it succeeds, so it’s hard to tell whether anything actually ran. It does show a cache hit when applicable, though.
Other observations
-
Parallel commands
Is there a way to run multiple commands in parallel, similar topnpm run --stream, where you can match scripts using a regex? -
Migration and testing
- Migration was otherwise smooth using
vite migrate. - I hit an error when running
vite test run. - When I run
vite test(it would be cooll to havevite tlikevite i), I expected it to also run the package’stestscript (this is just what I’m used to). vite test --uidoesn’t seem to run in watch mode, so the UI doesn’t really appear. This makes it inconvenient for development.
- Migration was otherwise smooth using
-
Library build / dev commands
In this repo,vite devandvite builddon’t seem to make sense. It feels odd that you need to usevite libto build the library. Shouldvite dev/vite buildadapt automatically for libraries, or should there be a way to override these commands directly viapackage.json? -
The devtools folder has 3 vite configs that must be run (3 entry points with different configs). Maybe I should merge them into one single config?
The vite migrate didn't pick up pnpm run ... inside of package.json. It did pick a lot of things though but when I read the generated CLAUDE.md file I noticed that vite was meant to be run instead of pnpm in most cases so I replaced them manually