Skip to content

Feedback #1

@posva

Description

@posva

Hello! I tried vite-plus on Pinia Colada. Below are a few observations (no particular order).

Formatting (vite fmt)

@pinia/colada was already using oxlint and oxfmt. One thing I found confusing is that vite fmt outputs nothing when it succeeds, so it’s hard to tell whether anything actually ran. It does show a cache hit when applicable, though.

Other observations

  1. Parallel commands
    Is there a way to run multiple commands in parallel, similar to pnpm run --stream, where you can match scripts using a regex?

  2. Migration and testing

    • Migration was otherwise smooth using vite migrate.
    • I hit an error when running vite test run.
    • When I run vite test (it would be cooll to have vite t like vite i), I expected it to also run the package’s test script (this is just what I’m used to).
    • vite test --ui doesn’t seem to run in watch mode, so the UI doesn’t really appear. This makes it inconvenient for development.
  3. Library build / dev commands
    In this repo, vite dev and vite build don’t seem to make sense. It feels odd that you need to use vite lib to build the library. Should vite dev / vite build adapt automatically for libraries, or should there be a way to override these commands directly via package.json?

  4. The devtools folder has 3 vite configs that must be run (3 entry points with different configs). Maybe I should merge them into one single config?

The vite migrate didn't pick up pnpm run ... inside of package.json. It did pick a lot of things though but when I read the generated CLAUDE.md file I noticed that vite was meant to be run instead of pnpm in most cases so I replaced them manually

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions