refactor: use compilation readonly ref in codegen optimization hook (#12743)

* refactor: use compilation readonly ref in code generation optimization hook

* chore: debug bench ci

* fix: 🐛 use offical codseed action

* Debug ci

* Remove debugger

* Limit tokio and rayon worker threads

* Revert "Limit tokio and rayon worker threads"

This reverts commit 10fe6ac.

* Update crates/rspack_plugin_progress/src/lib.rs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: CPunisher <1343316114@qq.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: 3 people

crates/rspack_core/src/compilation/mod.rs

@@ -113,7 +113,7 @@ define_hook!(CompilationAdditionalChunkRuntimeRequirements: Series(compilation:
 define_hook!(CompilationRuntimeRequirementInChunk: SeriesBail(compilation: &mut Compilation, chunk_ukey: &ChunkUkey, all_runtime_requirements: &RuntimeGlobals, runtime_requirements: &RuntimeGlobals, runtime_requirements_mut: &mut RuntimeGlobals));
 define_hook!(CompilationAdditionalTreeRuntimeRequirements: Series(compilation: &mut Compilation, chunk_ukey: &ChunkUkey, runtime_requirements: &mut RuntimeGlobals));
 define_hook!(CompilationRuntimeRequirementInTree: SeriesBail(compilation: &mut Compilation, chunk_ukey: &ChunkUkey, all_runtime_requirements: &RuntimeGlobals, runtime_requirements: &RuntimeGlobals, runtime_requirements_mut: &mut RuntimeGlobals));
-define_hook!(CompilationOptimizeCodeGeneration: Series(compilation: &mut Compilation));
+define_hook!(CompilationOptimizeCodeGeneration: Series(compilation: &Compilation, build_module_graph_artifact: &mut BuildModuleGraphArtifact, diagnostics: &mut Vec<Diagnostic>));
 define_hook!(CompilationAfterCodeGeneration: Series(compilation: &Compilation, diagnostics: &mut Vec<Diagnostic>));
 define_hook!(CompilationChunkHash: Series(compilation: &Compilation, chunk_ukey: &ChunkUkey, hasher: &mut RspackHash),tracing=false);
 define_hook!(CompilationContentHash: Series(compilation: &Compilation, chunk_ukey: &ChunkUkey, hashes: &mut HashMap<SourceType, RspackHash>));

crates/rspack_core/src/compilation/optimize_code_generation/mod.rs

@@ -7,12 +7,25 @@ pub async fn optimize_code_generation_pass(
 ) -> Result<()> {
   let logger = compilation.get_logger("rspack.Compilation");
   let start = logger.time("optimize code generation");
+
+  let mut build_module_graph_artifact = compilation.build_module_graph_artifact.take();
+  let mut diagnostics = vec![];
   plugin_driver
     .compilation_hooks
     .optimize_code_generation
-    .call(compilation)
+    .call(
+      compilation,
+      &mut build_module_graph_artifact,
+      &mut diagnostics,
+    )
     .await
     .map_err(|e| e.wrap_err("caused by plugins in Compilation.hooks.optimizeCodeGeneration"))?;
+
+  compilation
+    .build_module_graph_artifact
+    .replace(build_module_graph_artifact);
+  compilation.extend_diagnostics(diagnostics);
+
   logger.time_end(start);
   Ok(())
 }

crates/rspack_plugin_javascript/src/plugin/mangle_exports_plugin.rs

@@ -6,9 +6,10 @@ use regex::Regex;
 use rspack_core::{
   BuildMetaExportsType, Compilation, CompilationOptimizeCodeGeneration, ExportInfo, ExportProvided,
   ExportsInfo, ExportsInfoGetter, ModuleGraph, Plugin, PrefetchExportsInfoMode,
-  PrefetchedExportsInfoWrapper, UsageState, UsedNameItem, incremental::IncrementalPasses,
+  PrefetchedExportsInfoWrapper, UsageState, UsedNameItem,
+  build_module_graph::BuildModuleGraphArtifact, incremental::IncrementalPasses,
 };
-use rspack_error::Result;
+use rspack_error::{Diagnostic, Result};
 use rspack_hook::{plugin, plugin_hook};
 use rspack_ids::id_helpers::assign_deterministic_ids;
 use rspack_util::atom::Atom;
@@ -59,17 +60,22 @@ struct ExportInfoCache {
 }
 
 #[plugin_hook(CompilationOptimizeCodeGeneration for MangleExportsPlugin)]
-async fn optimize_code_generation(&self, compilation: &mut Compilation) -> Result<()> {
+async fn optimize_code_generation(
+  &self,
+  compilation: &Compilation,
+  build_module_graph_artifact: &mut BuildModuleGraphArtifact,
+  diagnostics: &mut Vec<Diagnostic>,
+) -> Result<()> {
   if let Some(diagnostic) = compilation.incremental.disable_passes(
     IncrementalPasses::MODULES_HASHES,
     "MangleExportsPlugin (optimization.mangleExports = true)",
     "it requires calculating the export names of all the modules, which is a global effect",
   ) && let Some(diagnostic) = diagnostic
   {
-    compilation.push_diagnostic(diagnostic);
+    diagnostics.push(diagnostic);
   }
 
-  let mg = compilation.get_module_graph_mut();
+  let mg = build_module_graph_artifact.get_module_graph_mut();
   let modules = mg.modules();
 
   let mut exports_info_cache = FxHashMap::default();

crates/rspack_plugin_progress/src/lib.rs

@@ -509,7 +509,12 @@ async fn chunk_ids(
 }
 
 #[plugin_hook(CompilationOptimizeCodeGeneration for ProgressPlugin)]
-async fn optimize_code_generation(&self, _compilation: &mut Compilation) -> Result<()> {
+async fn optimize_code_generation(
+  &self,
+  _compilation: &Compilation,
+  _build_module_graph_artifact: &mut BuildModuleGraphArtifact,
+  _diagnostics: &mut Vec<Diagnostic>,
+) -> Result<()> {
   self.sealing_hooks_report("code generation", 26).await
 }