fix: require.resolve() replaced as require() (#12773)

* fix issue 10479

* fix issue 10479

* fix issue 10479

* revert incorrect changes

* fix `require.resolve()`` replaced as `require()`

* check if `require` is a local variable

* fix test

* fix test

Author: intellild

crates/rspack_plugin_javascript/src/parser_plugin/common_js_imports_parse_plugin.rs

@@ -7,7 +7,9 @@ use rspack_util::SpanExt;
 use swc_core::{
   atoms::Atom,
   common::{Span, Spanned},
-  ecma::ast::{AssignExpr, CallExpr, Expr, ExprOrSpread, Ident, MemberExpr, NewExpr, UnaryExpr},
+  ecma::ast::{
+    AssignExpr, CallExpr, Callee, Expr, ExprOrSpread, Ident, MemberExpr, NewExpr, UnaryExpr,
+  },
 };
 
 use super::JavascriptParserPlugin;
@@ -143,6 +145,26 @@ impl CommonJsImportsParserPlugin {
       .unwrap_or_default()
   }
 
+  fn should_process_resolve(parser: &mut JavascriptParser, call_expr: &CallExpr) -> bool {
+    let Callee::Expr(expr) = &call_expr.callee else {
+      return false;
+    };
+
+    let Expr::Member(member_expr) = expr.as_ref() else {
+      return false;
+    };
+
+    let Expr::Ident(ident) = member_expr.obj.as_ref() else {
+      return false;
+    };
+
+    if parser.get_variable_info(&ident.sym).is_some() {
+      return false;
+    }
+
+    true
+  }
+
   fn process_resolve(&self, parser: &mut JavascriptParser, call_expr: &CallExpr, weak: bool) {
     if call_expr.args.len() != 1 {
       return;
@@ -458,14 +480,14 @@ impl JavascriptParserPlugin for CommonJsImportsParserPlugin {
       )),
       expr_name::REQUIRE_RESOLVE => Some(eval::evaluate_to_identifier(
         expr_name::REQUIRE_RESOLVE.into(),
-        expr_name::REQUIRE.into(),
+        expr_name::REQUIRE_RESOLVE.into(),
         Some(true),
         start,
         end,
       )),
       expr_name::REQUIRE_RESOLVE_WEAK => Some(eval::evaluate_to_identifier(
         expr_name::REQUIRE_RESOLVE_WEAK.into(),
-        expr_name::REQUIRE.into(),
+        expr_name::REQUIRE_RESOLVE_WEAK.into(),
         Some(true),
         start,
         end,
@@ -505,13 +527,19 @@ impl JavascriptParserPlugin for CommonJsImportsParserPlugin {
     if for_name == expr_name::REQUIRE || for_name == expr_name::MODULE_REQUIRE {
       self.require_handler(parser, CallOrNewExpr::Call(call_expr))
     } else if for_name == expr_name::REQUIRE_RESOLVE {
-      if matches!(parser.javascript_options.require_resolve, Some(false)) {
+      if matches!(parser.javascript_options.require_resolve, Some(false))
+        || !Self::should_process_resolve(parser, call_expr)
+      {
         return None;
       }
 
       self.process_resolve(parser, call_expr, false);
       Some(true)
     } else if for_name == expr_name::REQUIRE_RESOLVE_WEAK {
+      if !Self::should_process_resolve(parser, call_expr) {
+        return None;
+      }
+
       self.process_resolve(parser, call_expr, true);
       Some(true)
     } else {

tests/rspack-test/normalCases/require/issue-10479/index.js

@@ -0,0 +1,9 @@
+import { require } from './require'
+
+function run() {
+  return require.resolve('module')
+}
+
+it('should not evaluate `require.resolve()` as `require()`', () => {
+  expect(run.toString()).toContain(`.resolve('module')`)
+})

tests/rspack-test/normalCases/require/issue-10479/require.js

@@ -0,0 +1,3 @@
+import { createRequire } from 'module';
+
+export const require = createRequire(import.meta.url);