This repository was archived by the owner on Jan 26, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
This repository was archived by the owner on Jan 26, 2021. It is now read-only.
[37] Users should be able to see Jetpack slideshows #198
Copy link
Copy link
Open
Description
Jetpack has slideshows like this:
https://jetpack.com/2013/01/04/galleries/
and we need to support them.
It injects this two nodes:
<p class="jetpack-slideshow-noscript robots-nocontent">This slideshow requires JavaScript.</p>
<div id="gallery-287250-3-slideshow" class="slideshow-window jetpack-slideshow slideshow-black"
data-trans="fade" data-autostart="1" data-gallery="[{"src":"https:\/\/topesdegama.com\/app\/uploads\/2018\/12\/Oppo-RX17-Pro-22-1024x576.jpg","id":"287294","title":"Oppo RX17 Pro (22)","alt":"","caption":"","itemprop":"image"},{"src":"https:\/\/topesdegama.com\/app\/uploads\/2018\/12\/Oppo-RX17-Pro-21-1024x576.jpg","id":"287292","title":"Oppo RX17 Pro (21)","alt":"","caption":"","itemprop":"image"},{"src":"https:\/\/topesdegama.com\/app\/uploads\/2018\/12\/Oppo-RX17-Pro-20-1024x576.jpg","id":"287290","title":"Oppo RX17 Pro (20)","alt":"","caption":"","itemprop":"image"},{"src":"https:\/\/topesdegama.com\/app\/uploads\/2018\/12\/Oppo-RX17-Pro-23-1024x576.jpg","id":"287296","title":"Oppo RX17 Pro (23)","alt":"","caption":"","itemprop":"image"},{"src":"https:\/\/topesdegama.com\/app\/uploads\/2018\/12\/Oppo-RX17-Pro-26-1024x576.jpg","id":"287302","title":"Oppo RX17 Pro (26)","alt":"","caption":"","itemprop":"image"},{"src":"https:\/\/topesdegama.com\/app\/uploads\/2018\/12\/Oppo-RX17-Pro-27-1024x576.jpg","id":"287304","title":"Oppo RX17 Pro (27)","alt":"","caption":"","itemprop":"image"},{"src":"https:\/\/topesdegama.com\/app\/uploads\/2018\/12\/Oppo-RX17-Pro-25-1024x576.jpg","id":"287300","title":"Oppo RX17 Pro (25)","alt":"","caption":"","itemprop":"image"},{"src":"https:\/\/topesdegama.com\/app\/uploads\/2018\/12\/Oppo-RX17-Pro-24-1024x576.jpg","id":"287298","title":"Oppo RX17 Pro (24)","alt":"","caption":"","itemprop":"image"},{"src":"https:\/\/topesdegama.com\/app\/uploads\/2018\/12\/Oppo-RX17-Pro-19-1024x576.jpg","id":"287288","title":"Oppo RX17 Pro (19)","alt":"","caption":"","itemprop":"image"},{"src":"https:\/\/topesdegama.com\/app\/uploads\/2018\/12\/Oppo-RX17-Pro-29-1024x576.jpg","id":"287308","title":"Oppo RX17 Pro (29)","alt":"","caption":"","itemprop":"image"},{"src":"https:\/\/topesdegama.com\/app\/uploads\/2018\/12\/Oppo-RX17-Pro-28-1024x576.jpg","id":"287306","title":"Oppo RX17 Pro (28)","alt":"","caption":"","itemprop":"image"}]"
itemscope itemtype="https://schema.org/ImageGallery"></div>The first one should be deleted with a processor. The second one should be converted to a Frontity gallery. In order to do that, we need to know the image ids. They are in the data-gallery attribute.
Issues:
- Add
data-galleryto allowed attributes in HtmlPurifier (size: 1) - Create a process that removes the first node (size: 1)
- Create a process for that second node, to turn it into a Frontity gallery (size: 3)
Relevant urls:
https://docs.google.com/spreadsheets/d/1FWcvX7KiLAppGW2qOICxs8ATWqV1uEsCVdTnq5mK7q8/edit#gid=0&range=A36
https://frontity.pipedrive.com/deal/218
Site pageviews: (0.67)
Extra group sites: (1)
Extra group pageviews: (0.23)
Development size: (8)
Blocking: expected (x3)
Environment: integration is finishing (x10)
Reusability potential: broad (x3)
PRIORITY: [37]
Reactions are currently unavailable