Skip to content
This repository was archived by the owner on Jan 26, 2021. It is now read-only.
This repository was archived by the owner on Jan 26, 2021. It is now read-only.

[37] Users should be able to see Jetpack slideshows #198

@SantosGuillamot

Description

@SantosGuillamot

Jetpack has slideshows like this:
https://jetpack.com/2013/01/04/galleries/
and we need to support them.

It injects this two nodes:

<p class="jetpack-slideshow-noscript robots-nocontent">This slideshow requires JavaScript.</p>
                  <div id="gallery-287250-3-slideshow" class="slideshow-window jetpack-slideshow slideshow-black"
                    data-trans="fade" data-autostart="1" data-gallery="[{&quot;src&quot;:&quot;https:\/\/topesdegama.com\/app\/uploads\/2018\/12\/Oppo-RX17-Pro-22-1024x576.jpg&quot;,&quot;id&quot;:&quot;287294&quot;,&quot;title&quot;:&quot;Oppo RX17 Pro (22)&quot;,&quot;alt&quot;:&quot;&quot;,&quot;caption&quot;:&quot;&quot;,&quot;itemprop&quot;:&quot;image&quot;},{&quot;src&quot;:&quot;https:\/\/topesdegama.com\/app\/uploads\/2018\/12\/Oppo-RX17-Pro-21-1024x576.jpg&quot;,&quot;id&quot;:&quot;287292&quot;,&quot;title&quot;:&quot;Oppo RX17 Pro (21)&quot;,&quot;alt&quot;:&quot;&quot;,&quot;caption&quot;:&quot;&quot;,&quot;itemprop&quot;:&quot;image&quot;},{&quot;src&quot;:&quot;https:\/\/topesdegama.com\/app\/uploads\/2018\/12\/Oppo-RX17-Pro-20-1024x576.jpg&quot;,&quot;id&quot;:&quot;287290&quot;,&quot;title&quot;:&quot;Oppo RX17 Pro (20)&quot;,&quot;alt&quot;:&quot;&quot;,&quot;caption&quot;:&quot;&quot;,&quot;itemprop&quot;:&quot;image&quot;},{&quot;src&quot;:&quot;https:\/\/topesdegama.com\/app\/uploads\/2018\/12\/Oppo-RX17-Pro-23-1024x576.jpg&quot;,&quot;id&quot;:&quot;287296&quot;,&quot;title&quot;:&quot;Oppo RX17 Pro (23)&quot;,&quot;alt&quot;:&quot;&quot;,&quot;caption&quot;:&quot;&quot;,&quot;itemprop&quot;:&quot;image&quot;},{&quot;src&quot;:&quot;https:\/\/topesdegama.com\/app\/uploads\/2018\/12\/Oppo-RX17-Pro-26-1024x576.jpg&quot;,&quot;id&quot;:&quot;287302&quot;,&quot;title&quot;:&quot;Oppo RX17 Pro (26)&quot;,&quot;alt&quot;:&quot;&quot;,&quot;caption&quot;:&quot;&quot;,&quot;itemprop&quot;:&quot;image&quot;},{&quot;src&quot;:&quot;https:\/\/topesdegama.com\/app\/uploads\/2018\/12\/Oppo-RX17-Pro-27-1024x576.jpg&quot;,&quot;id&quot;:&quot;287304&quot;,&quot;title&quot;:&quot;Oppo RX17 Pro (27)&quot;,&quot;alt&quot;:&quot;&quot;,&quot;caption&quot;:&quot;&quot;,&quot;itemprop&quot;:&quot;image&quot;},{&quot;src&quot;:&quot;https:\/\/topesdegama.com\/app\/uploads\/2018\/12\/Oppo-RX17-Pro-25-1024x576.jpg&quot;,&quot;id&quot;:&quot;287300&quot;,&quot;title&quot;:&quot;Oppo RX17 Pro (25)&quot;,&quot;alt&quot;:&quot;&quot;,&quot;caption&quot;:&quot;&quot;,&quot;itemprop&quot;:&quot;image&quot;},{&quot;src&quot;:&quot;https:\/\/topesdegama.com\/app\/uploads\/2018\/12\/Oppo-RX17-Pro-24-1024x576.jpg&quot;,&quot;id&quot;:&quot;287298&quot;,&quot;title&quot;:&quot;Oppo RX17 Pro (24)&quot;,&quot;alt&quot;:&quot;&quot;,&quot;caption&quot;:&quot;&quot;,&quot;itemprop&quot;:&quot;image&quot;},{&quot;src&quot;:&quot;https:\/\/topesdegama.com\/app\/uploads\/2018\/12\/Oppo-RX17-Pro-19-1024x576.jpg&quot;,&quot;id&quot;:&quot;287288&quot;,&quot;title&quot;:&quot;Oppo RX17 Pro (19)&quot;,&quot;alt&quot;:&quot;&quot;,&quot;caption&quot;:&quot;&quot;,&quot;itemprop&quot;:&quot;image&quot;},{&quot;src&quot;:&quot;https:\/\/topesdegama.com\/app\/uploads\/2018\/12\/Oppo-RX17-Pro-29-1024x576.jpg&quot;,&quot;id&quot;:&quot;287308&quot;,&quot;title&quot;:&quot;Oppo RX17 Pro (29)&quot;,&quot;alt&quot;:&quot;&quot;,&quot;caption&quot;:&quot;&quot;,&quot;itemprop&quot;:&quot;image&quot;},{&quot;src&quot;:&quot;https:\/\/topesdegama.com\/app\/uploads\/2018\/12\/Oppo-RX17-Pro-28-1024x576.jpg&quot;,&quot;id&quot;:&quot;287306&quot;,&quot;title&quot;:&quot;Oppo RX17 Pro (28)&quot;,&quot;alt&quot;:&quot;&quot;,&quot;caption&quot;:&quot;&quot;,&quot;itemprop&quot;:&quot;image&quot;}]"
                    itemscope itemtype="https://schema.org/ImageGallery"></div>

The first one should be deleted with a processor. The second one should be converted to a Frontity gallery. In order to do that, we need to know the image ids. They are in the data-gallery attribute.

Issues:

  • Add data-gallery to allowed attributes in HtmlPurifier (size: 1)
  • Create a process that removes the first node (size: 1)
  • Create a process for that second node, to turn it into a Frontity gallery (size: 3)

Relevant urls:
https://docs.google.com/spreadsheets/d/1FWcvX7KiLAppGW2qOICxs8ATWqV1uEsCVdTnq5mK7q8/edit#gid=0&range=A36


https://frontity.pipedrive.com/deal/218

Site pageviews: (0.67)
Extra group sites: (1)
Extra group pageviews: (0.23)
Development size: (8)
Blocking: expected (x3)
Environment: integration is finishing (x10)
Reusability potential: broad (x3)
PRIORITY: [37]

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions