Normalize cwd with realpath to avoid casing mismatch#863
Open
Normalize cwd with realpath to avoid casing mismatch#863
Conversation
Member
|
Can you explain how that fixes the issue exactly? And it needs a test. |
Author
|
Thanks for the review! This change normalizes the cwd with realpathSync() in the XO constructor, so a symlinked or case-variant path resolves to the filesystem’s canonical path. That keeps ESLint’s internal cwd aligned with how it reports file paths, which avoids import/no-unresolved false positives on case-insensitive filesystems when the user’s path casing doesn’t match the actual path casing. I’ve also added a test that creates a symlink to the fixture project, instantiates XO with the symlink path, and asserts that linterOptions.cwd is the realpath. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue
Fixes #220