Skip to content

Commit 8b3353a

Browse files
[ci] Revert emscripten to 4.0.21
Latest version reaches an internal compiler error.
1 parent 6f7ee16 commit 8b3353a

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

.github/workflows/emscripten.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,4 +24,4 @@ jobs:
2424
run: |
2525
echo "Build script for wasm"
2626
playwright install
27-
./test/test_wasm/test_wasm.sh
27+
./test/test_wasm/test_wasm.sh 4.0.21

test/test_wasm/test_wasm.sh

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,17 +8,19 @@ SRC_DIR=$TEST_WASM_DIR/../..
88

99
# the emsdk dir can be passed as optional argument
1010
# if not passed, it will be downloaded in the current dir
11-
if [ $# -eq 0 ]
11+
if [ $# -eq 0 -o ! -d "$1" ]
1212
then
13+
EMSCRIPTEN_VERSION=${1:-latest}
1314
git clone https://github.com/emscripten-core/emsdk
1415
cd emsdk
15-
./emsdk install latest
16-
./emsdk activate latest
16+
./emsdk install ${EMSCRIPTEN_VERSION}
17+
./emsdk activate ${EMSCRIPTEN_VERSION}
1718
source ./emsdk_env.sh
1819

1920
else
2021
EMSCRIPTEN_DIR=$1
2122
source $EMSCRIPTEN_DIR/emsdk_env.sh
23+
else
2224
fi
2325

2426

@@ -40,4 +42,4 @@ emmake make -j4
4042
cd ..
4143

4244
# run tests in browser
43-
python $TEST_WASM_DIR/test_wasm_playwright.py build/test
45+
python $TEST_WASM_DIR/test_wasm_playwright.py build/test

0 commit comments

Comments
 (0)