Skip to content

Commit cad88b2

Browse files
authored
NETOBSERV-1649: add drop cause & state labels to metrics (netobserv#676)
1 parent 8a49b67 commit cad88b2

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

pkg/metrics/predefined_metrics.go

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ var (
4646
DefaultIncludeListLokiDisabled = []string{
4747
"node_ingress_bytes_total",
4848
"workload_ingress_bytes_total",
49+
"workload_ingress_packets_total",
4950
"workload_flows_total",
5051
"workload_drop_bytes_total",
5152
"workload_drop_packets_total",
@@ -111,6 +112,8 @@ func init() {
111112
tags: []string{group, "rtt"},
112113
})
113114
// Drops metrics
115+
dropLabels := labels
116+
dropLabels = append(dropLabels, "PktDropLatestState", "PktDropLatestDropCause")
114117
predefinedMetrics = append(predefinedMetrics, taggedMetricDefinition{
115118
FlowMetricSpec: metricslatest.FlowMetricSpec{
116119
MetricName: fmt.Sprintf("%s_drop_packets_total", groupTrimmed),
@@ -119,7 +122,7 @@ func init() {
119122
Filters: []metricslatest.MetricFilter{
120123
{Field: "PktDropPackets", MatchType: metricslatest.MatchPresence},
121124
},
122-
Labels: labels,
125+
Labels: dropLabels,
123126
Charts: dropCharts(group, "pps"),
124127
},
125128
tags: []string{group, tagPackets, "drops"},
@@ -132,7 +135,7 @@ func init() {
132135
Filters: []metricslatest.MetricFilter{
133136
{Field: "PktDropBytes", MatchType: metricslatest.MatchPresence},
134137
},
135-
Labels: labels,
138+
Labels: dropLabels,
136139
Charts: dropCharts(group, "Bps"),
137140
},
138141
tags: []string{group, tagBytes, "drop"},

0 commit comments

Comments
 (0)