Minor improvements to performance in adapters

Used fragments with glide instead of context

Author: yazeed44

app/app.iml

@@ -99,9 +99,9 @@
     <orderEntry type="library" exported="" name="material-dialogs-0.7.6.0" level="project" />
     <orderEntry type="library" exported="" name="commons-lang3-3.3.2" level="project" />
     <orderEntry type="library" exported="" name="support-annotations-22.2.1" level="project" />
+    <orderEntry type="library" exported="" name="robospice-1.4.14" level="project" />
     <orderEntry type="library" exported="" name="commons-io-1.3.2" level="project" />
     <orderEntry type="library" exported="" name="robospice-cache-1.4.14" level="project" />
-    <orderEntry type="library" exported="" name="robospice-1.4.14" level="project" />
     <orderEntry type="library" exported="" name="glide-3.6.0" level="project" />
     <orderEntry type="library" exported="" name="appcompat-v7-22.2.1" level="project" />
     <orderEntry type="module" module-name="imagepicker" exported="" />

imagepicker/imagepicker.iml

@@ -95,8 +95,8 @@
     <orderEntry type="library" exported="" name="recyclerview-v7-22.2.1" level="project" />
     <orderEntry type="library" exported="" name="support-annotations-22.2.1" level="project" />
     <orderEntry type="library" exported="" name="floatingactionbutton-1.3.0" level="project" />
-    <orderEntry type="library" exported="" name="commons-io-1.3.2" level="project" />
     <orderEntry type="library" exported="" name="robospice-cache-1.4.14" level="project" />
+    <orderEntry type="library" exported="" name="commons-io-1.3.2" level="project" />
     <orderEntry type="library" exported="" name="robospice-1.4.14" level="project" />
     <orderEntry type="library" exported="" name="appcompat-v7-22.2.1" level="project" />
     <orderEntry type="library" exported="" name="library-1.2.3" level="project" />

imagepicker/src/main/java/net/yazeed44/imagepicker/model/ImageEntry.java

@@ -41,6 +41,7 @@ public String toString() {
 
     public static class Builder {
 
+        public static int count = -1;
         private final String mPath;
         private int mImageId;
 
@@ -50,7 +51,9 @@ public Builder(final String path) {
 
         public static Builder from(final Uri uri) {
 
-            return new Builder(uri.getPath());
+            return new Builder(uri.getPath())
+                    .imageId(count--)
+                    ;
 
         }
 

imagepicker/src/main/java/net/yazeed44/imagepicker/ui/AlbumsAdapter.java

@@ -1,5 +1,6 @@
 package net.yazeed44.imagepicker.ui;
 
+import android.support.v4.app.Fragment;
 import android.support.v7.widget.RecyclerView;
 import android.view.LayoutInflater;
 import android.view.View;
@@ -29,11 +30,13 @@ public class AlbumsAdapter extends RecyclerView.Adapter<AlbumsAdapter.AlbumViewH
     public final RecyclerView mRecycler;
     protected final ArrayList<AlbumEntry> mAlbumList;
     protected final Picker mPickOptions;
+    private final Fragment mFragment;
 
-    public AlbumsAdapter(final ArrayList<AlbumEntry> albums, RecyclerView mRecycler, Picker pickOptions) {
+    public AlbumsAdapter(final Fragment fragment, final ArrayList<AlbumEntry> albums, final RecyclerView mRecycler) {
+        mFragment = fragment;
         this.mAlbumList = albums;
         this.mRecycler = mRecycler;
-        mPickOptions = pickOptions;
+        mPickOptions = EventBus.getDefault().getStickyEvent(Events.OnPublishPickOptionsEvent.class).options;
     }
 
 
@@ -46,8 +49,9 @@ public AlbumViewHolder onCreateViewHolder(ViewGroup parent, int viewType) {
 
     @Override
     public void onBindViewHolder(AlbumViewHolder holder, int position) {
+        final AlbumEntry albumEntry = mAlbumList.get(position);
         setHeight(holder.itemView);
-        setupAlbum(holder, mAlbumList.get(position));
+        setupAlbum(holder, albumEntry);
 
     }
 
@@ -85,7 +89,7 @@ public void setupAlbum(final AlbumViewHolder holder, final AlbumEntry album) {
         holder.name.setText(album.name);
         holder.count.setText(album.imageList.size() + "");
 
-        Glide.with(mRecycler.getContext())
+        Glide.with(mFragment)
                 .load(album.coverImage.path)
                 .asBitmap()
                 .centerCrop()
@@ -95,7 +99,7 @@ public void setupAlbum(final AlbumViewHolder holder, final AlbumEntry album) {
     }
 
 
-    class AlbumViewHolder extends RecyclerView.ViewHolder {
+    static class AlbumViewHolder extends RecyclerView.ViewHolder {
         protected final ImageView thumbnail;
         protected final TextView count;
         protected final TextView name;

imagepicker/src/main/java/net/yazeed44/imagepicker/ui/AlbumsFragment.java

@@ -55,6 +55,7 @@ public View onCreateView(LayoutInflater inflater, ViewGroup container,
             }
 
 
+
         }
 
 
@@ -97,7 +98,7 @@ public void onRequestSuccess(ArrayList albumEntries) {
 
             EventBus.getDefault().postSticky(new Events.OnAlbumsLoadedEvent(mAlbumList));
 
-            final AlbumsAdapter albumsAdapter = new AlbumsAdapter(albumEntries, mAlbumsRecycler, mPickOptions);
+            final AlbumsAdapter albumsAdapter = new AlbumsAdapter(this, albumEntries, mAlbumsRecycler);
             mAlbumsRecycler.setAdapter(albumsAdapter);
 
 
@@ -109,8 +110,6 @@ public void onRequestSuccess(ArrayList albumEntries) {
     protected void setupRecycler() {
 
         mAlbumsRecycler.setHasFixedSize(true);
-
-
         final GridLayoutManager gridLayoutManager = new GridLayoutManager(getActivity(), getResources().getInteger(R.integer.num_columns_albums));
         gridLayoutManager.setOrientation(LinearLayoutManager.VERTICAL);
 
@@ -126,7 +125,7 @@ public void setupAdapter() {
             mSpiceManager.execute(loadingRequest, this);
         } else {
 
-            mAlbumsRecycler.setAdapter(new AlbumsAdapter(mAlbumList, mAlbumsRecycler, mPickOptions));
+            mAlbumsRecycler.setAdapter(new AlbumsAdapter(this, mAlbumList, mAlbumsRecycler));
         }
 
 

imagepicker/src/main/java/net/yazeed44/imagepicker/ui/ImagePagerAdapter.java

@@ -1,6 +1,6 @@
 package net.yazeed44.imagepicker.ui;
 
-import android.content.Context;
+import android.support.v4.app.Fragment;
 import android.support.v4.view.PagerAdapter;
 import android.view.View;
 import android.view.ViewGroup;
@@ -21,12 +21,12 @@ public class ImagePagerAdapter extends PagerAdapter {
 
 
     protected final AlbumEntry mAlbumEntry;
-    protected final Context mContext;
+    protected final Fragment mFragment;
     protected final PhotoViewAttacher.OnViewTapListener mTapListener;
 
-    public ImagePagerAdapter(final Context context, final AlbumEntry albumEntry, final PhotoViewAttacher.OnViewTapListener tapListener) {
+    public ImagePagerAdapter(final Fragment fragment, final AlbumEntry albumEntry, final PhotoViewAttacher.OnViewTapListener tapListener) {
         mAlbumEntry = albumEntry;
-        mContext = context;
+        mFragment = fragment;
         mTapListener = tapListener;
     }
 
@@ -43,11 +43,11 @@ public boolean isViewFromObject(View view, Object object) {
     @Override
     public Object instantiateItem(ViewGroup container, int position) {
         final ImageEntry imageEntry = mAlbumEntry.imageList.get(position);
-        final PhotoView view = new PhotoView(mContext);
+        final PhotoView view = new PhotoView(mFragment.getActivity());
         view.setOnViewTapListener(mTapListener);
 
 
-        Glide.with(mContext)
+        Glide.with(mFragment)
                 .load(imageEntry.path)
                 .asBitmap()
                 .into(view);

imagepicker/src/main/java/net/yazeed44/imagepicker/ui/ImagesPagerFragment.java

@@ -138,7 +138,7 @@ public void onEvent(final Events.OnPickImageEvent pickImageEvent) {
         if (mImagePager.getAdapter() != null) {
             return;
         }
-        mImagePager.setAdapter(new ImagePagerAdapter(getActivity(), mSelectedAlbum, this));
+        mImagePager.setAdapter(new ImagePagerAdapter(this, mSelectedAlbum, this));
         final int imagePosition = mSelectedAlbum.imageList.indexOf(pickImageEvent.imageEntry);
 
         mImagePager.setCurrentItem(imagePosition);

imagepicker/src/main/java/net/yazeed44/imagepicker/ui/ImagesThumbnailAdapter.java

@@ -2,6 +2,7 @@
 
 import android.graphics.Color;
 import android.graphics.drawable.Drawable;
+import android.support.v4.app.Fragment;
 import android.support.v4.content.ContextCompat;
 import android.support.v4.graphics.drawable.DrawableCompat;
 import android.support.v7.widget.RecyclerView;
@@ -33,9 +34,11 @@ public class ImagesThumbnailAdapter extends RecyclerView.Adapter<ImagesThumbnail
     protected final Picker mPickOptions;
 
     protected final Drawable mCheckIcon;
+    protected final Fragment mFragment;
 
 
-    public ImagesThumbnailAdapter(final AlbumEntry album, final RecyclerView recyclerView, Picker pickOptions) {
+    public ImagesThumbnailAdapter(final Fragment fragment, final AlbumEntry album, final RecyclerView recyclerView, Picker pickOptions) {
+        mFragment = fragment;
         this.mAlbum = album;
         this.mRecyclerView = recyclerView;
         mPickOptions = pickOptions;
@@ -89,7 +92,7 @@ public void setHeight(final View convertView) {
     public void displayThumbnail(final ImageViewHolder holder, final ImageEntry photo) {
 
 
-        Glide.with(mRecyclerView.getContext())
+        Glide.with(mFragment)
                 .load(photo.path)
                 .asBitmap()
                 .centerCrop()

imagepicker/src/main/java/net/yazeed44/imagepicker/ui/ImagesThumbnailFragment.java

@@ -64,7 +64,7 @@ protected void setupRecycler() {
 
 
     public void onEvent(final Events.OnClickAlbumEvent event) {
-        mImagesRecycler.setAdapter(new ImagesThumbnailAdapter(event.albumEntry, mImagesRecycler, mPickOptions));
+        mImagesRecycler.setAdapter(new ImagesThumbnailAdapter(this, event.albumEntry, mImagesRecycler, mPickOptions));
     }