sql/ydb: fixed tests

Author: LostImagin4tion

sql/ydb/attributes.go

@@ -8,8 +8,8 @@ package ydb
 
 import "ariga.io/atlas/sql/schema"
 
-// YDBIndexType represents YDB-specific index attributes.
-type YDBIndexAttributes struct {
+//[IndexAttributes] represents YDB-specific index attributes.
+type IndexAttributes struct {
 	schema.Attr
 	Global bool // GLOBAL, LOCAL
 	Sync   bool // SYNC, ASYNC

sql/ydb/convert_test.go

@@ -188,9 +188,9 @@ func TestConvert_ParseType(t *testing.T) {
 		{name: "tztimestamp64", input: TypeTzTimestamp64, expected: &schema.TimeType{T: TypeTzTimestamp64}},
 
 		// Optional types
-		{name: "optional_int32", input: "Optional<int32>", expected: &OptionalType{T: "Optional<int32>", InnerType: &schema.IntegerType{T: TypeInt32, Unsigned: false}}},
-		{name: "optional_utf8", input: "Optional<utf8>", expected: &OptionalType{T: "Optional<utf8>", InnerType: &schema.StringType{T: TypeUtf8}}},
-		{name: "optional_bool", input: "Optional<bool>", expected: &OptionalType{T: "Optional<bool>", InnerType: &schema.BoolType{T: TypeBool}}},
+		{name: "optional_int32", input: "Optional<int32>", expected: &OptionalType{T: "optional<int32>", InnerType: &schema.IntegerType{T: TypeInt32, Unsigned: false}}},
+		{name: "optional_utf8", input: "Optional<utf8>", expected: &OptionalType{T: "optional<utf8>", InnerType: &schema.StringType{T: TypeUtf8}}},
+		{name: "optional_bool", input: "Optional<bool>", expected: &OptionalType{T: "optional<bool>", InnerType: &schema.BoolType{T: TypeBool}}},
 
 		// Unsupported/unknown types
 		{name: "unknown_type", input: "unknown", expected: &schema.UnsupportedType{T: "unknown"}},

sql/ydb/migrate.go

@@ -285,28 +285,28 @@ func (s *state) alterTable(t *schema.Table, changes []schema.Change) error {
 func (s *state) addIndexes(src schema.Change, t *schema.Table, indexes ...*schema.AddIndex) error {
 	for _, add := range indexes {
 		index := add.I
-		indexAttrs := YDBIndexAttributes{}
-		sqlx.Has(index.Attrs, &indexAttrs)
+		indexAttrs := IndexAttributes{}
+		hasAttrs := sqlx.Has(index.Attrs, &indexAttrs)
 
 		b := s.Build("ALTER TABLE").
 			Table(t).
 			P("ADD INDEX").
 			Ident(index.Name)
 
-		if indexAttrs.Global {
-			b.P("GLOBAL")
-		} else {
+		if hasAttrs && !indexAttrs.Global {
 			b.P("LOCAL")
+		} else {
+			b.P("GLOBAL")
 		}
 
 		if index.Unique {
 			b.P("UNIQUE")
 		}
 
-		if indexAttrs.Sync {
-			b.P("SYNC")
-		} else {
+		if hasAttrs && !indexAttrs.Sync {
 			b.P("ASYNC")
+		} else {
+			b.P("SYNC")
 		}
 
 		b.P("ON")

sql/ydb/migrate_test.go

@@ -553,7 +553,7 @@ func TestPlanChanges_AddIndex(t *testing.T) {
 				Transactional: true,
 				Changes: []*migrate.Change{
 					{
-						Cmd:     "ALTER TABLE `users` ADD INDEX `idx_name` GLOBAL ON (`name`)",
+						Cmd:     "ALTER TABLE `users` ADD INDEX `idx_name` GLOBAL SYNC ON (`name`)",
 						Reverse: "ALTER TABLE `users` DROP INDEX `idx_name`",
 						Comment: `create index "idx_name" to table: "users"`,
 					},
@@ -576,7 +576,7 @@ func TestPlanChanges_AddIndex(t *testing.T) {
 				Transactional: true,
 				Changes: []*migrate.Change{
 					{
-						Cmd:     "ALTER TABLE `users` ADD INDEX `idx_name_email` GLOBAL ON (`name`, `email`)",
+						Cmd:     "ALTER TABLE `users` ADD INDEX `idx_name_email` GLOBAL SYNC ON (`name`, `email`)",
 						Reverse: "ALTER TABLE `users` DROP INDEX `idx_name_email`",
 						Comment: `create index "idx_name_email" to table: "users"`,
 					},
@@ -602,12 +602,12 @@ func TestPlanChanges_AddIndex(t *testing.T) {
 				Transactional: true,
 				Changes: []*migrate.Change{
 					{
-						Cmd:     "ALTER TABLE `users` ADD INDEX `idx_name` GLOBAL ON (`name`)",
+						Cmd:     "ALTER TABLE `users` ADD INDEX `idx_name` GLOBAL SYNC ON (`name`)",
 						Reverse: "ALTER TABLE `users` DROP INDEX `idx_name`",
 						Comment: `create index "idx_name" to table: "users"`,
 					},
 					{
-						Cmd:     "ALTER TABLE `users` ADD INDEX `idx_email` GLOBAL ON (`email`)",
+						Cmd:     "ALTER TABLE `users` ADD INDEX `idx_email` GLOBAL SYNC ON (`email`)",
 						Reverse: "ALTER TABLE `users` DROP INDEX `idx_email`",
 						Comment: `create index "idx_email" to table: "users"`,
 					},
@@ -665,7 +665,7 @@ func TestPlanChanges_DropIndex(t *testing.T) {
 				Changes: []*migrate.Change{
 					{
 						Cmd:     "ALTER TABLE `users` DROP INDEX `idx_name`",
-						Reverse: "ALTER TABLE `users` ADD INDEX `idx_name` GLOBAL ON (`name`)",
+						Reverse: "ALTER TABLE `users` ADD INDEX `idx_name` GLOBAL SYNC ON (`name`)",
 						Comment: `drop index "idx_name" from table: "users"`,
 					},
 				},
@@ -691,12 +691,12 @@ func TestPlanChanges_DropIndex(t *testing.T) {
 				Changes: []*migrate.Change{
 					{
 						Cmd:     "ALTER TABLE `users` DROP INDEX `idx_name`",
-						Reverse: "ALTER TABLE `users` ADD INDEX `idx_name` GLOBAL ON (`name`)",
+						Reverse: "ALTER TABLE `users` ADD INDEX `idx_name` GLOBAL SYNC ON (`name`)",
 						Comment: `drop index "idx_name" from table: "users"`,
 					},
 					{
 						Cmd:     "ALTER TABLE `users` DROP INDEX `idx_email`",
-						Reverse: "ALTER TABLE `users` ADD INDEX `idx_email` GLOBAL ON (`email`)",
+						Reverse: "ALTER TABLE `users` ADD INDEX `idx_email` GLOBAL SYNC ON (`email`)",
 						Comment: `drop index "idx_email" from table: "users"`,
 					},
 				},
@@ -754,11 +754,11 @@ func TestPlanChanges_ModifyIndex(t *testing.T) {
 				Changes: []*migrate.Change{
 					{
 						Cmd:     "ALTER TABLE `users` DROP INDEX `idx_name`",
-						Reverse: "ALTER TABLE `users` ADD INDEX `idx_name` GLOBAL ON (`name`)",
+						Reverse: "ALTER TABLE `users` ADD INDEX `idx_name` GLOBAL SYNC ON (`name`)",
 						Comment: `drop index "idx_name" from table: "users"`,
 					},
 					{
-						Cmd:     "ALTER TABLE `users` ADD INDEX `idx_name` GLOBAL ON (`name`, `email`)",
+						Cmd:     "ALTER TABLE `users` ADD INDEX `idx_name` GLOBAL SYNC ON (`name`, `email`)",
 						Reverse: "ALTER TABLE `users` DROP INDEX `idx_name`",
 						Comment: `create index "idx_name" to table: "users"`,
 					},