Model DEM errors?

[wbxiao-pkusess]

If not reported yet, I found a potentail error for calculating the DEM model.

In the source file 'EM.py', Lines 778-787 are the following:

@staticmethod
def DEM(y,t, params):
'''
ODE solver tutorial: https://physics.nyu.edu/pine/pymanual/html/chap9/chap9_scipy.html.
'''
K_eff,G_eff=y # unpack current values of y
Gi,Ki,alpha = params # unpack parameters
P, Q= EM.PQ(G_eff,K_eff,Gi,Ki, alpha) # !!! K_eff,G_eff, Ki,Gi, alpha
derivs = [1/(1-t) * (Ki-K_eff) * P, 1/(1-t) * -G_eff * Q] # !!! (Gi-G_eff)
return derivs

As I noted with '!', the input parameter order of EM.PQ() is 'PQ(Km,Gm, Ki,Gi, alpha)', at Line 724; an incorrect input parameter order may be done here.

Also, for the next line to calculate 'derivs', '-G_eff' may be correct as '(Gi-G_eff)'

Please check for these.

[yujiaxin666]

Thanks for your comment, will check and update after sick leave. :>