Skip to content

Use project commands like :FzfPreviewProjectFiles and :FzfPreviewProjectMruFiles on non-git repos #314

@gitaarik

Description

@gitaarik

Problems summary

I can't use project commands like :FzfPreviewProjectFiles and :FzfPreviewProjectMruFiles on non-git repos, even when I use ripgrep, which should make fzf-preview not require git.

Expected

That I can use project commands like :FzfPreviewProjectFiles and :FzfPreviewProjectMruFiles in non-git repo directories.

Proposed solution

So when you have ripgrep installed, the g:fzf_preview_filelist_command, which is used to get the file list from project, uses ripgrep instead of git. Also, you can overwrite g:fzf_preview_filelist_command to any kind of command. So we should not decide for the user whether they are allowed to use the project commands, just because we're not in a git repo.

If I remove this check on whether it's a git repo in these commands:

https://github.com/yuki-yano/fzf-preview.vim/blob/main/src/fzf/resource/project-files.ts#L8-L10
https://github.com/yuki-yano/fzf-preview.vim/blob/main/src/fzf/resource/project-mru.ts#L13-L15

It seems to fix the issue. I can make a PR for this if approved.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions