Fixed condition (#172)

Author: yutachaos

pkg/monitoring/datadog.go

@@ -42,7 +42,7 @@ func newDatadog() datadog {
 }
 
 func (d datadog) SuccessEvent(jobInfo JobInfo) (err error) {
-	if isSubscriptionSuppressed(jobInfo.Annotations, suppressFailedAnnotationName) {
+	if isSubscriptionSuppressed(jobInfo.Annotations, suppressSuccessAnnotationName) {
 		klog.Infof("Notification for %s is suppressed", jobInfo.Name)
 		return nil
 	}
@@ -66,7 +66,7 @@ func (d datadog) SuccessEvent(jobInfo JobInfo) (err error) {
 }
 
 func (d datadog) FailEvent(jobInfo JobInfo) (err error) {
-	if isSubscriptionSuppressed(jobInfo.Annotations, suppressSuccessAnnotationName) {
+	if isSubscriptionSuppressed(jobInfo.Annotations, suppressFailedAnnotationName) {
 		klog.Infof("Notification for %s is suppressed", jobInfo.Name)
 		return nil
 	}

pkg/monitoring/datadog_test.go

@@ -54,6 +54,22 @@ func TestisSubscriptionSuppressed(t *testing.T) {
 			"kube-job-notifier/suppress-success-datadog-subscription",
 			true,
 		},
+		{
+			"Annotation not true",
+			map[string]string{
+				"kube-job-notifier/suppress-failed-datadog-subscription": "false",
+			},
+			"kube-job-notifier/suppress-failed-datadog-subscription",
+			false,
+		},
+		{
+			"Annotation true",
+			map[string]string{
+				"kube-job-notifier/suppress-failed-datadog-subscription": "true",
+			},
+			"kube-job-notifier/suppress-failed-datadog-subscription",
+			true,
+		},
 		{
 			"Nil annotation not break",
 			nil,