Send MS Teams V2 notifications (#248)

* refactor: replace interface{} with any and simplify code

- Use `any` alias instead of `interface{}` in event handlers
- Remove redundant `== true` in boolean checks
- Simplify `ObjectMeta.Annotations` to `Annotations`

* chore: add asdf tool-versions to gitignore

* refactor: remove unused kubeclientset field from Controller

- Remove kubeclientset from Controller struct
- Fix error handling in job event handlers

* feat: add MS Teams v2 notification support

- Add HTTP client with retry logic
- Implement MS Teams adaptive card structure
- Register msteamsv2 in notification registry
- Update README with Teams config examples
- Refactor slack env check logic

* chore: update module path and add MSTeamsV2 implementation

- Change module path from yutachaos to remmercier
- Add kube-job-notifier binary to gitignore
- Implement MSTeamsV2 NotifyStart method
- Add environment variable checks for notification enablement
- Remove unused httpclient dependency in msteamsv2.go

* chore: add .vscode to gitignore and reorder imports

- Ignore .vscode directory
- Group standard library imports before external packages

* feat: implement MS Teams v2 notifications

- Add message template with job details formatting
- Implement NotifyStart, NotifySuccess, and NotifyFailed methods
- Format text with double line breaks for Adaptive Cards
- Update card version to 1.4

* feat: add cronjob filtering by regex pattern

- Add CRONJOB_REGEX env var to filter monitored cronjobs
- Check regex match early in event handlers
- Move cronjob name lookup before pod wait
- Update README with new config option

* refactor: remove unused httpclient package

- Delete pkg/httpclient/http.go with HTTPClient implementation

* test: add comprehensive tests for MS Teams V2 notifications

- Cover webhook initialization and validation
- Test adaptive card payload generation
- Verify notification methods (start, success, failed)
- Add error handling test cases

* refactor: improve error handling in job event handlers

- Handle getPodFromControllerUID errors properly
- Fix indentation in notification block
- Remove unused isCronjobNameIncluded function

Author: remmercier

.gitignore

@@ -23,6 +23,8 @@
 /vendor/
 /Godeps/
 
+kube-job-notifier
+
 ### Intellij ###
 # Covers JetBrains IDEs: IntelliJ, RubyMine, PhpStorm, AppCode, PyCharm, CLion, Android Studio and WebStorm
 # Reference: https://intellij-support.jetbrains.com/hc/en-us/articles/206544839
@@ -144,4 +146,9 @@ Temporary Items
 # direnv
 .envrc
 
-*.tgz
+*.tgz
+
+# asdf
+.tool-versions
+
+.vscode

README.md

@@ -39,6 +39,9 @@ kubectl get po
 Configure using environment variables:
 
 ```bash
+export MSTEAMSV2_ENABLED=true
+export MSTEAMSV2_WEBHOOK_URL=YOUR_WEBHOOK_URL
+export SLACK_ENABLED=true
 export SLACK_TOKEN=YOUR_SLACK_TOKEN
 export SLACK_CHANNEL=YOUR_NOTIFICATION_CHANNEL_ID
 export SLACK_STARTED_NOTIFY=true      # Optional, default: true
@@ -47,8 +50,9 @@ export SLACK_FAILED_NOTIFY=true       # Optional, default: true
 export SLACK_USERNAME=YOUR_NOTIFICATION_USERNAME  # Optional
 export SLACK_SUCCEED_CHANNEL=YOUR_NOTIFICATION_CHANNEL_ID  # Optional
 export SLACK_FAILED_CHANNEL=YOUR_NOTIFICATION_CHANNEL_ID   # Optional
-export DATADOG_ENABLED=true           # Optional, default: false
-export NAMESPACE=KUBERNETES_NAMESPACE # Optional
+export DATADOG_ENABLED=true               # Optional, default: false
+export NAMESPACE=KUBERNETES_NAMESPACE     # Optional
+export CRONJOB_REGEX=REGEX                # Optional, if empty all cronjobs will be included
 ```
 
 ### Job Annotation Configuration

controller.go

@@ -6,12 +6,13 @@ import (
 	"fmt"
 	"io"
 	"os"
+	"regexp"
 	"strings"
 	"time"
 
+	"github.com/remmercier/kube-job-notifier/pkg/monitoring"
+	"github.com/remmercier/kube-job-notifier/pkg/notification"
 	"github.com/thoas/go-funk"
-	"github.com/yutachaos/kube-job-notifier/pkg/monitoring"
-	"github.com/yutachaos/kube-job-notifier/pkg/notification"
 	batchv1 "k8s.io/api/batch/v1"
 	corev1 "k8s.io/api/core/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
@@ -47,10 +48,9 @@ var serverStartTime time.Time
 
 // Controller is Kubernetes Controller struct
 type Controller struct {
-	kubeclientset kubernetes.Interface
-	jobsLister    batcheslisters.JobLister
-	jobsSynced    cache.InformerSynced
-	recorder      record.EventRecorder
+	jobsLister batcheslisters.JobLister
+	jobsSynced cache.InformerSynced
+	recorder   record.EventRecorder
 }
 
 // NewController returns a new controller
@@ -76,42 +76,56 @@ func NewController(
 	subscriptions := monitoring.NewSubscription()
 	datadogSubscription := subscriptions["datadog"]
 
+	regexEnv := os.Getenv("CRONJOB_REGEX")
+	var regex *regexp.Regexp
+	if regexEnv != "" {
+		regex = regexp.MustCompile(regexEnv)
+	}
+
 	klog.Info("Setting event handlers")
 	jobInformer.Informer().AddEventHandler(cache.ResourceEventHandlerFuncs{
-		AddFunc: func(new interface{}) {
+		AddFunc: func(new any) {
 			newJob := new.(*batchv1.Job)
 			klog.Infof("Job added: %v", newJob.Status)
 
+			cronJob, err := getCronJobNameFromOwnerReferences(kubeclientset, newJob)
+			if err != nil {
+				klog.Errorf("Get cronjob failed: %v", err)
+			}
+
+			if regex != nil && !regex.MatchString(cronJob) {
+				return
+			}
+
 			if newJob.CreationTimestamp.Sub(serverStartTime).Seconds() < 0 {
 				return
 			}
 
-			if notifiedJobs[newJob.Name] == true {
+			if notifiedJobs[newJob.Name] {
 				return
 			}
 
 			klog.Infof("Job started: %v", newJob.Status)
 
 			jobPod, err := getPodFromControllerUID(kubeclientset, newJob)
-			err = waitForPodRunning(kubeclientset, jobPod)
-
 			if err != nil {
-				klog.Errorf("Error waiting for pod to become running: %v", jobPod)
+				klog.Errorf("Get pods failed: %v", err)
 				return
 			}
 
-			cronJob, err := getCronJobNameFromOwnerReferences(kubeclientset, newJob)
-
+			err = waitForPodRunning(kubeclientset, jobPod)
 			if err != nil {
-				klog.Errorf("Get cronjob failed: %v", err)
+				klog.Errorf("Error waiting for pod to become running: %v", jobPod)
+				return
 			}
+
 			klog.Infof("Job started: %v", newJob.Status)
 			messageParam := notification.MessageTemplateParam{
 				JobName:     newJob.Name,
 				CronJobName: cronJob,
 				Namespace:   newJob.Namespace,
 				StartTime:   newJob.Status.StartTime,
-				Annotations: newJob.Spec.Template.ObjectMeta.Annotations,
+				Annotations: newJob.Spec.Template.Annotations,
 			}
 			for name, n := range notifications {
 				err := n.NotifyStart(messageParam)
@@ -121,23 +135,36 @@ func NewController(
 			}
 
 		},
-		UpdateFunc: func(old, new interface{}) {
+		UpdateFunc: func(old, new any) {
 			newJob := new.(*batchv1.Job)
 			oldJob := old.(*batchv1.Job)
 
 			klog.Infof("oldJob.Status:%v", oldJob.Status)
 			klog.Infof("newJob.Status:%v", newJob.Status)
+			cronJobName, err := getCronJobNameFromOwnerReferences(kubeclientset, newJob)
+			if err != nil {
+				klog.Errorf("Get cronjob failed: %v", err)
+			}
+
+			if regex != nil && !regex.MatchString(cronJobName) {
+				return
+			}
+
 			if newJob.CreationTimestamp.Sub(serverStartTime).Seconds() < 0 {
 				return
 			}
 
-			if notifiedJobs[newJob.Name] == true {
+			if notifiedJobs[newJob.Name] {
 				return
 			}
 
 			jobPod, err := getPodFromControllerUID(kubeclientset, newJob)
-			err = waitForPodRunning(kubeclientset, jobPod)
+			if err != nil {
+				klog.Errorf("Get pods failed: %v", err)
+				return
+			}
 
+			err = waitForPodRunning(kubeclientset, jobPod)
 			if err != nil {
 				klog.Errorf("Error waiting for pod to become running: %v", err)
 				return
@@ -151,13 +178,7 @@ func NewController(
 					return
 				}
 
-				cronJobName, err := getCronJobNameFromOwnerReferences(kubeclientset, newJob)
-
-				if err != nil {
-					klog.Errorf("Get cronjob failed: %v", err)
-					return
-				}
-				annotations := newJob.Spec.Template.ObjectMeta.Annotations
+				annotations := newJob.Spec.Template.Annotations
 				lm := getLogMode(annotations, logModeAnnotationName)
 				jobLogStr := getJobLogs(kubeclientset, jobPod, cronJobName, lm)
 
@@ -185,7 +206,7 @@ func NewController(
 							CronJobName: cronJobName,
 							Name:        newJob.Name,
 							Namespace:   newJob.Namespace,
-							Annotations: newJob.Spec.Template.ObjectMeta.Annotations,
+							Annotations: newJob.Spec.Template.Annotations,
 						})
 					if err != nil {
 						klog.Errorf("Fail event subscribe.: %v", err)
@@ -207,7 +228,7 @@ func NewController(
 					return
 				}
 
-				annotations := newJob.Spec.Template.ObjectMeta.Annotations
+				annotations := newJob.Spec.Template.Annotations
 				lm := getLogMode(annotations, logModeAnnotationName)
 				jobLogStr := getJobLogs(kubeclientset, jobPod, cronJobName, lm)
 
@@ -232,7 +253,7 @@ func NewController(
 							CronJobName: cronJobName,
 							Name:        newJob.Name,
 							Namespace:   newJob.Namespace,
-							Annotations: newJob.Spec.Template.ObjectMeta.Annotations,
+							Annotations: newJob.Spec.Template.Annotations,
 						})
 					if err != nil {
 						klog.Errorf("Fail event subscribe.: %v", err)
@@ -241,7 +262,7 @@ func NewController(
 				notifiedJobs[newJob.Name] = isCompletedJob(kubeclientset, newJob)
 			}
 		},
-		DeleteFunc: func(obj interface{}) {
+		DeleteFunc: func(obj any) {
 			deletedJob := obj.(*batchv1.Job)
 			delete(notifiedJobs, deletedJob.Name)
 		},

go.mod

@@ -1,4 +1,4 @@
-module github.com/yutachaos/kube-job-notifier
+module github.com/remmercier/kube-job-notifier
 
 go 1.23
 

main.go

@@ -2,15 +2,16 @@ package main
 
 import (
 	"flag"
-	"github.com/yutachaos/kube-job-notifier/pkg/signals"
+	"os"
+	"os/user"
+	"path/filepath"
+
+	"github.com/remmercier/kube-job-notifier/pkg/signals"
 	kubeinformers "k8s.io/client-go/informers"
 	"k8s.io/client-go/kubernetes"
 	"k8s.io/client-go/rest"
 	"k8s.io/client-go/tools/clientcmd"
 	"k8s.io/klog"
-	"os"
-	"os/user"
-	"path/filepath"
 )
 
 var (