Closed
Conversation
Co-authored-by: zachowj <37859597+zachowj@users.noreply.github.com>
…e access Co-authored-by: zachowj <37859597+zachowj@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix update config node for number entity attributes
Fix update config node for number entities
Dec 8, 2025
Owner
|
@copilot Need to fix linting issues |
Co-authored-by: zachowj <37859597+zachowj@users.noreply.github.com>
Author
Owner
|
@copilot resolve conficts and update to use new ruff rules |
Co-authored-by: zachowj <37859597+zachowj@users.noreply.github.com>
Author
Resolved in 84a8937. Merged latest main branch changes including:
|
Owner
|
@copilot Need to rebase with current main branch |
Author
Rebased onto latest main in commit 6c7267a. All changes preserved:
The branch is ready but needs a force push due to rebase. The commits are:
|
Copilot stopped work on behalf of
zachowj due to an error
December 9, 2025 15:08
Owner
|
@copilot remove all changes except for those in sentence.py and tests/test_sentence.py |
Co-authored-by: zachowj <37859597+zachowj@users.noreply.github.com>
Copilot
AI
changed the title
Fix update config node for number entities
Code formatting improvements for sentence.py
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code formatting improvements for sentence.py
Changes Made
custom_components/nodered/sentence.py:
asyncio.TimeoutErrortoTimeoutError(Python 3.11+ standard exception)dict.pop(key, None)instead of conditional deletionTesting
These changes improve code quality and maintainability without altering any functionality.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.