types(museum): correct & augment museum endpoint typing

Resolves #461

Author: zikeji

src/types/Augmented/SkyBlock/Museum.ts

@@ -0,0 +1,20 @@
+import type { Components } from "../../api";
+import { MinecraftInventoryData } from "../../AugmentedTypes";
+
+export type SkyBlockMuseumItem = {
+  donated_time: number;
+  featured_slot: string;
+  borrowing?: boolean;
+  items: MinecraftInventoryData;
+};
+
+/** augment the typing of items / special */
+export type SkyBlockMuseumMember = Omit<
+  Components.Schemas.SkyBlockMuseum,
+  "items"
+> & {
+  items?: {
+    [key: string]: SkyBlockMuseumItem | undefined;
+  };
+  special?: SkyBlockMuseumItem[];
+};

src/types/AugmentedTypes.ts

@@ -10,6 +10,7 @@ import type {
   ElectionMayor,
 } from "./Augmented/Resources/SkyBlock/Election";
 import type { SkyBlockAuction } from "./Augmented/SkyBlock/Auction";
+import type { SkyBlockMuseumMember } from "./Augmented/SkyBlock/Museum";
 import type { SkyBlockProfile } from "./Augmented/SkyBlock/Profile";
 
 export type BoostersResponse = Paths.V2Boosters.Get.Responses.$200 &
@@ -220,8 +221,13 @@ export type SkyblockProfilesResponse = Omit<
     profiles: SkyBlockProfile[];
   };
 
-export type SkyblockMuseumResponse = Paths.V2SkyblockMuseum.Get.Responses.$200 &
-  Record<string, unknown>;
+export type SkyblockMuseumResponse = Omit<Paths.V2SkyblockMuseum.Get.Responses.$200, 'profile'> &
+  Record<string, unknown> & {
+    success?: true;
+    members: {
+      [key: string]: SkyBlockMuseumMember | undefined
+    };
+  };
 
 export type SkyblockGardenResponse = Paths.V2SkyblockGarden.Get.Responses.$200 &
   Record<string, unknown>;