Conversation
Owner
|
Oops, check failed :( |
0140454
requested changes
Sep 16, 2025
DNEGEL3125
force-pushed
the
replace-find
branch
from
04b50c7 to
62f26ce
Compare
Contributor
Author
It seemed that it was not passing because of |
Use `fs.readdirSync` and `fs.rmSync` instead of `child_process.execFileSync` with `find` command for better maintainability and cross-platform compatibility
DNEGEL3125
force-pushed
the
replace-find
branch
from
62f26ce to
7bcd197
Compare
Contributor
Author
|
I updated |
0140454
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
fs.readdirSyncandfs.rmSyncinstead ofchild_process.execFileSyncwithfindcommand for better maintainability and cross-platform compatibility.With this change,
curlconverter.jscan be run on Mac.