Add ::setStrictModeForTest() function#265
Open
BrianHenryIE wants to merge 6 commits into10up:trunkfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
WP_Mock::setStrictModeForTest()to control strict mode for an individual test, respecting the bootstrapped configuration for other tests.Closes:
#249
Details
Adds
setStrictModeForTest($enabled = true). This runs a backtrace to determine the currently running test, records the test name and preference as an associative array inWP_Mock::$__strict_mode_for_individual_test, thenWP_Mock::strictMode()has been updated to check a new function::isStrictModeForTest()which again determines the running test and if it has been set, uses the set value in preference to the default (bootstrapped) value.NB: If tests are written using
@testannotations or#[Test]attribute, they will not be recognised as tests.An easier possibility would be to use
WP_Mock\Tools\TestCaseand use its set-up/tear-down methods, but that's not how I generally use this tool myself.Once I get feedback and think a bit more about this, I'll add the appropriate documentation.
Contributor checklist
Testing
Tests added, phpcs passing, phpstan passing.
Reviewer checklist