Skip to content

Prepare for phpunit 13#1340

Merged
frankdekker merged 5 commits intomasterfrom
Prepare-for-phpunit-13
Feb 15, 2026
Merged

Prepare for phpunit 13#1340
frankdekker merged 5 commits intomasterfrom
Prepare-for-phpunit-13

Conversation

@frankdekker
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings February 15, 2026 19:49
@codecov
Copy link

codecov bot commented Feb 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.98%. Comparing base (304574c) to head (9a54751).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1340   +/-   ##
=========================================
  Coverage     99.98%   99.98%           
  Complexity     3477     3477           
=========================================
  Files           610      610           
  Lines          9620     9620           
=========================================
  Hits           9619     9619           
  Misses            1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the test suite to be compatible with newer PHPUnit behavior (per PR title “Prepare for phpunit 13”), primarily by replacing “mocks used as stubs” with explicit stubs and tightening interaction expectations so tests are more deterministic.

Changes:

  • Replaced many createMock() usages with static::createStub() where only stubbing is needed.
  • Added explicit $this->never() expectations in “early return / guard clause” test paths to prevent unintended interactions.
  • Updated base test classes (AbstractTestCase, AbstractControllerTestCase) to use a stubbed logger type.

Reviewed changes

Copilot reviewed 231 out of 232 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/Unit/ViewModelProvider/UserViewModelProviderTest.php Use stubs for view objects; tighten form factory expectations.
tests/Unit/ViewModelProvider/UserSettingViewModelProviderTest.php Use stubs + add “never called” expectations for unrelated deps.
tests/Unit/ViewModelProvider/RevisionViewModelProviderTest.php Use stubs for paginator/forms; add “never called” assertions for non-used services per path.
tests/Unit/ViewModelProvider/ReviewsViewModelProviderTest.php Use stubs for request/paginator/terms; add guard-path “never” expectations.
tests/Unit/ViewModelProvider/ReviewViewModelProviderTest.php Use stubs for DTO inputs where only getters are needed.
tests/Unit/ViewModelProvider/ReviewTimelineViewModelProviderTest.php Add “never” expectations for non-invoked collaborators in specific paths.
tests/Unit/ViewModelProvider/ProjectsViewModelProviderTest.php Use stubbed view model where behavior isn’t asserted.
tests/Unit/ViewModelProvider/Mail/MailCommentViewModelProviderTest.php Use stubbed translator.
tests/Unit/ViewModelProvider/Mail/CommitsViewModelProviderTest.php Use stubbed commit where no behavior is asserted.
tests/Unit/ViewModelProvider/LoginViewModelProviderTest.php Use stubbed FormView.
tests/Unit/ViewModelProvider/FileReviewViewModelProviderTest.php Use stubbed FileDiffViewModel.
tests/Unit/ViewModelProvider/CommentViewModelProviderTest.php Add “never create form” expectations on null-comment paths.
tests/Unit/ViewModelProvider/CodeQualityViewModelProviderTest.php Add explicit “never” interactions for early-return scenarios; tighten repo call expectations.
tests/Unit/ViewModelProvider/Appender/Review/RevisionViewModelAppenderTest.php Add “never call provider” expectation for accepts() path; use stubbed view model.
tests/Unit/ViewModelProvider/Appender/Review/ReviewSummaryViewModelAppenderTest.php Add “never call provider” expectation for accepts(); use stubs.
tests/Unit/ViewModelProvider/Appender/Review/FileTreeViewModelAppenderTest.php Add “never” expectations in accepts(); use stubs for view model inputs.
tests/Unit/ViewModelProvider/Appender/Review/FileDiffViewModelAppenderTest.php Add “never call provider” expectation for accepts(); stub view model.
tests/Unit/ViewModelProvider/Appender/Review/BranchReviewViewModelAppenderTest.php Add “never create form” expectation for accepts(); stub view.
tests/Unit/ViewModel/App/Revision/ReviewRevisionViewModelTest.php Use stubbed FormView instances.
tests/Unit/ViewModel/App/Review/ReviewsViewModelTest.php Use stubs for paginator/timeline VM dependencies.
tests/Unit/ViewModel/App/Review/FileTreeViewModelTest.php Add “never” expectations for unrelated collaborators per method under test; stub nodes where possible.
tests/Unit/ViewModel/App/Review/CodeQualityViewModelTest.php Use stubbed LineCoverage.
tests/Unit/ViewModel/App/Project/ProjectsViewModelTest.php Use stubbed TimelineViewModel.
tests/Unit/Twig/IdeButtonExtensionTest.php Replace static::never() with $this->never() style.
tests/Unit/Twig/CommentUrlExtensionTest.php Use stubs for CodeReview where only accessors are used.
tests/Unit/Service/Webhook/WebhookNotifierTest.php Use stubbed event; add “never execute” expectation for unknown review path.
tests/Unit/Service/Webhook/WebhookExecutionServiceTest.php Use stubs for response/exceptions; adjust response stubbing; tighten expected saves.
tests/Unit/Service/Webhook/ReviewRevisionEventServiceTest.php Add “never getReviewersState” on minimal event scenarios.
tests/Unit/Service/Webhook/ReviewEventServiceTest.php Add “never getReviewersState” where it shouldn’t be called.
tests/Unit/Service/User/UserEntityProviderTest.php Add “never” expectations for alternate user lookup sources per path.
tests/Unit/Service/User/GitlabUserServiceTest.php Stub GitlabApi; add “never call remote” expectations for cached paths.
tests/Unit/Service/Search/RipGrep/Command/RipGrepProcessExecutorTest.php Use stubbed command builder where only stubbing is needed.
tests/Unit/Service/RuleProcessorTest.php Add guard-path “never emphasize/exclude” expectations.
tests/Unit/Service/Revision/RevisionVisibilityServiceTest.php Add “never getUser()” expectations when user is explicitly passed.
tests/Unit/Service/Revision/RevisionFetchServiceTest.php Stub logger; add “never save/dispatch” expectations for no-op fetch cases.
tests/Unit/Service/Report/Coverage/CodeCoverageParserProviderTest.php Switch parser to stub type and stub creation.
tests/Unit/Service/Report/CodeInspection/CodeInspectionIssueParserProviderTest.php Use stubbed parser.
tests/Unit/Service/RemoteEvent/Gitlab/PushEventHandlerTest.php Add “never dispatch/find” expectations for invalid event path.
tests/Unit/Service/RemoteEvent/Gitlab/ApprovedMergeRequestEventHandlerTest.php Add “never” expectations for non-handled actions / early returns.
tests/Unit/Service/Parser/GitLogParserTest.php Add “never” expectations for non-executed collaborators per scenario.
tests/Unit/Service/Parser/DiffParserTest.php Add “never parse” expectation for deletion-only scenario.
tests/Unit/Service/Parser/DiffFileParserTest.php Add “never parse blocks” expectations for mode/binary-only cases.
tests/Unit/Service/Mercure/MessagePublisherTest.php Use stubbed URIs for update messages.
tests/Unit/Service/Markdown/DocumentNodeIteratorFactoryTest.php Use stubbed CommonMark nodes.
tests/Unit/Service/Mail/MailRecipientServiceTest.php Add “never” expectations to enforce correct branch logic for recipient selection.
tests/Unit/Service/Mail/CommentMailServiceTest.php Tighten expectations around VM creation even in “no mail sent” paths.
tests/Unit/Service/Git/Show/GitShowServiceTest.php Add “never parse/createPattern” expectations for direct content reads.
tests/Unit/Service/Git/Review/Strategy/HesitantCherryPickStrategyTest.php Add “never” expectations to ensure the correct strategy path is taken.
tests/Unit/Service/Git/Review/Strategy/BasicCherryPickStrategyTest.php Add “never bundled diff” expectations on failure paths.
tests/Unit/Service/Git/Review/ReviewDiffService/ReviewDiffServiceTest.php Add “never call strategies” expectations where not applicable.
tests/Unit/Service/Git/Review/ReviewDiffService/RecoverableReviewDiffServiceTest.php Use stubbed exceptions.
tests/Unit/Service/Git/Review/ReviewDiffService/CacheableReviewDiffServiceTest.php Add “never call underlying diff service” for no-revisions path.
tests/Unit/Service/Git/Review/CodeReviewerServiceTest.php Add “never state resolver” expectation where not used.
tests/Unit/Service/Git/Log/LockableGitLogServiceTest.php Use stubbed Commit.
tests/Unit/Service/Git/Log/GitLogCommandFactoryTest.php Stub factory; replace static::never() with $this->never() style.
tests/Unit/Service/Git/Grep/GitGrepServiceTest.php Use stubbed Process instances.
tests/Unit/Service/Git/GitRepositoryServiceTest.php Stub logger/repo; replace static::never() with $this->never(); use stubs where appropriate.
tests/Unit/Service/Git/GitRepositoryLockManagerTest.php Add “never mkdir” expectation for exception bubbling test.
tests/Unit/Service/Git/Fetch/GitFetchRemoteRevisionServiceTest.php Stub logger.
tests/Unit/Service/Git/Diff/Optimizer/DiffLineChangeSetDifferTest.php Use stubbed iterator; add “never compare” guard; remove logger expectation due to logger stub.
tests/Unit/Service/Git/Diff/GitDiffCommandFactoryTest.php Stub factory; replace static::never() with $this->never().
tests/Unit/Service/Git/Commit/CommitBundlerTest.php Use stubbed combiner.
tests/Unit/Service/Git/Checkout/RecoverableGitCheckoutServiceTest.php Use stubbed exception.
tests/Unit/Service/Git/CacheableGitRepositoryServiceTest.php Stub logger/location service/repository.
tests/Unit/Service/Git/Branch/GitBranchServiceTest.php Add “never parse” expectations for delete/early-failure paths.
tests/Unit/Service/CodeReview/Search/ReviewSearchQueryTermFactoryTest.php Stub parser factory.
tests/Unit/Service/CodeReview/FileSeenStatusServiceTest.php Add “never” expectations for non-used collaborators per path.
tests/Unit/Service/CodeReview/DiffFinderTest.php Add “never exactMatch” expectations where not required.
tests/Unit/Service/CodeReview/Comment/CommonMarkdownConverterTest.php Stub dispatcher.
tests/Unit/Service/CodeReview/Comment/CommentMentionServiceTest.php Add “never findAll/saveAll” expectations for non-mention paths.
tests/Unit/Service/CodeReview/Comment/ActivityCommentProviderTest.php Add “never” expectations for non-used repositories per event type.
tests/Unit/Service/CodeReview/CodeReviewRevisionServiceTest.php Add “never” expectations for services not involved in specific branches.
tests/Unit/Service/CodeReview/CodeReviewRevisionMatcherTest.php Add “never” expectations to enforce fast-fail logic.
tests/Unit/Service/CodeReview/CodeReviewFileServiceTest.php Add “never fileTreeService” expectation when cache path is used.
tests/Unit/Service/CodeReview/CodeReviewFactoryTest.php Add “never normalize” expectation for branch review creation path.
tests/Unit/Service/CodeReview/CodeReviewDtoProviderTest.php Switch request double to stub type; update typing accordingly.
tests/Unit/Service/CodeReview/CodeReviewCreationServiceTest.php Add “never getTargetBranch” expectation for revision-based creation.
tests/Unit/Service/CodeReview/CodeReviewActivityPublisherTest.php Add “never” expectations when formatter returns null.
tests/Unit/Service/CodeReview/CodeReviewActivityFormatterTest.php Stub URL generator in setup; add “never find” expectations for specific formatting paths.
tests/Unit/Service/CodeReview/CodeReviewActionFactoryTest.php Add “never find” expectations for absent/unknown action paths.
tests/Unit/Service/CodeReview/ChangeReviewerStateServiceTest.php Stub ManagerRegistry.
tests/Unit/Service/CodeReview/Branch/BranchReviewTargetBranchServiceTest.php Add “never GitLab call” expectation for default target branch.
tests/Unit/Service/CodeReview/Activity/CodeReviewActivityVariableFactoryTest.php Add “never generate” expectation for pure variable creation.
tests/Unit/Service/CodeReview/Activity/CodeReviewActivityUrlGeneratorTest.php Add “never replyRepository->find” expectations where not needed.
tests/Unit/Service/CodeHighlight/HighlightedFileServiceTest.php Add “never” expectations for guard paths; update throws docblock to Throwable.
tests/Unit/Service/Api/Gitlab/UsersTest.php Stub logger.
tests/Unit/Service/Api/Gitlab/ReviewMergeRequestServiceTest.php Switch GitlabApi double to stub; add guard-path “never” expectations.
tests/Unit/Service/Api/Gitlab/ReviewApprovalServiceTest.php Add “never” expectations for skipped approval branches.
tests/Unit/Service/Api/Gitlab/OAuth2AuthenticatorTest.php Add “never getAccessToken” for non-expired token path.
tests/Unit/Service/Api/Gitlab/MergeRequestsTest.php Stub response objects; add “never deserialize” for endpoints returning raw arrays/status codes.
tests/Unit/Service/Api/Gitlab/GitlabCommentReplyServiceTest.php Switch GitlabApi to stub; add save “never” expectations on skip paths.
tests/Unit/Service/Api/Gitlab/GitlabApiTest.php Stub client/serializer.
tests/Unit/Service/Api/Gitlab/GitlabApiProviderTest.php Switch serializer to stub; add guard-path “never” expectations.
tests/Unit/Service/Api/Gitlab/DiscussionsTest.php Stub response objects.
tests/Unit/Service/Ai/Tool/CodeReviewListFilesToolTest.php Add “never listFiles” expectations for error paths.
tests/Unit/Service/Ai/Tool/CodeReviewGrepToolTest.php Add “never” expectations for invalid regex / missing review / no revisions.
tests/Unit/Service/Ai/Tool/CodeReviewFileToolTest.php Add “never getFileContents” expectations for error paths.
tests/Unit/Service/Ai/Tool/CodeReviewAddCommentToolTest.php Add “never” expectations for error path.
tests/Unit/Security/Voter/AssetVoterTest.php Use stubbed tokens; adjust type imports.
tests/Unit/Security/AzureAd/LoginServiceTest.php Add “never getAccessToken” expectations for failure paths; use stubbed tokens.
tests/Unit/Security/Api/BearerAuthenticatorTest.php Add “never findOneBy” expectations in supports/success/failure paths; use stubbed token.
tests/Unit/Router/ReviewRouterTest.php Add “never setContext” expectations for parameter validation errors.
tests/Unit/Request/Review/ReviewRequestTest.php Add “never createFromRequest” expectations for getters/validation rules; stub action.
tests/Unit/Request/Comment/GetCommentThreadRequestTest.php Stub action; add “never createFromRequest” expectation for validation rules.
tests/Unit/Request/AbstractRequestTestCase.php Stub constraint.
tests/Unit/Repository/Expression/QueryExpressionFactoryTest.php Use stubs for terms/expressions where behavior isn’t asserted.
tests/Unit/RemoteEventConsumer/GitlabRemoteEventConsumerTest.php Add “never handle/denormalize” expectations for invalid event.
tests/Unit/Model/Mercure/UpdateMessageTest.php Use stubbed URIs.
tests/Unit/MessageHandler/WebhookEventMessageHandlerTest.php Stub event.
tests/Unit/MessageHandler/RevisionTopoOrderMessageHandlerTest.php Stub logger.
tests/Unit/MessageHandler/RevisionFilesMessageHandlerTest.php Add “never save/getRevisionFiles” expectations for missing revision.
tests/Unit/MessageHandler/ReviewActivityMessageHandlerTest.php Stub unsupported event; add “never publish/save” expectations.
tests/Unit/MessageHandler/NewRevisionMessageHandlerTest.php Stub logger; add “never” expectations for early returns; tighten side-effect expectations.
tests/Unit/MessageHandler/NewRevisionBranchReviewMessageHandlerTest.php Add “never” expectations for early return scenarios.
tests/Unit/MessageHandler/MailNotificationMessageHandlerTest.php Add “never bus dispatch” expectations for delay/unknown handler paths.
tests/Unit/MessageHandler/Mail/MailNotificationHandlerProviderTest.php Stub handler.
tests/Unit/MessageHandler/Mail/CommentUpdatedMailNotificationHandlerTest.php Add “never” expectations in accepts() / early return branches.
tests/Unit/MessageHandler/Mail/CommentResolvedMailNotificationHandlerTest.php Add “never” expectations in accepts() / early return branches.
tests/Unit/MessageHandler/Mail/CommentReplyUpdatedMailNotificationHandlerTest.php Add “never” expectations in accepts() / early return branches.
tests/Unit/MessageHandler/Mail/CommentReplyAddedMailNotificationHandlerTest.php Add “never” expectations in accepts() / early return branches.
tests/Unit/MessageHandler/Mail/CommentAddedMailNotificationHandlerTest.php Add “never” expectations in accepts() / early return branches.
tests/Unit/MessageHandler/Gitlab/ReviewerStateChangeMessageHandlerTest.php Add “never validate/approve” expectations when disabled.
tests/Unit/MessageHandler/Gitlab/CommentUpdatedMessageHandlerTest.php Add “never” expectations for disabled/no-api paths; stub GitlabApi.
tests/Unit/MessageHandler/Gitlab/CommentResolvedMessageHandlerTest.php Add “never” expectations for disabled/no-api paths; stub GitlabApi.
tests/Unit/MessageHandler/Gitlab/CommentReplyAddedMessageHandlerTest.php Add “never” expectations for disabled/no-api paths; stub GitlabApi.
tests/Unit/MessageHandler/Gitlab/CommentDeletedMessageHandlerTest.php Add “never” expectations for disabled/no-api paths; stub GitlabApi.
tests/Unit/MessageHandler/Gitlab/CommentAddedMessageHandlerTest.php Add “never” expectations for disabled/no-api/no-MR paths; stub GitlabApi.
tests/Unit/MessageHandler/FetchRepositoryRevisionsMessageHandlerTest.php Stub logger; add “never” expectations on unknown repository failure.
tests/Unit/MessageHandler/DiffFileCacheMessageHandlerTest.php Stub logger; add “never getLoad” expectation when review missing.
tests/Unit/MessageHandler/CommitRemovedMessageHandlerTest.php Add “never” expectations for downstream operations when revision absent.
tests/Unit/MessageHandler/CommitAddedMessageHandlerTest.php Add “never save/dispatch” expectations when commit absent.
tests/Unit/MessageHandler/AiReviewRequestedMessageHandlerTest.php Add “never generate/trans” expectations when review not found.
tests/Unit/Input/AddExternalLinkInputTest.php Use stubbed input interface.
tests/Unit/Form/User/UserProfileFormTypeTest.php Add “never generate” expectation in options configure test.
tests/Unit/Form/Review/Revision/RevisionVisibilityFormTypeTest.php Add “never generate” expectations in configure/prefix tests.
tests/Unit/Form/Review/Revision/DetachRevisionsFormTypeTest.php Add “never generate” expectations in configure/prefix tests.
tests/Unit/Form/Review/EditCommentReplyFormTypeTest.php Add “never generate” expectation in configure options test.
tests/Unit/Form/Review/EditCommentFormTypeTest.php Add “never generate” expectation in configure options test.
tests/Unit/Form/Review/CommentTagTypeTest.php Switch translator to stub type; adjust imports/typing.
tests/Unit/Form/Review/ChangeReviewTargetBranchFormTypeTest.php Add “never generate/getRemoteBranches” expectations in non-build tests.
tests/Unit/Form/Review/AddReviewerFormTypeTest.php Add “never” expectations for dependencies in configure/prefix tests.
tests/Unit/Form/Review/AddCommentReplyFormTypeTest.php Add “never generate” expectation in configure options.
tests/Unit/Form/Review/AddCommentFormTypeTest.php Add “never generate” expectations; ensure setter test doesn’t trigger URL generation.
tests/Unit/Form/Repository/RepositoryTypeTest.php Add “never generate/findBy” expectations for non-build methods.
tests/Unit/Form/Repository/RepositoryChoiceTypeTest.php Add “never findBy” expectation for getParent() test.
tests/Unit/ExternalTool/Gitlab/GitlabServiceTest.php Switch GitlabApi to stub; add “never call other API” expectations per method.
tests/Unit/ExternalTool/Gitlab/GitlabIntegrationTest.php Replace static::never() with $this->never(); stub Commit where needed.
tests/Unit/EventSubscriber/ProblemJsonResponseSubscriberTest.php Stub kernel; add “never createFromThrowable” in subscribed events test.
tests/Unit/EventSubscriber/MarkDown/AbsoluteImageUrlSubscriberTest.php Use stubbed document/node where behavior isn’t asserted.
tests/Unit/EventSubscriber/MandatoryGitlabSyncSubscriberTest.php Stub kernel in RequestEvent factory.
tests/Unit/EventSubscriber/ContentSecurityPolicyResponseSubscriberTest.php Stub kernel; add “never getUrl” in subscribed events test.
tests/Unit/EventSubscriber/AddReviewToCommitSubscriberTest.php Add “never findOneByCommitHash” expectation for event subscription test.
tests/Unit/EventSubscriber/AccessDeniedExceptionSubscriberTest.php Stub kernel; add “never generate” expectations where applicable.
tests/Unit/Entity/Repository/RepositoryCredentialTest.php Use stubbed credential interface for invalid credential test.
tests/Unit/Entity/Notification/RuleConfigurationTest.php Use stubbed DatePeriod.
tests/Unit/Doctrine/Type/UriTypeTest.php Add “never SQL declaration” expectations in methods not requiring platform declarations.
tests/Unit/Doctrine/Type/SpaceSeparatedStringValueTypeTest.php Add “never SQL declaration” expectations in non-declaration tests.
tests/Unit/Doctrine/Type/LineCoverageTypeTest.php Add “never SQL declaration” expectations in non-declaration tests.
tests/Unit/Doctrine/Type/AbstractEnumTypeTest.php Use stubbed platform in enum type tests.
tests/Unit/Controller/Auth/RegistrationControllerTest.php Use stubbed view; add “never” expectations for non-submitted path.
tests/Unit/Controller/Auth/LoginControllerTest.php Stub view model; add “never” expectations for redirect paths.
tests/Unit/Controller/App/User/UserSettingControllerTest.php Use stubbed FormView inside view model.
tests/Unit/Controller/App/User/UserMentionSuggestControllerTest.php Stub request.
tests/Unit/Controller/App/User/UserAccessTokenControllerTest.php Stub view models; add “never issue” expectation on invalid submission.
tests/Unit/Controller/App/User/Gitlab/UserGitlabOAuth2StartControllerTest.php Stub session.
tests/Unit/Controller/App/User/Gitlab/UserGitlabOAuth2FinishControllerTest.php Add “never” expectations for absent code / invalid state paths.
tests/Unit/Controller/App/Search/SearchCodeControllerTest.php Stub requests; add “never findBy” expectation for too-short search.
tests/Unit/Controller/App/Search/SearchBranchesControllerTest.php Stub request.
tests/Unit/Controller/App/Revision/UpdateRevisionVisibilityControllerTest.php Add “never saveAll” expectation on bad submit.
tests/Unit/Controller/App/Revision/RevisionsControllerTest.php Stub revisions view model.
tests/Unit/Controller/App/Revision/DetachRevisionControllerTest.php Add “never save/dispatch” expectations for bad submit.
tests/Unit/Controller/App/Revision/AttachRevisionSelectionControllerTest.php Stub revisions view model.
tests/Unit/Controller/App/Reviews/SearchReviewsControllerTest.php Stub request/terms/view models; add “never format” expectations.
tests/Unit/Controller/App/Reviews/ReviewsControllerTest.php Stub request/terms/view models; add “never format” expectations.
tests/Unit/Controller/App/Review/UpdateFolderCollapseStatusControllerTest.php Add “never save” expectation on bad request.
tests/Unit/Controller/App/Review/UpdateFileSeenStatusControllerTest.php Stub request; add “never markAsSeen” expectation when no diff match.
tests/Unit/Controller/App/Review/Setting/ReviewDiffModeControllerTest.php Replace static::once() with $this->once() style.
tests/Unit/Controller/App/Review/Setting/DiffVisibleLinesControllerTest.php Replace static::once() with $this->once() style.
tests/Unit/Controller/App/Review/Setting/DiffComparisonPolicyControllerTest.php Replace static::once() with $this->once() style.
tests/Unit/Controller/App/Review/Reviewer/RemoveReviewerControllerTest.php Switch ManagerRegistry to stub type; adjust setup.
tests/Unit/Controller/App/Review/Reviewer/AddReviewerControllerTest.php Add “never” expectations for non-submitted/invalid submission paths.
tests/Unit/Controller/App/Review/ReviewFileTreeControllerTest.php Stub view model.
tests/Unit/Controller/App/Review/ReviewControllerTest.php Stub request; add “never” expectations for redirect route scenario.
tests/Unit/Controller/App/Review/GetMergeRequestForReviewControllerTest.php Add “never” expectations for missing GitLab URL / project id paths.
tests/Unit/Controller/App/Review/GetFileReviewControllerTest.php Stub requests.
tests/Unit/Controller/App/Review/CreateReviewFromRevisionControllerTest.php Add “never” expectations for attached-review guard.
tests/Unit/Controller/App/Review/CreateBranchReviewControllerTest.php Add “never” expectations for missing branch / existing review paths.
tests/Unit/Controller/App/Review/Comment/UpdateCommentReplyControllerTest.php Switch translator to stub type; add “never save/dispatch” expectations for missing/not-submitted paths.
tests/Unit/Controller/App/Review/Comment/UpdateCommentControllerTest.php Switch translator to stub type; add “never save” expectations for missing/not-submitted paths.
tests/Unit/Controller/App/Review/Comment/GetCommentThreadControllerTest.php Stub request; add “never getEditCommentViewModel” expectation in default path.
tests/Unit/Controller/App/Review/Comment/GetAddCommentFormControllerTest.php Stub request and form view.
tests/Unit/Controller/App/Review/Comment/DeleteCommentReplyControllerTest.php Add “never” expectations for missing-comment exception path.
tests/Unit/Controller/App/Review/Comment/DeleteCommentControllerTest.php Add “never” expectations for missing-comment exception path.
tests/Unit/Controller/App/Review/Comment/CommentVisibilityControllerTest.php Replace static::once() with $this->once() style.
tests/Unit/Controller/App/Review/Comment/ChangeCommentStateControllerTest.php Switch translator to stub type; add “never save” expectation for missing comment path.
tests/Unit/Controller/App/Review/Comment/AddCommentReplyControllerTest.php Switch translator to stub type; add “never save/dispatch” expectations for missing/not-submitted paths.
tests/Unit/Controller/App/Review/Comment/AddCommentReactionControllerTest.php Use stubbed request.
tests/Unit/Controller/App/Review/Comment/AddCommentControllerTest.php Add “never save” expectation for not-submitted form.
tests/Unit/Controller/App/Review/ChangeTargetBranchControllerTest.php Add “never save” expectation for failure path.
tests/Unit/Controller/App/Project/ViewRevisionFileControllerTest.php Add “never convert” expectations for binary/invalid mimetype paths.
tests/Unit/Controller/App/Project/ProjectsControllerTest.php Stub projects view model.
tests/Unit/Controller/App/Project/ProjectBranchesControllerTest.php Stub view model.
tests/Unit/Controller/App/Notification/RuleNotificationControllerTest.php Add “never process/save/getViewModel” expectations on access-denied path; stub commit.
tests/Unit/Controller/App/Notification/RuleHistoryControllerTest.php Stub view model.
tests/Unit/Controller/App/Notification/RuleControllerTest.php Add “never save” expectations for error paths; stub form view.
tests/Unit/Controller/App/Notification/DeleteRuleControllerTest.php Add “never remove/trans” expectations for unauthorized user path.
tests/Unit/Controller/App/Admin/Webhook/WebhooksControllerTest.php Stub view model.
tests/Unit/Controller/App/Admin/Webhook/WebhookControllerTest.php Add “never save” expectations for not-found/edit-not-submitted; stub form view.
tests/Unit/Controller/App/Admin/RepositoryControllerTest.php Add “never save/dispatch” expectations for not-found/not-submitted; stub form view.
tests/Unit/Controller/App/Admin/Credentials/CredentialsControllerTest.php Stub view model.
tests/Unit/Controller/App/Admin/Credentials/CredentialControllerTest.php Add “never save/findBy/dispatch” expectations for not-found/edit-not-submitted; stub form view.
tests/Unit/Controller/Api/Report/UploadCodeInspectionControllerTest.php Stub requests; add “never remove/parse” expectations for not-found/empty-body paths.
tests/Unit/Controller/Api/Report/UploadCodeCoverageControllerTest.php Stub requests; add “never save/parse” expectations for not-found/empty-body paths.
tests/Unit/Command/TestMailCommandTest.php Add “never send” expectation for configure test.
tests/Unit/Command/Review/BranchReviewCloseCommandTest.php Add “never reviewStateChanged” expectations in no-op paths.
tests/Unit/Command/MailCommandTest.php Add guard-path “never” expectations in configure/invalid-frequency/exception paths; replace static::never() with $this->never() style.
tests/Unit/ApiPlatform/StateProcessor/CodeReviewProcessorTest.php Add “never” expectations for unsupported operations and non-event-emitting paths.
tests/Unit/ApiPlatform/Provider/CodeReviewProviderTest.php Add guard-path “never” expectations; stub output.
tests/Unit/ApiPlatform/Provider/CodeReviewActivityProviderTest.php Add guard-path “never” expectations; stub output.
tests/Unit/ApiPlatform/Factory/CodeReviewOutputFactoryTest.php Use stubbed UserOutput.
tests/Functional/Command/MailCommandTest.php Switch repository service to stub type; adjust container overrides to use stubs.
tests/AbstractTestCase.php Switch logger to Stub&LoggerInterface and create via createStub().
tests/AbstractControllerTestCase.php Switch logger to Stub&LoggerInterface and create via createStub().

@frankdekker frankdekker merged commit 2a2031a into master Feb 15, 2026
5 checks passed
@frankdekker frankdekker deleted the Prepare-for-phpunit-13 branch February 15, 2026 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant